1443025 - Item dragged from Overflow Menu into toolbar placed at wrong position

Status: NEW

(Firefox :: Toolbars and Customization, defect, P3)

Description

[Oriol Brufau [:Oriol]]

Attachment: screencast.gif

1. Go to Costumize...
2. Place some item into the Overflow Menu if there is none
3. Drag an item from the Overflow Menu into the toolbar

Expected: the item appears where your mouse pointer is
Result: the item appears some positions to the right of your mouse

Regression window: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=ad2e7c189a20d3b22d3343820522cc6a17a6d9d3&tochange=5193b9173c69a2976422bc6e4d161846e72fc714

Comment 1

[Oriol Brufau [:Oriol]]

Seems caused by https://searchfox.org/mozilla-central/rev/a0665934fa05158a5a943d4c8b277465910c029c/browser/themes/shared/customizableui/panelUI.inc.css#400

Can this just be removed?

Comment 2

[:Gijs (he/him)]

(In reply to Oriol Brufau [:Oriol] from comment #1)
> Seems caused by
> https://searchfox.org/mozilla-central/rev/
> a0665934fa05158a5a943d4c8b277465910c029c/browser/themes/shared/
> customizableui/panelUI.inc.css#400
> 
> Can this just be removed?

Then the toolbar buttons don't take up the full width of the menupanel in customize mode, which means the arrows don't appear at the right hand side, and you can't drag the items except from their label text (so where you can drag items depends on the length of the label), all of which is not desired. So, no.

Comment 3

[:Gijs (he/him)]

Egh, didn't mean to clear my self-ni.

I looked into fixing this in the past and I don't see a straightforward way of doing it, given how the rest of customize mode works. AFAICT we'd have to more thoroughly rethink how we measure items for placement in the UI in customize mode.

Given the death of XPI add-ons that might be feasible, we could just assume that anything that isn't the search bar or url bar has essentially the same width in the toolbar, and everything has the same height in the menupanel, for the purposes of making space for items while dragging. That would also potentially remove some sync reflows. Jared, do you see any issues with that idea?

Comment 4

[:Gijs (he/him)]

(In reply to :Gijs (he/him) from comment #3)
> we could just assume
> that anything that isn't the search bar or url bar has essentially the same
> width in the toolbar, and everything has the same height in the menupanel,

err, except the bookmarks toolbar items. I think that's it, though - we don't really have any other items that have flex in the toolbar, or are significantly wider/narrower than a "regular" toolbar button? I think?

Comment 5

[Jared Wein [:jaws] (please needinfo? me)]

cut/copy/paste and zoom buttons, but the list is short enough that we could have a fixed size for these one-off cases. Yeah, I think we can do what you've described in comment #3.