1443038 - Web Replay: Debugger improvements

Status: RESOLVED INVALID

(Core :: General, enhancement)

Description

[Brian Hackett [Laid off!]]

This bug will track fixes and improvements to the code used to inspect a recording/replaying process from the debugger --- the C++ replay debugger layer, some related bits in the record/replay system, and any record/replay changes needed to the debugger server code.

Comment 1

[Brian Hackett [Laid off!]]

Attachment: Part 1 - Always initialize InvokeArgs for objectCall messages.

InvokeArgs structures always need explicit initialization to avoid crashing.

Comment 2

[Brian Hackett [Laid off!]]

Attachment: Part 2 - Avoid bogus assert when registering triggers after recording has diverged.

Fix a bogus assert that was encountered while paused at a breakpoint and performing an operation that used the RegisterTrigger record/replay API (these are mainly used for handling deferred releases of nsISupports thing references during GC object destructors).

Comment 3

[Brian Hackett [Laid off!]]

Attachment: Part 3 - Add test for rewinding to breakpoints.

Add a test that rewinding through breakpoints works, and move around the existing recording-only test.

Comment 4

[Brian Hackett [Laid off!]]

https://hg.mozilla.org/projects/ash/rev/8624875b040f287a8a77dd89807c5670121cb98f
https://hg.mozilla.org/projects/ash/rev/c50687bffb7e7a5601171aafe85eb632afaadeca
https://hg.mozilla.org/projects/ash/rev/0f9b16dbc1f2caf1e1332a7d2daada7c5fccb64b

Comment 5

[Brian Hackett [Laid off!]]

Attachment: Part 4 - Improve breakpoint test, add basic stepping test.

This patch adds some infrastructure to the common JS file used for debugger tests so that breakpoint/stepping tests can be written cleanly using async/await.

Comment 6

[Brian Hackett [Laid off!]]

Attachment: Part 5 - Fix bugs with stepping at beginning of frames and reverse-step-in.

Fix some bugs that were causing forward-stepping to not work as expected at the beginning of frames, and reverse-stepping-in to not work at all.  Now with test coverage!

Comment 7

[Brian Hackett [Laid off!]]

https://hg.mozilla.org/projects/ash/rev/97f85a6cb3a4b0233bc921a2e7785e83df21eddf
https://hg.mozilla.org/projects/ash/rev/2412de2895708e2793d1fcaa60d3aa55ff59cf77

Comment 8

[Brian Hackett [Laid off!]]

Attachment: Part 6 - Fix incorrect use of cross-zone string.

Fix a crash I saw while testing.

Comment 9

[Brian Hackett [Laid off!]]

https://hg.mozilla.org/projects/ash/rev/f4ffb4768ece3d0b2b17ec37fe9bf306c69003c2

Comment 10

[Brian Hackett [Laid off!]]

Attachment: Part 7 - Watch for null debugger frames.

Fix a crash while tracing replay debugger information in the middleman process.

https://hg.mozilla.org/projects/ash/rev/e06d287a629ad3dd1a946c8981ae389a08e5c3ed

Comment 11

[Brian Hackett [Laid off!]]

Closing this bug, all the changes here will be reviewed in separate bugs dependent on bug 1422587.