1443147 - JS Shell builds broken on POSIX since bug 1441454

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect, P1)

Description

[Alex Gaynor [:Alex_Gaynor]]

Errors look like:

Step #4: In file included from /src/mozilla-central/js/src/build_DBG.OBJ/js/src/shell/Unified_cpp_js_src_shell0.cpp:11:
Step #4: /src/mozilla-central/js/src/shell/js.cpp:8893:9: error: unknown type name 'PRLibSpec'
Step #4:         PRLibSpec libSpec;
Step #4:         ^
Step #4: /src/mozilla-central/js/src/shell/js.cpp:8894:24: error: use of undeclared identifier 'PR_LibSpec_Pathname'
Step #4:         libSpec.type = PR_LibSpec_Pathname;
Step #4:                        ^
Step #4: /src/mozilla-central/js/src/shell/js.cpp:8896:59: error: use of undeclared identifier 'PR_LD_NOW'
Step #4:         PRLibrary* dll = PR_LoadLibraryWithFlags(libSpec, PR_LD_NOW | PR_LD_GLOBAL);
Step #4:                                                           ^
Step #4: /src/mozilla-central/js/src/shell/js.cpp:8896:71: error: use of undeclared identifier 'PR_LD_GLOBAL'
Step #4:         PRLibrary* dll = PR_LoadLibraryWithFlags(libSpec, PR_LD_NOW | PR_LD_GLOBAL);
Step #4:                                                                       ^
Step #4: 4 errors generated.

Comment 1

[Jason Orendorff [:jorendorff]]

Steve, if you can get to this today, great; if not -- well, it happens on my machine, so I will be taking a look soon. :)

Comment 2

[Jason Orendorff [:jorendorff]]

Attachment: Fix PosixNSPR build after bug 1441454

Comment 3

[Steve Fink [:sfink] [:s:]]

Comment on attachment 8956515 [details] [diff] [review]
Fix PosixNSPR build after bug 1441454

Review of attachment 8956515 [details] [diff] [review]:
-----------------------------------------------------------------

Yeah, ok. I have a patch that moves in the direction I'd like to go, by creating a new library loading interface (and then implementing it on top of NSPR if it is being used, otherwise using POSIX APIs). It would have been nice and easy, except I wanted to make it return a Result<>, and that got into the details of NSPR error handling... anyway, it works, but it's much too large a fix for this small issue. Your patch is better.

I still hope to improve my patch to work cross-platform, add in the 2 additional APIs needed by ctypes, and remove direct NSPR usage from spidermonkey entirely. Then expand out the non-NSPR implementation coverage until we can remove NSPR from spidermonkey.

If that isn't the very definition of overkill for this bug, then I don't know what is.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/926f80f2c5cc
Fix PosixNSPR build after bug 1441454. r=sfink

Comment 5

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/926f80f2c5cc