1443157 - gUM capture doesn't display capture indicators in notification tray on Android

Status: VERIFIED FIXED

Description

[Andreas Pehrson [:pehrsons] (PTO until July 29)]

STR:
1 go to https://mozilla.github.io/webrtc-landing/gum_test.html
2 click Audio & Video
3 approve the permission request

Expected: An entry in the notification tray saying that Firefox is currently capturing the user's camera and microphone.

Actual: No entry in the notification tray.


This reproduces on Nightly 60, *not* on 58 or 59.

The working hypothesis so far is that bug 1299515 regressed this, as it changed some of the backend logic and signaling bits for this.

Comment 1

[Andreas Pehrson [:pehrsons] (PTO until July 29)]

Ok, unsure about the component. Marking it General for triage.

Comment 2

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

[Tracking Requested - why for this release]: Privacy regression blocking new 60 camera-off-on-disabled feature (bug 1299515).

Comment 3

[Andreas Pehrson [:pehrsons] (PTO until July 29)]

One issue found, I hope and think that is all:

Regressed by [1], because on Android the message part is still used per [2]. Not that it's used for anything useful however, so it should be a quick fix.

[1] https://hg.mozilla.org/mozilla-central/rev/871480d5c37d3ff8e2d011ca4700f550148d490d
[2] https://searchfox.org/mozilla-central/rev/8fa0b32c84f924c6809c690117dbd59591f79607/mobile/android/modules/WebrtcUI.jsm#69

Comment 4

[Andreas Pehrson [:pehrsons] (PTO until July 29)]

Attachment: Bug 1443157 - Disregard aData for event recording-device-events.

Review commit: https://reviewboard.mozilla.org/r/227770/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/227770/

Comment 5

[Andreas Pehrson [:pehrsons] (PTO until July 29)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=02b8bc92e6443b27455aad8ffa32260ea4d06e55

This build works for me.

Comment 6

[Johann Hofmann [:johannh]]

Comment on attachment 8958899 [details]
Bug 1443157 - Disregard aData for event recording-device-events.

https://reviewboard.mozilla.org/r/227770/#review233814

Looks reasonable to me and works when testing on my phone :)

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2b393dc7ff57
Disregard aData for event recording-device-events. r=johannh

Comment 8

[Raul Gurzau (:RaulGurzau)]

https://hg.mozilla.org/mozilla-central/rev/2b393dc7ff57

Comment 9

[Andreas Pehrson [:pehrsons] (PTO until July 29)]

Would be great to have full verification that this is now fixed in Nightly.

Comment 10

[Andreas Pehrson [:pehrsons] (PTO until July 29)]

Comment on attachment 8958899 [details]
Bug 1443157 - Disregard aData for event recording-device-events.

Approval Request Comment
[Feature/Bug causing the regression]: bug 1299515
[User impact if declined]: No notification on OS level or in browser chrome that a camera or microphone capture is occurring on any website on Fennec.
[Is this code covered by automated tests?]: No
[Has the fix been verified in Nightly?]: Not yet
[Needs manual test from QE? If yes, steps to reproduce]: Yes, see comment 0
[List of other uplifts needed for the feature/fix]: None
[Is the change risky?]: No
[Why is the change risky/not risky?]: Dead simple, removing a check on a variable we no longer set.
[String changes made/needed]: None

Comment 11

[Sorina Florean [:sflorean]]

I was able to reproduce the issue on build 60.0a1 from 30-01 with Nexus 6P(Android 8.1.0) and Honor 8(Android 7.0).
Verified as fixed: build 61.0a1 from 30-19.
Devices: Nexus 6P(Android 8.1.0) and Honor 8(Android 7.0).

Comment 12

[Julien Cristau [:jcristau] (back on August 5)]

Comment on attachment 8958899 [details]
Bug 1443157 - Disregard aData for event recording-device-events.

android crash fix, beta60+

Comment 13

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/releases/mozilla-beta/rev/ae0358583ecc

Comment 14

[Sorina Florean [:sflorean]]

Verified as fixed: 60.0b5 build 1.
Devices: Samsung Galaxy Tab S3 (Android 7.0), Nexus 5 (Android 6.0.1), Xiaomi Mi Pad 2 (Android 5.1 x86).
Screenshot: https://i.imgur.com/pxNWBoF.png.

Comment 15

[Brindusa Tot[:brindusat]]

Based on previous comments, the bug was verified as fixed on Nightly 61 and Beta 60. Remove the qe-verify+ flag.