Closed
Bug 1443164
Opened 7 years ago
Closed 7 years ago
Update brotli to 1.0.4
Categories
(Core :: Graphics: Text, defect, P3)
Core
Graphics: Text
Tracking
()
RESOLVED
FIXED
mozilla62
People
(Reporter: tjr, Assigned: RyanVM)
References
Details
(Whiteboard: [third-party-lib-audit][gfx-noted])
Attachments
(2 files)
569.77 KB,
patch
|
jfkthame
:
review+
|
Details | Diff | Splinter Review |
959 bytes,
patch
|
mayhemer
:
review+
|
Details | Diff | Splinter Review |
This is a (semi-)automated bug making you aware that there is an available upgrade for an embedded third-party library. You can leave this bug open, and it will be updated if a newer version of the library becomes available. If you close it as WONTFIX, please indicate if you do not wish to receive any future bugs upon new releases of the library.
brotli is currently at version 1.0.2 in mozilla-central, and the latest version of the library released is 1.0.3.
I fetched the latest version of the library from https://github.com/google/brotli/.
Updated•7 years ago
|
Priority: -- → P3
Updated•7 years ago
|
Whiteboard: [third-party-lib-audit] → [third-party-lib-audit][gfx-noted]
Reporter | ||
Comment 1•7 years ago
|
||
1.0.4 is released, no significant commits though.
Summary: Update brotli to 1.0.3 → Update brotli to 1.0.4
Assignee | ||
Comment 2•7 years ago
|
||
This includes the minimal number of changes to moz.build required to get it to build. There's also a fix for upstream issue #678 rolled in to fix MSVC Werror bustage.
https://treeherder.mozilla.org/#/jobs?repo=try&revision=e804bd8e2cfd761d5a85efbdac6ae333e93457ed
Assignee | ||
Comment 3•7 years ago
|
||
This will be folded into the main patch for landing.
BrotliDecoderStateInit changed signature a bit (see the other attached patch if you're curious), so update the caller to reflect that change. This just calls the function the same way it had been previously getting called with older brotli versions.
Attachment #8982387 -
Flags: review?(honzab.moz)
Assignee | ||
Updated•7 years ago
|
status-firefox61:
--- → wontfix
status-firefox62:
--- → fix-optional
Updated•7 years ago
|
Attachment #8982386 -
Flags: review?(jfkthame) → review+
![]() |
||
Updated•7 years ago
|
Attachment #8982387 -
Flags: review?(honzab.moz) → review+
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/bdfb2963834f
Update brotli to version 1.0.4 and update Gecko callers. r=jfkthame, r=mayhemer
Comment 5•7 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla62
You need to log in
before you can comment on or make changes to this bug.
Description
•