Closed
Bug 1443206
Opened 6 years ago
Closed 6 years ago
[wpt-sync] Sync PR 9821 - Snap Point selection should satisfy visibility requirement.
Categories
(Core :: CSS Parsing and Computation, enhancement, P3)
Core
CSS Parsing and Computation
Tracking
()
RESOLVED
FIXED
mozilla61
Tracking | Status | |
---|---|---|
firefox61 | --- | fixed |
People
(Reporter: mozilla.org, Unassigned)
Details
(Whiteboard: [wptsync downstream])
Sync web-platform-tests PR 9821 into mozilla-central (this bug is closed when the sync is complete). PR: https://github.com/w3c/web-platform-tests/pull/9821 Details from upstream follow. Sandra Sun wrote: > Snap Point selection should satisfy visibility requirement. > > According to spec, https://www.w3.org/TR/css-scroll-snap-1/#snap-scope > we should only consider the snap points of visible snap areas. > This patch implements the visibility requirement by adding a field of > visible region for each snap point. It also handles the case of > visibility conflict when snapping to two axes individually. > > This patches also changes the snap_area_list_ in SnapContainerData to > snap_point_list_x_ and snap_point_list_y for more flexibility when > searching on an individual axis. > > Bug: 778257 > Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel > Change-Id: I7a3d2aa6b9c1293df3f05118152f105fa3265d29 > Reviewed-on: https://chromium-review.googlesource.com/814874 > WPT-Export-Revision: 37fe95ebdede29338be852e52c0292a0c20c7f01
Reporter | ||
Updated•6 years ago
|
Component: web-platform-tests → CSS Parsing and Computation
Product: Testing → Core
Reporter | ||
Comment 1•6 years ago
|
||
Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=a12f7b8e333b0f16321cacaffcb3be5623812f92
Reporter | ||
Comment 2•6 years ago
|
||
Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=9913f66cc2b63ea2fc5ea05a80fefa6e244b28f3
Pushed by james@hoppipolla.co.uk: https://hg.mozilla.org/integration/mozilla-inbound/rev/7d79c07c9e39 [wpt PR 9821] - Snap Point selection should satisfy visibility requirement., a=testonly
Comment 4•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/7d79c07c9e39
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox61:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
Comment 5•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/7d79c07c9e39
You need to log in
before you can comment on or make changes to this bug.
Description
•