Closed
Bug 1443216
Opened 7 years ago
Closed 7 years ago
Remove overzelous status check in TPS login.
Categories
(Firefox :: Sync, enhancement)
Firefox
Sync
Tracking
()
RESOLVED
FIXED
Firefox 60
| Tracking | Status | |
|---|---|---|
| firefox60 | --- | fixed |
People
(Reporter: tcsc, Assigned: tcsc)
Details
Attachments
(1 file)
Many TPS tests are currently failing, and it's due to an assertation that Status.login is LOGIN_SUCCEEDED and not some other success status. If we failed to login we'll certainly fail later on anyway, so this is pointless.
I'll push a patch up once a full run completes and I confirm this is the only issue.
| Comment hidden (mozreview-request) |
|
Assignee | |
Comment 2•7 years ago
|
||
This doesn't fix all the TPS failures, but it does get about half of them, including the one for prod.
|
||
Comment 3•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8956150 [details]
Bug 1443216 - Fix overzealous login check in TPS.
https://reviewboard.mozilla.org/r/225074/#review231032
Attachment #8956150 -
Flags: review?(kit) → review+
Pushed by tchiovoloni@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/7a81b01a6b0b
Fix overzealous login check in TPS. r=kitcambridge
|
||
Comment 5•7 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox60:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 60
You need to log in
before you can comment on or make changes to this bug.
Description
•