Closed Bug 1443216 Opened 2 years ago Closed 2 years ago

Remove overzelous status check in TPS login.

Categories

(Firefox :: Sync, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
Firefox 60
Tracking Status
firefox60 --- fixed

People

(Reporter: tcsc, Assigned: tcsc)

Details

Attachments

(1 file)

Many TPS tests are currently failing, and it's due to an assertation that Status.login is LOGIN_SUCCEEDED and not some other success status. If we failed to login we'll certainly fail later on anyway, so this is pointless.

I'll push a patch up once a full run completes and I confirm this is the only issue.
This doesn't fix all the TPS failures, but it does get about half of them, including the one for prod.
Comment on attachment 8956150 [details]
Bug 1443216 - Fix overzealous login check in TPS.

https://reviewboard.mozilla.org/r/225074/#review231032
Attachment #8956150 - Flags: review?(kit) → review+
Pushed by tchiovoloni@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/7a81b01a6b0b
Fix overzealous login check in TPS. r=kitcambridge
https://hg.mozilla.org/mozilla-central/rev/7a81b01a6b0b
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 60
You need to log in before you can comment on or make changes to this bug.