1443228 - Convolver should throw NotSupportedError for invalid channel count

Status: RESOLVED FIXED

(Core :: Web Audio, defect, P3)

Description

[toy.raymond]

User Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/65.0.3325.106 Safari/537.36

Steps to reproduce:

Run this:

c = new AudioContext();
b = new AudioBuffer({length: 1, numberOfChannels: 3, sampleRate: c.sampleRate});
n = new ConvolverNode(c)
n.buffer = b


Actual results:

A SyntaxError is thrown when setting the buffer to b.


Expected results:

A NotSupportedError must be thrown: https://webaudio.github.io/web-audio-api/#dom-convolvernode-buffer

Comment 1

[ovidiu boca[:Ovidiu]]

Hi toy.raymond,

Did you run this script in Browser Console?

Comment 2

[Alex Chronopoulos [:achronop]]

Copy from the spec:
"The AudioBuffer MUST have 1, 2, or 4 channels or a NotSupportedError exception MUST be thrown."

Comment 3

[Paul Adenot (:padenot)]

Attachment: Bug 1443228 - Make the ConvolverNode ctor throw NotSupportedError when passed a buffer with an invalid channel count.

Spec: https://webaudio.github.io/web-audio-api/#dom-convolvernode-buffer
This is well tested in web-platform-test, the test has been added a day ago and
will be merged soon: https://github.com/w3c/web-platform-tests/blob/16376ce7a6ca10ca6ac31dff565c47b6555e3103/webaudio/the-audio-api/the-convolvernode-interface/convolver-channels.html

Review commit: https://reviewboard.mozilla.org/r/226054/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/226054/

Comment 4

[ovidiu boca[:Ovidiu]]

This is reproducible also on Mac OS X 10.12 with FF 58 and FF Nightly 60.0a1(2018-03-07).

Comment 5

[Karl Tomlinson (:karlt)]

Comment on attachment 8957114 [details]
Bug 1443228 - Make the ConvolverNode ctor throw NotSupportedError when passed a buffer with an invalid channel count.

https://reviewboard.mozilla.org/r/226054/#review232168

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0a5ec71513a7
Make the ConvolverNode ctor throw NotSupportedError when passed a buffer with an invalid channel count. r=karlt

Comment 7

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/0a5ec71513a7

Comment 8

[Chris Mills [:cmills]]

I've added details about the NotSupportedError to the constructor ref page:

https://developer.mozilla.org/en-US/docs/Web/API/ConvolverNode/ConvolverNode#Exceptions

I've also added a note to the Fx60 rel notes:

https://developer.mozilla.org/en-US/Firefox/Releases/60#Media_and_WebRTC

Let me know if this looks OK. Thanks!

Comment 9

[Paul Adenot (:padenot)]

Perfect as usual, Chris, thanks!