1443282 - Intermittent editor/libeditor/tests/browser_bug629172.js | application crashed [@ MOZ_CrashOOL]

Status: RESOLVED DUPLICATE of bug 1448054

(Core :: SQLite and Embedded Database Bindings, defect, P5)

Description

[Treeherder Bug Filer]

Filed by: csabou [at] mozilla.com

https://treeherder.mozilla.org/logviewer.html#?job_id=166012402&repo=mozilla-inbound

https://queue.taskcluster.net/v1/task/C1eFG_APSZ-0ld4-fittQA/runs/0/artifacts/public/logs/live_backing.log

Comment 1

[Makoto Kato [:m_kato]]

mozilla::storage::Connection releases nsStandardURL on another thread...


[task 2018-03-05T16:39:59.971Z] 16:39:59     INFO - GECKO(2672) | Hit MOZ_CRASH(nsStandardURL not thread-safe) at /builds/worker/workspace/build/src/xpcom/base/nsISupportsImpl.cpp:46
...
[task 2018-03-05T16:40:09.138Z] 16:40:09     INFO - Thread 0 (crashed)
[task 2018-03-05T16:40:09.139Z] 16:40:09     INFO -  0  firefox!MOZ_CrashOOL [Assertions.cpp:f04735dda824fddf7399bdcdd47df9b2cb53fa23 : 33 + 0x0]
[task 2018-03-05T16:40:09.139Z] 16:40:09     INFO -     rax = 0x0000000000641de0   rdx = 0x0000000000000000
[task 2018-03-05T16:40:09.140Z] 16:40:09     INFO -     rcx = 0x00007fac131612dd   rbx = 0x00007fac0634122d
[task 2018-03-05T16:40:09.141Z] 16:40:09     INFO -     rsi = 0x00007fac13430770   rdi = 0x00007fac1342f540
[task 2018-03-05T16:40:09.141Z] 16:40:09     INFO -     rbp = 0x00007ffcecb36850   rsp = 0x00007ffcecb36840
[task 2018-03-05T16:40:09.142Z] 16:40:09     INFO -      r8 = 0x00007fac13430770    r9 = 0x00007fac144fa740
[task 2018-03-05T16:40:09.142Z] 16:40:09     INFO -     r10 = 0x0000000000000058   r11 = 0x00007fac130d77a0
[task 2018-03-05T16:40:09.145Z] 16:40:09     INFO -     r12 = 0x00007fabe85e9460   r13 = 0x0000000000000000
[task 2018-03-05T16:40:09.146Z] 16:40:09     INFO -     r14 = 0x00007fabe85e9460   r15 = 0x0000000000000008
[task 2018-03-05T16:40:09.146Z] 16:40:09     INFO -     rip = 0x00000000004061c9
[task 2018-03-05T16:40:09.146Z] 16:40:09     INFO -     Found by: given as instruction pointer in context
[task 2018-03-05T16:40:09.147Z] 16:40:09     INFO -  1  libxul.so!nsAutoOwningThread::AssertCurrentThreadOwnsMe [nsISupportsImpl.cpp:f04735dda824fddf7399bdcdd47df9b2cb53fa23 : 46 + 0x14]
[task 2018-03-05T16:40:09.148Z] 16:40:09     INFO -     rbx = 0x00007fac0634122d   rbp = 0x00007ffcecb36870
[task 2018-03-05T16:40:09.148Z] 16:40:09     INFO -     rsp = 0x00007ffcecb36860   r12 = 0x00007fabe85e9460
[task 2018-03-05T16:40:09.148Z] 16:40:09     INFO -     r13 = 0x0000000000000000   r14 = 0x00007fabe85e9460
[task 2018-03-05T16:40:09.149Z] 16:40:09     INFO -     r15 = 0x0000000000000008   rip = 0x00007fac02222ef1
[task 2018-03-05T16:40:09.150Z] 16:40:09     INFO -     Found by: call frame info
[task 2018-03-05T16:40:09.151Z] 16:40:09     INFO -  2  libxul.so!mozilla::net::nsStandardURL::Release [nsISupportsImpl.h:f04735dda824fddf7399bdcdd47df9b2cb53fa23 : 69 + 0x5]
[task 2018-03-05T16:40:09.151Z] 16:40:09     INFO -     rbx = 0x00007fabeb58f700   rbp = 0x00007ffcecb36890
[task 2018-03-05T16:40:09.151Z] 16:40:09     INFO -     rsp = 0x00007ffcecb36880   r12 = 0x00007fabe85e9460
[task 2018-03-05T16:40:09.152Z] 16:40:09     INFO -     r13 = 0x0000000000000000   r14 = 0x00007fabe85e9460
[task 2018-03-05T16:40:09.152Z] 16:40:09     INFO -     r15 = 0x0000000000000008   rip = 0x00007fac0232ff89
[task 2018-03-05T16:40:09.153Z] 16:40:09     INFO -     Found by: call frame info
[task 2018-03-05T16:40:09.153Z] 16:40:09     INFO -  3  libxul.so!mozilla::storage::Connection::~Connection [mozStorageConnection.cpp:f04735dda824fddf7399bdcdd47df9b2cb53fa23 : 550 + 0x18]
[task 2018-03-05T16:40:09.153Z] 16:40:09     INFO -     rbx = 0x00007fabe85e9460   rbp = 0x00007ffcecb368b0
[task 2018-03-05T16:40:09.153Z] 16:40:09     INFO -     rsp = 0x00007ffcecb368a0   r12 = 0x00007fabe85e9460
[task 2018-03-05T16:40:09.154Z] 16:40:09     INFO -     r13 = 0x0000000000000000   r14 = 0x00007fabe85e9460
[task 2018-03-05T16:40:09.154Z] 16:40:09     INFO -     r15 = 0x0000000000000008   rip = 0x00007fac029ff4b8

Comment 2

[Andrew Sutherland [:asuth] (he/him)]

If we can get a deeper stack from a crash like this, that would be handy.  This might be one of these cases of minimizeMemory effectively migrating the destruction of an IndexedDB or Cache API connection from its respective IO thread to the main thread.  Both these types of connections don't happen on the main thread and use URLs in order to propagate the QuotaManager information through to the telemetry VFS's quota enforcement logic.

We might be best served by trying to switch consumers to the thread-safe MozURL.

Comment 3

[Intermittent Failures Robot]

6 failures in 747 pushes (0.008 failures/push) were associated with this bug in the last 7 days.    

Repository breakdown:
* autoland: 3
* try: 2
* mozilla-inbound: 1

Platform breakdown:
* linux64-stylo-disabled: 6

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1443282&startday=2018-03-05&endday=2018-03-11&tree=all

Comment 4

[Intermittent Failures Robot]

3 failures in 814 pushes (0.004 failures/push) were associated with this bug in the last 7 days.    

Repository breakdown:
* try: 1
* mozilla-inbound: 1
* autoland: 1

Platform breakdown:
* linux64: 2
* linux64-stylo-disabled: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1443282&startday=2018-03-12&endday=2018-03-18&tree=all

Comment 6

[Intermittent Failures Robot]

2 failures in 822 pushes (0.002 failures/push) were associated with this bug in the last 7 days.    

Repository breakdown:
* mozilla-central: 2

Platform breakdown:
* linux64: 2

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1443282&startday=2018-03-20&endday=2018-03-26&tree=trunk

Comment 7

[Intermittent Failures Robot]

1 failures in 669 pushes (0.001 failures/push) were associated with this bug in the last 7 days.    

Repository breakdown:
* mozilla-release: 1

Platform breakdown:
* linux64-stylo-disabled: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1443282&startday=2018-06-04&endday=2018-06-10&tree=trunk