1443337 - Add Home section to about:preferences for Activity Stream preferences

Status: RESOLVED FIXED

(Firefox :: New Tab Page, enhancement, P1)

Description

[Kate Hudson :k88hudson]

Attachment: Invision comps

We need a Home section in about:preferences in which to move our Activity Stream preferences (the work for the actual preferences to be added is already done here https://bugzilla.mozilla.org/show_bug.cgi?id=1404890).

Comment 1

[Kate Hudson :k88hudson]

For context:

Rcent designs are here: https://mozilla.invisionapp.com/share/65FPNL9RH4V#/screens/280785532_Explainer and finalized strings are in this document: https://docs.google.com/document/d/1uI7xtTuI9pw9rbOzN7q1kjUeIOEH3wfJtFr-4-degzQ/edit, which were worked on by Bryan Bell, Aaron Benson and Michelle Heubusch.

Most of the engineering work was done by :Mardak (who is currently away for a couple of weeks) in these bugs:
- https://bugzilla.mozilla.org/show_bug.cgi?id=1417155
- https://bugzilla.mozilla.org/show_bug.cgi?id=1404890

Comment 2

[Ed Lee :Mardak]

I poked around at this earlier, but no actual patch:

- register_module("paneHome", gHomePage)
https://searchfox.org/mozilla-central/rev/bffd3e0225b65943364be721881470590b9377c1/browser/components/preferences/in-content/preferences.js#54-57

- move home page xul.. and maybe the new tab webextension ??
https://searchfox.org/mozilla-central/rev/bffd3e0225b65943364be721881470590b9377c1/browser/components/preferences/in-content/main.xul#82-135

- update data-category="paneHome"
note that https://github.com/mozilla/activity-stream/pull/4015 was written to clone #homepageGroup so it'll appear in the same panel no matter when this bug lands

- the existing home icon seems to work fine
chrome://browser/skin/home.svg

- add ftl entry for "Home"
https://searchfox.org/mozilla-central/rev/bffd3e0225b65943364be721881470590b9377c1/browser/locales/en-US/browser/preferences/preferences.ftl#28-43

Comment 3

[Kate Hudson :k88hudson]

Fixed by https://hg.mozilla.org/mozilla-central/rev/7852878194fc