Add Home section to about:preferences for Activity Stream preferences

RESOLVED FIXED in Firefox 61

Status

()

enhancement
P1
normal
RESOLVED FIXED
Last year
Last year

People

(Reporter: k88hudson, Assigned: k88hudson)

Tracking

(Blocks 1 bug)

unspecified
Firefox 61
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox61 fixed)

Details

Attachments

(1 obsolete attachment)

Assignee

Description

Last year
Posted file Invision comps (obsolete) —
We need a Home section in about:preferences in which to move our Activity Stream preferences (the work for the actual preferences to be added is already done here https://bugzilla.mozilla.org/show_bug.cgi?id=1404890).
Assignee

Updated

Last year
Assignee: nobody → khudson
Severity: normal → enhancement
Iteration: --- → 60.4 - Mar 12
Priority: -- → P1
Assignee

Updated

Last year
Attachment #8956256 - Attachment is obsolete: true
Assignee

Updated

Last year
Blocks: 1404890
Assignee

Updated

Last year
Blocks: 1417155
Assignee

Comment 1

Last year
For context:

Rcent designs are here: https://mozilla.invisionapp.com/share/65FPNL9RH4V#/screens/280785532_Explainer and finalized strings are in this document: https://docs.google.com/document/d/1uI7xtTuI9pw9rbOzN7q1kjUeIOEH3wfJtFr-4-degzQ/edit, which were worked on by Bryan Bell, Aaron Benson and Michelle Heubusch.

Most of the engineering work was done by :Mardak (who is currently away for a couple of weeks) in these bugs:
- https://bugzilla.mozilla.org/show_bug.cgi?id=1417155
- https://bugzilla.mozilla.org/show_bug.cgi?id=1404890

Comment 2

Last year
I poked around at this earlier, but no actual patch:

- register_module("paneHome", gHomePage)
https://searchfox.org/mozilla-central/rev/bffd3e0225b65943364be721881470590b9377c1/browser/components/preferences/in-content/preferences.js#54-57

- move home page xul.. and maybe the new tab webextension ??
https://searchfox.org/mozilla-central/rev/bffd3e0225b65943364be721881470590b9377c1/browser/components/preferences/in-content/main.xul#82-135

- update data-category="paneHome"
note that https://github.com/mozilla/activity-stream/pull/4015 was written to clone #homepageGroup so it'll appear in the same panel no matter when this bug lands

- the existing home icon seems to work fine
chrome://browser/skin/home.svg

- add ftl entry for "Home"
https://searchfox.org/mozilla-central/rev/bffd3e0225b65943364be721881470590b9377c1/browser/locales/en-US/browser/preferences/preferences.ftl#28-43
Iteration: 60.4 - Mar 12 → 61.1 - Mar 26
Priority: P1 → P3

Updated

Last year
Blocks: 1432589
Assignee

Updated

Last year
Priority: P3 → P1

Updated

Last year
No longer blocks: 1404890
See Also: → 1404890

Updated

Last year
Blocks: 1434751
Assignee

Updated

Last year
No longer blocks: 1417155
Depends on: 1417155
Assignee

Comment 3

Last year
Fixed by https://hg.mozilla.org/mozilla-central/rev/7852878194fc
Status: NEW → RESOLVED
Closed: Last year
Resolution: --- → FIXED

Updated

Last year
Target Milestone: --- → Firefox 61

Updated

Last year
See Also: → 1467771
You need to log in before you can comment on or make changes to this bug.