1443371 - Clean up unused message listeners, code paths after bug 1418403

Status: RESOLVED FIXED

(Toolkit :: View Source, enhancement, P2)

Description

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Bug 1418403 left behind some message listeners and code paths that are no longer reachable.  We should clean these up.

Comment 1

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Bug 1443355 describes at least some of the dead code here.

Comment 2

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Attachment: Bug 1443371 - Remove unused View Source message listeners.

After bug 1418403, there are some left over message listeners in View Source
that are unused.

Review commit: https://reviewboard.mozilla.org/r/225340/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/225340/

Comment 3

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Attachment: Bug 1443371 - Remove unused page descriptor in viewSourceUtils.js.

`openInExternalEditor` used to accept a page descriptor as a deprecated arg, but
this is no longer possible after bug 1418403.

Review commit: https://reviewboard.mozilla.org/r/225342/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/225342/

Comment 4

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=f6bd34dba8f19b8a3c2616e9cbb129b98664a55d

Comment 5

[Brendan Dahl [:bdahl]]

Comment on attachment 8956441 [details]
Bug 1443371 - Remove unused View Source message listeners.

https://reviewboard.mozilla.org/r/225340/#review231354

Comment 6

[Brendan Dahl [:bdahl]]

Comment on attachment 8956442 [details]
Bug 1443371 - Remove unused page descriptor in viewSourceUtils.js.

https://reviewboard.mozilla.org/r/225342/#review231360

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b98a010be06f
Remove unused View Source message listeners. r=bdahl
https://hg.mozilla.org/integration/autoland/rev/3cee5c02db0a
Remove unused page descriptor in viewSourceUtils.js. r=bdahl

Comment 8

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/b98a010be06f
https://hg.mozilla.org/mozilla-central/rev/3cee5c02db0a