Stop reporting legacy Telemetry component `childPayloads`

RESOLVED FIXED in Firefox 61

Status

()

P3
normal
RESOLVED FIXED
a year ago
11 months ago

People

(Reporter: chutten, Assigned: janerik)

Tracking

(Blocks: 1 bug)

Trunk
mozilla61
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox61 fixed)

Details

Attachments

(1 attachment)

(Reporter)

Description

a year ago
This bug is for stopping childPayloads from being reported by TelemetrySession (basically just removing https://searchfox.org/mozilla-central/rev/bffd3e0225b65943364be721881470590b9377c1/toolkit/components/telemetry/TelemetrySession.jsm#1332 ) and updating the documentation and tests as necessary.

We aim to complete this work in Firefox 61.
status-firefox60: --- → affected
(Reporter)

Updated

a year ago
Blocks: 1443600
tracking-seamonkey2.15: --- → ---
(Assignee)

Comment 1

11 months ago
Created attachment 8960121 [details] [diff] [review]
Stop reporting legacy Telemetry component `childPayloads`
Attachment #8960121 - Flags: review?(chutten)
(Assignee)

Updated

11 months ago
Assignee: nobody → jrediger
Status: NEW → ASSIGNED
(Reporter)

Comment 2

11 months ago
Comment on attachment 8960121 [details] [diff] [review]
Stop reporting legacy Telemetry component `childPayloads`

Review of attachment 8960121 [details] [diff] [review]:
-----------------------------------------------------------------

It didn't occur to me when I was splitting the "stop" from the "remove" probes that leaving all that code in place during "stop" would be painful to r+ :S

Ah well, so much the sweeter when time comes to remove it.

And I'd like to note that you didn't have to change any tests here. That's one of the many reasons for removing these.

I do find it interesting that no changes had to be made to aboutTelemetry. The code's just generic enough to handle it.
Attachment #8960121 - Flags: review?(chutten) → review+
(Assignee)

Updated

11 months ago
Keywords: checkin-needed

Comment 3

11 months ago
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/4d006cb03572
Stop reporting legacy Telemetry component `childPayloads`. r=chutten
Keywords: checkin-needed

Comment 4

11 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/4d006cb03572
Status: ASSIGNED → RESOLVED
Last Resolved: 11 months ago
status-firefox61: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
You need to log in before you can comment on or make changes to this bug.