1443609 - Remove legacy Telemetry component `UITelemetry`

Status: RESOLVED FIXED

(Toolkit :: Telemetry, enhancement, P1)

Description

[Chris H-C :chutten]

After we stop sending UITelemetry in bug 1443605 we should remove its code, and anything that might have displayed it in about:telemetry.

Comment 1

[Jan-Erik Rediger [:janerik]]

Attachment: Remove legacy components from `UITelemetry`

Reporting was already disabled in Bug 1443605.

This keeps the `enabled` getter as a way to detect if it is enabled, in use in BrowserUITelemetry only.
This keeps `addEvent` and related methods, as they are still in use on Android.


No changes to about:telemetry required. `UITelemetry` was displayed as part of `Simple Measurements`.

Comment 2

[Chris H-C :chutten]

Comment on attachment 8964605 [details] [diff] [review]
Remove legacy components from `UITelemetry`

Review of attachment 8964605 [details] [diff] [review]:
-----------------------------------------------------------------

browser/docs/UITelemetry.rst and its references need deprecation notices, but otherwise this looks complete.

Comment 3

[Jan-Erik Rediger [:janerik]]

Attachment: Remove legacy components from `UITelemetry`

Reporting was already disabled in Bug 1443605.

This keeps the `enabled` getter as a way to detect if it is enabled, in use in BrowserUITelemetry only.
This keeps `addEvent` and related methods, as they are still in use on Android.

Comment 4

[Jan-Erik Rediger [:janerik]]

added a deprecation notice to UITelemetry.rst. What do you mean by "its references"?

Comment 5

[Chris H-C :chutten]

(In reply to Jan-Erik Rediger [:janerik] from comment #4)
> added a deprecation notice to UITelemetry.rst. What do you mean by "its
> references"?

Aren't there places where it's added to tables of contents, or linked to by other docs?

(( If not, maybe we should just remove it, since I think the doc builder will just orphan it? ))

Comment 6

[Chris H-C :chutten]

Comment on attachment 8964794 [details] [diff] [review]
Remove legacy components from `UITelemetry`

Review of attachment 8964794 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/docs/UITelemetry.rst
@@ +5,5 @@
>  =======================
>  
> +.. note::
> +
> +    ``UITelemetry`` is deprecated. As of Firefox 61, ``UITelemetry`` is no longer reported in a ping.

Drop "in a ping". We don't need to be that specific :)

Comment 7

[Jan-Erik Rediger [:janerik]]

I understand now. It's part of the Firefox section[1] and has one reference in the main-ping docu[2].

[1]: https://firefox-source-docs.mozilla.org/browser/browser/index.html
[2]: https://firefox-source-docs.mozilla.org/toolkit/components/telemetry/telemetry/data/main-ping.html#id2

So the question is: Should we keep [1] around with the deprecation warning or should we fully remove it?

([2] already has a note about the removal and has a version history on the bottom)

Comment 8

[Jan-Erik Rediger [:janerik]]

Attachment: Remove legacy components from `UITelemetry`

Reporting was already disabled in Bug 1443605.

This keeps the `enabled` getter as a way to detect if it is enabled, in use in BrowserUITelemetry only.
This keeps `addEvent` and related methods, as they are still in use on Android.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/68ef8c8c50f6
Remove legacy components from `UITelemetry` r=chutten

Comment 10

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/68ef8c8c50f6