Closed
Bug 1443609
Opened 6 years ago
Closed 6 years ago
Remove legacy Telemetry component `UITelemetry`
Categories
(Toolkit :: Telemetry, enhancement, P1)
Toolkit
Telemetry
Tracking
()
RESOLVED
FIXED
mozilla61
Tracking | Status | |
---|---|---|
firefox61 | --- | fixed |
People
(Reporter: chutten, Assigned: janerik)
References
(Blocks 1 open bug)
Details
Attachments
(1 file, 2 obsolete files)
6.03 KB,
patch
|
chutten
:
review+
|
Details | Diff | Splinter Review |
After we stop sending UITelemetry in bug 1443605 we should remove its code, and anything that might have displayed it in about:telemetry.
status-firefox60:
--- → affected
Updated•6 years ago
|
Assignee | ||
Updated•6 years ago
|
Assignee: nobody → jrediger
Assignee | ||
Updated•6 years ago
|
Priority: P4 → P1
Assignee | ||
Comment 1•6 years ago
|
||
Reporting was already disabled in Bug 1443605. This keeps the `enabled` getter as a way to detect if it is enabled, in use in BrowserUITelemetry only. This keeps `addEvent` and related methods, as they are still in use on Android. No changes to about:telemetry required. `UITelemetry` was displayed as part of `Simple Measurements`.
Attachment #8964605 -
Flags: review?(chutten)
Reporter | ||
Comment 2•6 years ago
|
||
Comment on attachment 8964605 [details] [diff] [review] Remove legacy components from `UITelemetry` Review of attachment 8964605 [details] [diff] [review]: ----------------------------------------------------------------- browser/docs/UITelemetry.rst and its references need deprecation notices, but otherwise this looks complete.
Attachment #8964605 -
Flags: review?(chutten)
Assignee | ||
Comment 3•6 years ago
|
||
Reporting was already disabled in Bug 1443605. This keeps the `enabled` getter as a way to detect if it is enabled, in use in BrowserUITelemetry only. This keeps `addEvent` and related methods, as they are still in use on Android.
Attachment #8964794 -
Flags: review?(chutten)
Assignee | ||
Updated•6 years ago
|
Attachment #8964605 -
Attachment is obsolete: true
Assignee | ||
Comment 4•6 years ago
|
||
added a deprecation notice to UITelemetry.rst. What do you mean by "its references"?
Reporter | ||
Comment 5•6 years ago
|
||
(In reply to Jan-Erik Rediger [:janerik] from comment #4) > added a deprecation notice to UITelemetry.rst. What do you mean by "its > references"? Aren't there places where it's added to tables of contents, or linked to by other docs? (( If not, maybe we should just remove it, since I think the doc builder will just orphan it? ))
Reporter | ||
Comment 6•6 years ago
|
||
Comment on attachment 8964794 [details] [diff] [review] Remove legacy components from `UITelemetry` Review of attachment 8964794 [details] [diff] [review]: ----------------------------------------------------------------- ::: browser/docs/UITelemetry.rst @@ +5,5 @@ > ======================= > > +.. note:: > + > + ``UITelemetry`` is deprecated. As of Firefox 61, ``UITelemetry`` is no longer reported in a ping. Drop "in a ping". We don't need to be that specific :)
Attachment #8964794 -
Flags: review?(chutten)
Assignee | ||
Comment 7•6 years ago
|
||
I understand now. It's part of the Firefox section[1] and has one reference in the main-ping docu[2]. [1]: https://firefox-source-docs.mozilla.org/browser/browser/index.html [2]: https://firefox-source-docs.mozilla.org/toolkit/components/telemetry/telemetry/data/main-ping.html#id2 So the question is: Should we keep [1] around with the deprecation warning or should we fully remove it? ([2] already has a note about the removal and has a version history on the bottom)
Flags: needinfo?(chutten)
Reporter | ||
Updated•6 years ago
|
Flags: needinfo?(chutten)
Assignee | ||
Comment 8•6 years ago
|
||
Reporting was already disabled in Bug 1443605. This keeps the `enabled` getter as a way to detect if it is enabled, in use in BrowserUITelemetry only. This keeps `addEvent` and related methods, as they are still in use on Android.
Attachment #8964933 -
Flags: review?(chutten)
Assignee | ||
Updated•6 years ago
|
Attachment #8964794 -
Attachment is obsolete: true
Reporter | ||
Updated•6 years ago
|
Attachment #8964933 -
Flags: review?(chutten) → review+
Assignee | ||
Updated•6 years ago
|
Keywords: checkin-needed
Pushed by nerli@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/68ef8c8c50f6 Remove legacy components from `UITelemetry` r=chutten
Keywords: checkin-needed
Comment 10•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/68ef8c8c50f6
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox61:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
You need to log in
before you can comment on or make changes to this bug.
Description
•