Closed Bug 1443619 Opened 3 years ago Closed 3 years ago

Ignore items already flagged for explicit weak upload with older creation dates

Categories

(Firefox :: Sync, enhancement, P1)

enhancement

Tracking

()

RESOLVED FIXED
Firefox 60
Tracking Status
firefox60 --- fixed

People

(Reporter: lina, Assigned: lina)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

https://searchfox.org/mozilla-central/rev/bffd3e0225b65943364be721881470590b9377c1/toolkit/components/places/SyncedBookmarksMirror.jsm#1497 should use an `INSERT OR IGNORE`, otherwise, we'll throw a constraint violation if a bookmark with an older creation date is flagged for explicit weak reupload.

Easy fix incoming. :-)
Comment on attachment 8956590 [details]
Bug 1443619 - Ignore items with older creation dates that are already flagged for explicit weak upload.

https://reviewboard.mozilla.org/r/225502/#review231402

Ha yes this makes sense, thank you!
Attachment #8956590 - Flags: review?(eoger) → review+
Pushed by kcambridge@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/363ed8b83c21
Ignore items with older creation dates that are already flagged for explicit weak upload. r=eoger
https://hg.mozilla.org/mozilla-central/rev/363ed8b83c21
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 60
You need to log in before you can comment on or make changes to this bug.