144368 - Linux/SPARC w/GCC3 xptcall broken

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[David S. Miller]

The assembler bits needed to support GCC3 on Linux/Sparc has
not been implemented.

I fixed this and will attach my patch.

Comment 1

[David S. Miller]

Attachment: Linux/SPARC GCC3 support for xptcall

This patch makes Linux/SPARC work when using GCC3.

Comment 2

[timeless]

the license looks wrong. please use 
http://www.mozilla.org/MPL/boilerplate-1.1/mpl-tri-license-c
instead of stealing the header from some random netscape licensed file

Comment 3

[David S. Miller]

I just copied the license from the Linux/Sparc sources from which this
new source file was derived.  Since I only changed a few lines of source,
it is thus a derivative work of the Netscape licensed file.  How can I lagally
change the license in a case like this?

Comment 4

[David S. Miller]

Attachment: Add GCC3 xptcall support for Linux/SPARC, updated license

In the event that the new license is what is supposed to be
used, this updated patch uses it.

Comment 5

[timeless]

sorry, if that's the case you can't. but perhaps you should indicate that.

Comment 6

[Doug Turner (:dougt)]

dan, shaver, care to answer this license question?

Comment 7

[Mike Shaver (:shaver emeritus)]

davem should use whichever license he prefers.  If he has no preference, we'll
take the trilicense just to make our lives easier later.

(In the general case, his first license approach was correct, until timeless
"helped" him, but we have special knowledge and permission for the relicensing
of Netscape-owned files, so the trilicense is an option here.)

Comment 8

[David S. Miller]

davem has no preference, the mozilla folks can use whatever license
they want to use

Comment 9

[Doug Turner (:dougt)]

who can review this?  Shaver, are you up for it?

Comment 10

[Doug Turner (:dougt)]

over to shaver.

Comment 11

[Mike Shaver (:shaver emeritus)]

Comment on attachment 83654 [details] [diff] [review]
Add GCC3 xptcall support for Linux/SPARC, updated license

I am mortified that we didn't get this for 1.0.1 and 1.1.  Dougt or timeless,
please check this into the trunk immediately, and let's get it on the 1.0.2
branch as well.  (I don't have a current tree.)

Dave: my abject apologies.

Comment 12

[Doug Turner (:dougt)]

Checked into trunk:

/cvsroot/mozilla/xpcom/reflect/xptcall/src/md/unix/Makefile.in,v  <--  Makefile.in
new revision: 1.68; previous revision: 1.67
done
RCS file:
/cvsroot/mozilla/xpcom/reflect/xptcall/src/md/unix/xptcinvoke_asm_sparc_linux_GCC3.s,v
done
Checking in xptcinvoke_asm_sparc_linux_GCC3.s;
/cvsroot/mozilla/xpcom/reflect/xptcall/src/md/unix/xptcinvoke_asm_sparc_linux_GCC3.s,v
 <--  xptcinvoke_asm_sparc_linux_GCC3.s
initial revision: 1.1
done

Comment 13

[Randell Jesup [:jesup] (needinfo me)]

SHouldn't this be closed?  Marking for 1.0.2, please request approval

Comment 14

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 83654 [details] [diff] [review]
Add GCC3 xptcall support for Linux/SPARC, updated license

Preemptive a=[e-mail] for 1.0 branch.  (I assume this is in trunk now;
it should be marked fixed.)

Please change mozilla1.0.2+ to fixed1.0.2 when checked in.

Comment 15

[Doug Turner (:dougt)]

Checked into mozilla 1.0 Branch:

Checking in Makefile.in;
/cvsroot/mozilla/xpcom/reflect/xptcall/src/md/unix/Makefile.in,v  <--  Makefile.in
new revision: 1.63.2.2; previous revision: 1.63.2.1
done
Checking in xptcinvoke_asm_sparc_linux_GCC3.s;
/cvsroot/mozilla/xpcom/reflect/xptcall/src/md/unix/xptcinvoke_asm_sparc_linux_GCC3.s,v
 <--  xptcinvoke_asm_sparc_linux_GCC3.s
new revision: 1.1.2.1; previous revision: 1.1
done

Comment 16

[Gayatri Rimola]

Please verify the bug. Once verified, change the keyword fixed1.0.2 to
verified1.0.2