1443685 - GetPointAtLength should not take into account the ‘pathLength’ attribute.

Status: RESOLVED FIXED

(Core :: SVG, enhancement)

Comment 1

[Robert Longson [:longsonr]]

Attachment: 1443685.txt

This was clarified in the SVG 2 specification

https://www.w3.org/TR/SVG2/types.html#InterfaceSVGGeometryElement

Comment 2

[Daniel Holbert [:dholbert]]

Comment on attachment 8956668 [details] [diff] [review]
1443685.txt

Review of attachment 8956668 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with one nit:

::: dom/svg/test/test_pointAtLength.xhtml
@@ +21,4 @@
>    is(point.y, 50);
>  
>    // set the pathLength to twice its actual length
> +  // check that makes no difference

Please add a period at the end of the first line of this comment (before the new line that you're adding).

Otherwise this is easy to misread as a garbled run-on sentence ("set the pathLength to twice its actual length check that makes no difference")  :)

Comment 3

[Daniel Holbert [:dholbert]]

or if you prefer, maybe "and" would be better than a period. e.g.:

 // set the pathLength to twice its actual length
 // and check that makes no difference

*shrug*

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/1eb7354064c1
GetPointAtLength should not take into account the pathLength attribute r=dholbert

Comment 5

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/1eb7354064c1