GetPointAtLength should not take into account the ‘pathLength’ attribute.

RESOLVED FIXED in Firefox 60

Status

()

enhancement
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: longsonr, Assigned: longsonr)

Tracking

unspecified
mozilla60
Points:
---

Firefox Tracking Flags

(firefox60 fixed)

Details

Attachments

(1 attachment)

Comment hidden (empty)
(Assignee)

Comment 1

a year ago
Posted patch 1443685.txtSplinter Review
This was clarified in the SVG 2 specification

https://www.w3.org/TR/SVG2/types.html#InterfaceSVGGeometryElement
Assignee: nobody → longsonr
Attachment #8956668 - Flags: review?(dholbert)
Comment on attachment 8956668 [details] [diff] [review]
1443685.txt

Review of attachment 8956668 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with one nit:

::: dom/svg/test/test_pointAtLength.xhtml
@@ +21,4 @@
>    is(point.y, 50);
>  
>    // set the pathLength to twice its actual length
> +  // check that makes no difference

Please add a period at the end of the first line of this comment (before the new line that you're adding).

Otherwise this is easy to misread as a garbled run-on sentence ("set the pathLength to twice its actual length check that makes no difference")  :)
Attachment #8956668 - Flags: review?(dholbert) → review+
or if you prefer, maybe "and" would be better than a period. e.g.:

 // set the pathLength to twice its actual length
 // and check that makes no difference

*shrug*

Comment 4

a year ago
Pushed by longsonr@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/1eb7354064c1
GetPointAtLength should not take into account the pathLength attribute r=dholbert

Comment 5

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/1eb7354064c1
Status: NEW → RESOLVED
Last Resolved: a year ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
You need to log in before you can comment on or make changes to this bug.