Closed
Bug 1443685
Opened 7 years ago
Closed 7 years ago
GetPointAtLength should not take into account the ‘pathLength’ attribute.
Categories
(Core :: SVG, enhancement)
Core
SVG
Tracking
()
RESOLVED
FIXED
mozilla60
Tracking | Status | |
---|---|---|
firefox60 | --- | fixed |
People
(Reporter: longsonr, Assigned: longsonr)
Details
Attachments
(1 file)
1.31 KB,
patch
|
dholbert
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Comment 1•7 years ago
|
||
This was clarified in the SVG 2 specification
https://www.w3.org/TR/SVG2/types.html#InterfaceSVGGeometryElement
Assignee: nobody → longsonr
Attachment #8956668 -
Flags: review?(dholbert)
Comment 2•7 years ago
|
||
Comment on attachment 8956668 [details] [diff] [review]
1443685.txt
Review of attachment 8956668 [details] [diff] [review]:
-----------------------------------------------------------------
r=me with one nit:
::: dom/svg/test/test_pointAtLength.xhtml
@@ +21,4 @@
> is(point.y, 50);
>
> // set the pathLength to twice its actual length
> + // check that makes no difference
Please add a period at the end of the first line of this comment (before the new line that you're adding).
Otherwise this is easy to misread as a garbled run-on sentence ("set the pathLength to twice its actual length check that makes no difference") :)
Attachment #8956668 -
Flags: review?(dholbert) → review+
Comment 3•7 years ago
|
||
or if you prefer, maybe "and" would be better than a period. e.g.:
// set the pathLength to twice its actual length
// and check that makes no difference
*shrug*
Pushed by longsonr@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/1eb7354064c1
GetPointAtLength should not take into account the pathLength attribute r=dholbert
Comment 5•7 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox60:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
You need to log in
before you can comment on or make changes to this bug.
Description
•