Closed
Bug 1443744
Opened 6 years ago
Closed 6 years ago
Fix shadowed variables in pkix
Categories
(Core :: Security: PSM, enhancement)
Core
Security: PSM
Tracking
()
RESOLVED
FIXED
mozilla61
| Tracking | Status | |
|---|---|---|
| firefox61 | --- | fixed |
People
(Reporter: franziskus, Assigned: franziskus)
Details
Attachments
(1 file)
Building with Wshadow yields a couple errors in pkix.
|
||
Comment 1•6 years ago
|
||
Is the -Wno-error=shadow line not working as intended in security/pkix/moz.build? I guess my question is why is it important to do this right now?
Flags: needinfo?(franziskuskiefer)
|
Assignee | |
Comment 3•6 years ago
|
||
I'm playing with mozpkix in NSS and we have it enabled there. So I had to do this anyway and thought it might be a nice thing to have.
Flags: needinfo?(franziskuskiefer)
Ah, ok - thanks.
|
|
Assignee | |
Comment 5•6 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=9fd80ede90683d88c18b411544e139546cca614d
|
|
||
Comment 6•6 years ago
|
||
Comment on attachment 8956755 [details] Bug 1443744 - fix shadowing issues in pkix, r=keeler David Keeler [:keeler] (use needinfo) has approved the revision. https://phabricator.services.mozilla.com/D689
Attachment #8956755 -
Flags: review+
Pushed by franziskuskiefer@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/2361015585d4 fix shadowing issues in pkix, r=keeler
|
||
Comment 8•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/2361015585d4
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox61:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
You need to log in
before you can comment on or make changes to this bug.
Description
•