1443786 - The Canvas tab crashed at call-watcher.js

Status: VERIFIED FIXED

(DevTools Graveyard :: Canvas Debugger, defect)

Description

[mmis1000]

Attachment: The devtool crashed

User Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:58.0) Gecko/20100101 Firefox/58.0
Build ID: 20180206200532

Steps to reproduce:

1. open dev tool
2. go to devtool setting
3. enable canvas debugging
4. go to canvas tab
5. reload and click on the record button


Actual results:

The devtool crashed due to `TypeError: methodSignatureEnums is not a function`

at line 

resource://devtools/server/actors/call-watcher.js:168:34


Expected results:

It should record the canvas render timestamps.

Comment 1

[mmis1000]

sorry, i misselect the security bug option. please just ture it into general bug

Comment 2

[Wei-Cheng Pan [:wcpan] [:wcp] [:legnaleurc] (left Mozilla)]

https://searchfox.org/mozilla-central/source/devtools/server/actors/call-watcher.js#171

We probably need to change this line to

methodSignatureEnums = knownMethod.enums(args);

Probably a good-first-bug.

Comment 3

[Sean]

Attachment: fixTypeError.patch

Comment 4

[Julian Descottes [:jdescottes]]

That's a great find! This line is never tested on our test harness:
https://codecov.io/gh/marco-c/gecko-dev/src/master/devtools/server/actors/call-watcher.js#L171

This specific "if" branch seems to only be used when trying to debug WebGL contexts that call either texImage2D or texSubImage2D (which is the case on http://web.do.mmis1000.me/gl2/)

Comment 5

[Julian Descottes [:jdescottes]]

Comment on attachment 8958564 [details] [diff] [review]
fixTypeError.patch

Review of attachment 8958564 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good and fixes the issue, thanks for the patch Sean!
Could we just update the commit message in order to mention that the is for the CanvasDebugger. For instance

  Bug 1443786 - Fix CanvasDebugger crash due to a TypeError. r=jdescottes

... or something similar.

Comment 6

[Sean]

Attachment: fixTypeError.patch

Comment 7

[Sean]

Hi Julian,

I had updated the commit message, thanks for your review!

Sean

Comment 8

[Julian Descottes [:jdescottes]]

Comment on attachment 8958575 [details] [diff] [review]
fixTypeError.patch

Review of attachment 8958575 [details] [diff] [review]:
-----------------------------------------------------------------

Great! Thanks for quickly following up, looks good to me. 

As I mentioned earlier, the line you modified is not tested in our test suite, so no need to push this to our testing server.
I will mark your changeset as checkin-needed. A sheriff will then pick it up and land it in one of our integration branches. 
After that, your fix will "ride" the trains and be released with Firefox 61. 

Thanks for your contribution, if you are looking for more DevTools bugs, check out http://bugs.firefox-dev.tools/?easy&tool=all :)

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/908e2f7071a4
Fix CanvasDebugger crash due to a TypeError. r=jdescottes

Comment 10

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/908e2f7071a4

Comment 11

[Sajedul Islam]

I have reproduced this bug with Nightly 60.0a1 (2018-03-07) on Windows 10 , 64 Bit ! 

This bug's fix is Verified with latest Nightly !

Build   ID    20180317100337
User Agent    Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:61.0) Gecko/20100101 Firefox/61.0

[bugday-20180314]

Comment 12

[Mohammad Maruf Rahman]

I have reproduced this bug with Nightly 61.0a1 (2018-03-13) on Ubuntu 16.04 LTS!

This bug's fix is Verified with latest Nightly!

Build   ID    20180317111042
User Agent    Mozilla/5.0 (X11; Linux x86_64; rv:61.0) Gecko/20100101 Firefox/61.0

Comment 13

[Sajedul Islam]

As par comment 11 & comment 12 i am marking this bug as verified fixed.