Replace promiseWaitForCondition with TestUtils.waitForCondition in browser_devices_get_user_media.js

RESOLVED FIXED in Firefox 60

Status

()

P5
normal
RESOLVED FIXED
9 months ago
9 months ago

People

(Reporter: johannh, Assigned: kanika16047, Mentored)

Tracking

({good-first-bug})

60 Branch
Firefox 60
good-first-bug
Points:
---

Firefox Tracking Flags

(firefox60 fixed)

Details

Attachments

(1 attachment)

This is a good first bug for newcomers to Firefox development.

promiseWaitForCondition in the browser_devices_get_user_media.js test file can be replaced by the TestUtils.waitForCondition[0] utility function.

The code in question is here: https://searchfox.org/mozilla-central/rev/efce4ceddfbe5fe4e2d74f1aed93894bada9b273/browser/base/content/test/webrtc/browser_devices_get_user_media.js#518

For instructions on how to get your local build of Firefox up and running and submit your patch, see https://developer.mozilla.org/en-US/docs/Introduction.

You can run this test with the ./mach mochitest command:

./mach mochitest browser/base/content/test/webrtc/browser_devices_get_user_media.js

Please leave a comment if you would like to be assigned to this bug and feel free to ask questions here or via IRC if you're stuck.

[0] https://searchfox.org/mozilla-central/rev/efce4ceddfbe5fe4e2d74f1aed93894bada9b273/testing/modules/TestUtils.jsm#114
(Assignee)

Comment 1

9 months ago
I'd like to work on this. Thank you!

Updated

9 months ago
Assignee: nobody → kanika16047
Status: NEW → ASSIGNED
Comment hidden (mozreview-request)
Attachment #8957248 - Flags: review?(prathikshaprasadsuman)

Comment 3

9 months ago
mozreview-review
Comment on attachment 8957248 [details]
Bug 1443828  Replace promiseWaitForCondition with TestUtils.waitForCondition in browser_devices_get_user_media.js

https://reviewboard.mozilla.org/r/226166/#review232332

Thank you! The change looks great.

For future reference, here's how you can format your commit message:

<bug_number> - <commit_message> r?<reviewer's_irc_nickname>

In this case it is:

Bug 1443828 - Replace promiseWaitForCondition with TestUtils.waitForCondition in browser_devices_get_user_media.js. r?prathiksha

That should automatically set the review flag to '?' and notify the reviewer that they have a review request.


Also, we usually do a try run to make sure that the patch does not break anything. In this case, it looks we don't need a try run since your patch is pretty straightforward and it's unlikely to break anything. I'll also set the checkin-needed flag for you this time. That flag signals that we want the patch merged. When you set that flag, someone will eventually come and check the patch in for us. :)
Attachment #8957248 - Flags: review?(prathikshaprasadsuman) → review+

Updated

9 months ago
Keywords: checkin-needed

Comment 4

9 months ago
Pushed by ccoroiu@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/46273974a9d1
Replace promiseWaitForCondition with TestUtils.waitForCondition in browser_devices_get_user_media.js r=prathiksha
Keywords: checkin-needed

Comment 5

9 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/46273974a9d1
Status: ASSIGNED → RESOLVED
Last Resolved: 9 months ago
status-firefox60: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 60
You need to log in before you can comment on or make changes to this bug.