1443828 - Replace promiseWaitForCondition with TestUtils.waitForCondition in browser_devices_get_user_media.js

Status: RESOLVED FIXED

(Firefox :: Site Permissions, enhancement, P5)

Description

[Johann Hofmann [:johannh]]

This is a good first bug for newcomers to Firefox development.

promiseWaitForCondition in the browser_devices_get_user_media.js test file can be replaced by the TestUtils.waitForCondition[0] utility function.

The code in question is here: https://searchfox.org/mozilla-central/rev/efce4ceddfbe5fe4e2d74f1aed93894bada9b273/browser/base/content/test/webrtc/browser_devices_get_user_media.js#518

For instructions on how to get your local build of Firefox up and running and submit your patch, see https://developer.mozilla.org/en-US/docs/Introduction.

You can run this test with the ./mach mochitest command:

./mach mochitest browser/base/content/test/webrtc/browser_devices_get_user_media.js

Please leave a comment if you would like to be assigned to this bug and feel free to ask questions here or via IRC if you're stuck.

[0] https://searchfox.org/mozilla-central/rev/efce4ceddfbe5fe4e2d74f1aed93894bada9b273/testing/modules/TestUtils.jsm#114

Comment 1

[Kanika Saini]

I'd like to work on this. Thank you!

Comment 2

[Kanika Saini]

Attachment: Bug 1443828 Replace promiseWaitForCondition with TestUtils.waitForCondition in browser_devices_get_user_media.js

Review commit: https://reviewboard.mozilla.org/r/226166/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/226166/

Comment 3

[:prathiksha]

Comment on attachment 8957248 [details]
Bug 1443828  Replace promiseWaitForCondition with TestUtils.waitForCondition in browser_devices_get_user_media.js

https://reviewboard.mozilla.org/r/226166/#review232332

Thank you! The change looks great.

For future reference, here's how you can format your commit message:

<bug_number> - <commit_message> r?<reviewer's_irc_nickname>

In this case it is:

Bug 1443828 - Replace promiseWaitForCondition with TestUtils.waitForCondition in browser_devices_get_user_media.js. r?prathiksha

That should automatically set the review flag to '?' and notify the reviewer that they have a review request.


Also, we usually do a try run to make sure that the patch does not break anything. In this case, it looks we don't need a try run since your patch is pretty straightforward and it's unlikely to break anything. I'll also set the checkin-needed flag for you this time. That flag signals that we want the patch merged. When you set that flag, someone will eventually come and check the patch in for us. :)

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/46273974a9d1
Replace promiseWaitForCondition with TestUtils.waitForCondition in browser_devices_get_user_media.js r=prathiksha

Comment 5

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/46273974a9d1