1443833 - Remove unused gBrowser.tabContextMenu property

Status: RESOLVED FIXED

(Firefox :: Tabbed Browser, enhancement, P3)

Description

[Dão Gottwald [:dao]]

This is unused, we should remove it:

https://hg.mozilla.org/mozilla-central/annotate/f27d7eca013d/browser/base/content/tabbrowser.js#l259

Comment 1

[Omar]

Hi, I'm new here, can I get assigned this bug?? Thanks

Comment 2

[Dão Gottwald [:dao]]

(In reply to Omar from comment #1)
> Hi, I'm new here, can I get assigned this bug?? Thanks

Sure, and please let me know if you have questions.

Comment 3

[Omar]

Is it enough to just delete the property? (Because I already have a patch ready for that) or do I need to delete the attribute context menu from tab container too?

Comment 4

[Dão Gottwald [:dao]]

(In reply to Omar from comment #3)
> Is it enough to just delete the property? (Because I already have a patch
> ready for that) or do I need to delete the attribute context menu from tab
> container too?

Just the gBrowser property.

Comment 5

[Omar]

Alright I removed it I just need to figure out the patch submitting process I'll have it posted up in the next couple of hours

Comment 6

[Omar]

Attachment: A patch for bug #1443833

Comment 7

[Dão Gottwald [:dao]]

Comment on attachment 8957376 [details] [diff] [review]
A patch for bug #1443833

>   get visibleTabs() {
>     if (!this._visibleTabs)
>       this._visibleTabs = Array.filter(this.tabs,
>         tab => !tab.hidden && !tab.closing);
>     return this._visibleTabs;
>-  },

Looks like you accidentally removed this line. Can you please submit a new patch without this? Thanks!

Comment 8

[Omar]

I'm terribly sorry for this mistake I'll fix it right away

Comment 9

[Omar]

Attachment: removed getContextMenu without the extra bracket removed

Comment 10

[Dão Gottwald [:dao]]

Comment on attachment 8957558 [details] [diff] [review]
removed getContextMenu without the extra bracket removed

Looks good, thanks!

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/696b0f84b342
Remove unused gBrowser.tabContextMenu property. r=dao

Comment 12

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/696b0f84b342