Closed Bug 1443833 Opened 3 years ago Closed 3 years ago

Remove unused gBrowser.tabContextMenu property

Categories

(Firefox :: Tabbed Browser, enhancement, P3)

Product:
Firefox
Component:
Tabbed Browser
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 60
Tracking Flags:
Tracking Status
firefox60 --- fixed

People

(Reporter: dao, Assigned: boghdady5, Mentored)

Details

(Keywords: good-first-bug, Whiteboard: [lang=js])

Attachments

(1 file, 1 obsolete file)

removed getContextMenu without the extra bracket removed
431 bytes, patch
dao
: review+
Details | Diff | Splinter Review 
Hi, I'm new here, can I get assigned this bug?? Thanks
(In reply to Omar from comment #1)
> Hi, I'm new here, can I get assigned this bug?? Thanks

Sure, and please let me know if you have questions.
Assignee: nobody → boghdady5
Status: NEW → ASSIGNED
Is it enough to just delete the property? (Because I already have a patch ready for that) or do I need to delete the attribute context menu from tab container too?
(In reply to Omar from comment #3)
> Is it enough to just delete the property? (Because I already have a patch
> ready for that) or do I need to delete the attribute context menu from tab
> container too?

Just the gBrowser property.
Alright I removed it I just need to figure out the patch submitting process I'll have it posted up in the next couple of hours
Attached patch A patch for bug #1443833 (obsolete) — — Splinter Review
Attachment #8957376 - Flags: review?(dao+bmo)
Comment on attachment 8957376 [details] [diff] [review]
A patch for bug #1443833

>   get visibleTabs() {
>     if (!this._visibleTabs)
>       this._visibleTabs = Array.filter(this.tabs,
>         tab => !tab.hidden && !tab.closing);
>     return this._visibleTabs;
>-  },

Looks like you accidentally removed this line. Can you please submit a new patch without this? Thanks!
Attachment #8957376 - Flags: review?(dao+bmo)
I'm terribly sorry for this mistake I'll fix it right away
Attachment #8957376 - Attachment is obsolete: true
Attachment #8957558 - Flags: review?(dao+bmo)
Comment on attachment 8957558 [details] [diff] [review]
removed getContextMenu without the extra bracket removed

Looks good, thanks!
Attachment #8957558 - Flags: review?(dao+bmo) → review+
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/696b0f84b342
Remove unused gBrowser.tabContextMenu property. r=dao
https://hg.mozilla.org/mozilla-central/rev/696b0f84b342
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox60: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 60
You need to log in before you can comment on or make changes to this bug.