1443908 - Add Topsite modal changes position based on section position

Status: RESOLVED FIXED

(Firefox :: New Tab Page, defect, P2)

Description

[Andrei Oprea [:andreio]]

Attachment: Screen Shot 2018-03-07 at 21.16.47437.png

Move the Topsites section down and the modal to add a new topsite will be in a different position.

Comment 1

[Andrei Oprea [:andreio]]

Attachment: Screen Shot 2018-03-08 at 14.59.55648.png

Comment 2

[Andrei Oprea [:andreio]]

uiwanted: right now the modal follows the topsites section. This is ok if you click the edit button on an empty placeholder (it shows the modal where you clicked) but slightly odd (at least for me) when you click "Add topsite" and it shows up at the buttom of the page.

Comment 3

[Andrei Oprea [:andreio]]

Comment on attachment 8957142 [details]
Screen Shot 2018-03-08 at 14.59.55648.png

This screenshot shows that when at the buttom of the page with 1 row of topsites the modal shows up in such a way that it gets cut off/you have to scroll down.

Comment 4

[Aaron Benson]

Attachment: newtab_edit_top_site_modal_placement.png

Now that sections can be re-ordered, lets have the top site edit modal appear in a consistent location and avoid this problem. 40px from the top of the window should work nicely. See attached...

Comment 5

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/activity-stream/pull/4034

Comment 6

[[github robot]]

Commits pushed to master at https://github.com/mozilla/activity-stream

https://github.com/mozilla/activity-stream/commit/e753c99f21c2bf71f796ac6b695f9755ff894148
Fix Bug 1443908 - position: fixed; for Add Top Site modal

https://github.com/mozilla/activity-stream/commit/9d52b427db5f1b28740d707b0fdd8ef40ac4ff19
Merge pull request #4034 from rlr/Bug1443908/fixed-modal

Fix Bug 1443908 - position: fixed; for Add Top Site modal

Comment 7

[Ed Lee :Mardak]

https://hg.mozilla.org/mozilla-central/rev/9df46d48a21c