1443914 - Stale shipping options are passed to the front-end after an .updateWith() with no shipping options

Status: RESOLVED FIXED

(Core :: DOM: Web Payments, enhancement, P1)

Description

[Matthew N. [:MattN]]

If updateWith is called with no shippingOptions property after there were shipping options, it seems like the shipping options in the parent process (not sure about content process) don't get cleared.

Demo: https://googlechrome.github.io/samples/paymentrequest/dynamic-shipping/ 
* (Remove the legacy `supportedMethods` syntax in the `supportedInstruments` array:
```js
{
    supportedMethods: networks,
},
```
)

There is a TODO in the code that mentions that there is more to do with shippingOptions for updates: https://dxr.mozilla.org/mozilla-central/rev/bccdc684210431c233622650a91454c09f6af9eb/dom/payments/PaymentRequestManager.cpp#546,556

Comment 1

[EdenChuang(ChenYu Chuang)]

The root cause is the spec update, in the old spec, the old values would be kept if they are not in the new details.
I will write a patch according to this spec update.

Could someone assign this bug to me? thanks.

Comment 2

[Henri Sivonen (:hsivonen)]

Thank you for taking this.

Comment 3

[EdenChuang(ChenYu Chuang)]

Attachment: Bug 1443914 - Force updating PaymentDetails when requestShipping is true. r?baku

Update the implementation according to the spec update.                    
Force updating the saved PaymentDetails when requestShipping is true, even the data(shippingOptions) doesn't present in the DetailsUpdate.

Comment 4

[EdenChuang(ChenYu Chuang)]

Attachment: Bug 1443914 - mochitest for PaymentDetails updating implementation. r?baku

Comment 5

[EdenChuang(ChenYu Chuang)]

The try run

https://treeherder.mozilla.org/#/jobs?repo=try&revision=1bc35f591ea0d662b9f4cd957d4fe8cd2e97d8a1

Comment 6

[EdenChuang(ChenYu Chuang)]

Hi Baku, thank you for the fast review. :)

Comment 7

[EdenChuang(ChenYu Chuang)]

Attachment: Bug 1443914 - Force updating PaymentDetails when requestShipping is true. r?baku

Comment 8

[EdenChuang(ChenYu Chuang)]

Attachment: Bug 1443914 - mochitest for PaymentDetails updating implementation. r=baku

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/200ba8d29892
Force updating PaymentDetails when requestShipping is true. r=baku
https://hg.mozilla.org/integration/mozilla-inbound/rev/1ce3dc676ee9
Mochitest for force updating PaymentDetails. r=baku

Comment 10

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/200ba8d29892
https://hg.mozilla.org/mozilla-central/rev/1ce3dc676ee9