layout/base/RestyleManager.cpp:2024:22: error: member access into incomplete type 'nsTransitionManager'

RESOLVED FIXED in Firefox 60

Status

()

enhancement
RESOLVED FIXED
Last year
Last year

People

(Reporter: dholbert, Assigned: dholbert)

Tracking

Trunk
mozilla60
Points:
---

Firefox Tracking Flags

(firefox60 fixed)

Details

Attachments

(1 attachment)

If I build on Linux with...
 ac_add_options --enable-stylo=only
...and with unified builds disabled in layout/base (e.g. by dropping UNIFIED_" from its moz.build file), I get this error message:

layout/base/RestyleManager.cpp:2024:22: error: member access into incomplete type 'nsTransitionManager'


Indeed, that file is missing an #include for nsTransitionManager.h. (It must be picking it up from other file(s), some of which we get for free via unified builds, and some of which we get for free via #includes in non-unified non-stylo-only builds, but none of which we get in non-unified stylo-only builds.)

Let's add that header. That lets me build successfully with this mozconfig option and with unified builds disabled in layout/base and layout/generic.

(Discovered this bustage inadvertently on a Try run in bug 1443672.)
Here's where we use this class, FWIW:
>  nsTransitionManager* transitionManager =
>    mRestyleManager->PresContext()->TransitionManager();
> [...]
>    transitionManager->StopAnimationsForElement(element, aPseudoType);
https://dxr.mozilla.org/mozilla-central/rev/bccdc684210431c233622650a91454c09f6af9eb/layout/base/RestyleManager.cpp#2005
Comment on attachment 8956967 [details]
Bug 1443929: Give RestyleManager.cpp an include for nsTransitionManager.h (which it needs/uses).

https://reviewboard.mozilla.org/r/225918/#review231838

r=me


(Huh, I had written this yesterday, but mozreview didn't publish :/)
Attachment #8956967 - Flags: review?(emilio) → review+
Pushed by dholbert@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ee234920910b
Give RestyleManager.cpp an include for nsTransitionManager.h (which it needs/uses). r=emilio
https://hg.mozilla.org/mozilla-central/rev/ee234920910b
Status: NEW → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
You need to log in before you can comment on or make changes to this bug.