1443929 - layout/base/RestyleManager.cpp:2024:22: error: member access into incomplete type 'nsTransitionManager'

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, enhancement)

Description

[Daniel Holbert [:dholbert]]

If I build on Linux with...
 ac_add_options --enable-stylo=only
...and with unified builds disabled in layout/base (e.g. by dropping UNIFIED_" from its moz.build file), I get this error message:

layout/base/RestyleManager.cpp:2024:22: error: member access into incomplete type 'nsTransitionManager'


Indeed, that file is missing an #include for nsTransitionManager.h. (It must be picking it up from other file(s), some of which we get for free via unified builds, and some of which we get for free via #includes in non-unified non-stylo-only builds, but none of which we get in non-unified stylo-only builds.)

Let's add that header. That lets me build successfully with this mozconfig option and with unified builds disabled in layout/base and layout/generic.

(Discovered this bustage inadvertently on a Try run in bug 1443672.)

Comment 1

[Daniel Holbert [:dholbert]]

Attachment: Bug 1443929: Give RestyleManager.cpp an include for nsTransitionManager.h (which it needs/uses).

Review commit: https://reviewboard.mozilla.org/r/225918/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/225918/

Comment 2

[Daniel Holbert [:dholbert]]

Here's where we use this class, FWIW:
>  nsTransitionManager* transitionManager =
>    mRestyleManager->PresContext()->TransitionManager();
> [...]
>    transitionManager->StopAnimationsForElement(element, aPseudoType);
https://dxr.mozilla.org/mozilla-central/rev/bccdc684210431c233622650a91454c09f6af9eb/layout/base/RestyleManager.cpp#2005

Comment 3

[Emilio Cobos Álvarez (:emilio)]

Comment on attachment 8956967 [details]
Bug 1443929: Give RestyleManager.cpp an include for nsTransitionManager.h (which it needs/uses).

https://reviewboard.mozilla.org/r/225918/#review231838

r=me


(Huh, I had written this yesterday, but mozreview didn't publish :/)

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ee234920910b
Give RestyleManager.cpp an include for nsTransitionManager.h (which it needs/uses). r=emilio

Comment 5

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/ee234920910b