1443933 - Extended tweet mentions are not expanded

Status: RESOLVED DUPLICATE of bug 1445778

(Chat Core :: Twitter, defect)

Description

[Martin Giger [:freaktechnik]]

Since quite some time twitter has been hiding away the full tweet, if it exceeded a total of 140 characters. This is correctly expanded for tweets getting received via timeline streaming, but those getting loaded via mentions history (don't know if there's a difference) do not get properly expanded.

Comment 1

[Martin Giger [:freaktechnik]]

This seems to apply to all historic tweets, not just mentions. They probably have a different object layout than the streamed tweets.

Comment 2

[Martin Giger [:freaktechnik]]

Attachment: bug1443933-v1.patch

Feel free to redirect. Essentially just tells Twitter to send us the full tweets and then handles getting the full tweets (that no longer have a text property).

Comment 3

[Patrick Cloke [:clokep]]

Comment on attachment 8957010 [details] [diff] [review]
bug1443933-v1.patch

Review of attachment 8957010 [details] [diff] [review]:
-----------------------------------------------------------------

I think this looks sane overall. The amount of duplicate in parsing of tweets seems excessive, but that's not your fault.

I have one question in here though.

::: chat/protocols/twitter/twitter.js
@@ +195,5 @@
>        else {
> +        if ("full_text" in retweet)
> +          retweetText = retweet.full_text;
> +        else
> +          retweetText = retweet.text;

On line 191 we just always use full_text, does the "extended_tweet" object not get sent anymore or something?

Comment 4

[Martin Giger [:freaktechnik]]

(In reply to Patrick Cloke [:clokep] from comment #3)
> Comment on attachment 8957010 [details] [diff] [review]
> bug1443933-v1.patch
> 
> Review of attachment 8957010 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> I think this looks sane overall. The amount of duplicate in parsing of
> tweets seems excessive, but that's not your fault.
> 
> I have one question in here though.
> 
> ::: chat/protocols/twitter/twitter.js
> @@ +195,5 @@
> >        else {
> > +        if ("full_text" in retweet)
> > +          retweetText = retweet.full_text;
> > +        else
> > +          retweetText = retweet.text;
> 
> On line 191 we just always use full_text, does the "extended_tweet" object
> not get sent anymore or something?

That's part of the messy Twitter endpoints. In the streaming APIs we get extended_tweet if necessary, in the REST APIs we only get full_text. So all this patch adds is to handle the full_text field from the REST APIs, without removing any of the handling for the streaming APIs.