Closed Bug 1443944 Opened 6 years ago Closed 6 years ago

Web Replay: Don't use vsync messages to determine when to paint

Categories

(Core :: General, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED INVALID
Tracking Status
firefox60 --- affected

People

(Reporter: bhackett1024, Assigned: bhackett1024)

References

Details

Attachments

(1 file)

Attached patch patchSplinter Review
Paints in a content process are triggered based on vsync messages sent via IPDL from the UI process.  If a page is updating very rapidly these messages can lag those changes and events that update the DOM might not be painted.  Normally this isn't a problem, but when rewinding a replaying process this can be pretty confusing, as the graphics shown on screen won't reflect what is expected at that point in execution.

The attached patch changes this so that we attempt to paint with each turn of the main thread's event loop.  If nothing has changed, no painting occurs, but while doing this adds a little more overhead to a recording/replaying process it should ensure that paints occur at predictable times and when rewinding the graphics shown will reflect the state of the DOM at the start of the most recent event.
Assignee: nobody → bhackett1024
Closing this bug, all the changes here will be reviewed in separate bugs dependent on bug 1422587.
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: