Closed Bug 1443950 Opened 2 years ago Closed 2 years ago

Use GetComposedDoc() instead of OwnerDoc() in nsComputedDOMStyle::GetStyleContextNoFlush.

Categories

(Core :: CSS Parsing and Computation, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla61
Tracking Status
firefox61 --- fixed

People

(Reporter: emilio, Assigned: emilio)

References

Details

Attachments

(1 file)

The only reason this line:

  https://searchfox.org/mozilla-central/rev/33cc9e0331da8d9ff3750f1e68d72d61201176cb/layout/style/nsComputedDOMStyle.h#110

Is the way it is is because Element::WrapObject relies on that when NODE_FORCE_XBL_BINDINGS is set.
Assignee: nobody → emilio
[Triage 2018/03/23 - P3]
Priority: -- → P3
Comment on attachment 8962979 [details]
Bug 1443950: Go back to using getComposedDoc for the computed style by default.

https://reviewboard.mozilla.org/r/231824/#review237400
Attachment #8962979 - Flags: review?(bzbarsky) → review+
Pushed by ecoal95@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/0b76d5199c77
Go back to using getComposedDoc for the computed style by default. r=bz
https://hg.mozilla.org/mozilla-central/rev/0b76d5199c77
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
You need to log in before you can comment on or make changes to this bug.