1443950 - Use GetComposedDoc() instead of OwnerDoc() in nsComputedDOMStyle::GetStyleContextNoFlush.

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, enhancement, P3)

Description

[Emilio Cobos Álvarez [:emilio]]

The only reason this line:

  https://searchfox.org/mozilla-central/rev/33cc9e0331da8d9ff3750f1e68d72d61201176cb/layout/style/nsComputedDOMStyle.h#110

Is the way it is is because Element::WrapObject relies on that when NODE_FORCE_XBL_BINDINGS is set.

Comment 1

[Jet Villegas (inactive)]

[Triage 2018/03/23 - P3]

Comment 2

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1443950: Go back to using getComposedDoc for the computed style by default.

Now that NODE_FORCE_XBL_BINDINGS is gone, the only reason OwnerDoc() was added
in bug 1432490 is also gone.

Let's go back to using the composed doc, at least until the CSSWG decides on
what's the computed style of something that's not in[1].

[1]: https://github.com/w3c/csswg-drafts/issues/1548

Review commit: https://reviewboard.mozilla.org/r/231824/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/231824/

Comment 3

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 8962979 [details]
Bug 1443950: Go back to using getComposedDoc for the computed style by default.

https://reviewboard.mozilla.org/r/231824/#review237400

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0b76d5199c77
Go back to using getComposedDoc for the computed style by default. r=bz

Comment 5

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/0b76d5199c77