1443963 - Remove All Calls to FHR

Status: RESOLVED INVALID

(Firefox for Android Graveyard :: Metrics, enhancement, P1)

Description

[:sdaswani]

FHR is being called from Fennec still - remove all calls.

Comment 1

[:sdaswani]

Barbara, can you add this to your 61 list please?

Comment 2

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Which parts of FHR are being called? The platform/JS parts? I think we may still have some shell java code that doesn't do anything (and there are other bugs open to remove them).

Comment 3

[:sdaswani]

Mike, the mobile / Android bits from this HTTP log:

417466 Mozilla/5.0%2520(Windows%2520NT%252010.0;%2520Win64;%2520x64;%2520rv:58.0)%2520Gecko/20100101%2520Firefox/58.0
272008 Mozilla/5.0%2520(Windows%2520NT%25206.1;%2520Win64;%2520x64;%2520rv:58.0)%2520Gecko/20100101%2520Firefox/58.0
125487 Mozilla/5.0%2520(Windows%2520NT%25206.1;%2520rv:58.0)%2520Gecko/20100101%2520Firefox/58.0
101544 Mozilla/5.0%2520(Windows%2520NT%25205.1;%2520rv:52.0)%2520Gecko/20100101%2520Firefox/52.0
63503 Mozilla/5.0%2520(Windows%2520NT%25206.3;%2520Win64;%2520x64;%2520rv:58.0)%2520Gecko/20100101%2520Firefox/58.0
39415 Mozilla/5.0%2520(X11;%2520Ubuntu;%2520Linux%2520x86_64;%2520rv:58.0)%2520Gecko/20100101%2520Firefox/58.0
39269 Mozilla/5.0%2520(Macintosh;%2520Intel%2520Mac%2520OS%2520X%252010.13;%2520rv:58.0)%2520Gecko/20100101%2520Firefox/58.0
36503 Mozilla/5.0%2520(Windows%2520NT%25206.1;%2520WOW64;%2520rv:58.0)%2520Gecko/20100101%2520Firefox/58.0
33920 Mozilla/5.0%2520(Windows%2520NT%252010.0;%2520WOW64;%2520rv:58.0)%2520Gecko/20100101%2520Firefox/58.0
23762 Mozilla/5.0%2520(Windows%2520NT%252010.0;%2520rv:58.0)%2520Gecko/20100101%2520Firefox/58.0
23207 Mozilla/5.0%2520(Android%25207.0;%2520Mobile;%2520rv:58.0)%2520Gecko/58.0%2520Firefox/58.0
22372 Mozilla/5.0%2520(Windows%2520NT%25206.0;%2520rv:52.0)%2520Gecko/20100101%2520Firefox/52.0
15039 Mozilla/5.0%2520(Windows%2520NT%25206.1;%2520WOW64;%2520rv:52.0)%2520Gecko/20100101%2520Firefox/52.0
14473 Mozilla/5.0%2520(Macintosh;%2520Intel%2520Mac%2520OS%2520X%252010.12;%2520rv:58.0)%2520Gecko/20100101%2520Firefox/58.0
11872 Mozilla/5.0%2520(Macintosh;%2520Intel%2520Mac%2520OS%2520X%252010.11;%2520rv:58.0)%2520Gecko/20100101%2520Firefox/58.0
11720 Mozilla/5.0%2520(Windows%2520NT%25206.2;%2520Win64;%2520x64;%2520rv:58.0)%2520Gecko/20100101%2520Firefox/58.0
10478 Mozilla/5.0%2520(X11;%2520Ubuntu;%2520Linux%2520i686;%2520rv:58.0)%2520Gecko/20100101%2520Firefox/58.0
9927 Mozilla/5.0%2520(Windows%2520NT%252010.0;%2520Win64;%2520x64;%2520rv:57.0)%2520Gecko/20100101%2520Firefox/57.0
9476 Mozilla/5.0%2520(Android%25206.0.1;%2520Mobile;%2520rv:58.0)%2520Gecko/58.0%2520Firefox/58.0
9127 Mozilla/5.0%2520(Windows%2520NT%25206.1;%2520Win64;%2520x64;%2520rv:57.0)%2520Gecko/20100101%2520Firefox/57.0
7887 Mozilla/5.0%2520(Windows%2520NT%252010.0;%2520WOW64;%2520rv:52.0)%2520Gecko/20100101%2520Firefox/52.0
7235 Mozilla/5.0%2520(Windows%2520NT%25206.3;%2520WOW64;%2520rv:58.0)%2520Gecko/20100101%2520Firefox/58.0
7158 Mozilla/5.0%2520(Windows%2520NT%25206.1;%2520Win64;%2520x64;%2520rv:52.0)%2520Gecko/20100101%2520Firefox/52.0
6929 Mozilla/5.0%2520(X11;%2520Linux%2520x86_64;%2520rv:58.0)%2520Gecko/20100101%2520Firefox/58.0
5627 Mozilla/5.0%2520(Macintosh;%2520Intel%2520Mac%2520OS%2520X%252010.10;%2520rv:58.0)%2520Gecko/20100101%2520Firefox/58.0
5599 Mozilla/5.0%2520(Macintosh;%2520Intel%2520Mac%2520OS%2520X%252010.6;%2520rv:48.0)%2520Gecko/20100101%2520Firefox/48.0
5583 Mozilla/5.0%2520(Android%25207.1.1;%2520Mobile;%2520rv:58.0)%2520Gecko/58.0%2520Firefox/58.0
5464 Mozilla/5.0%2520(Android%25206.0;%2520Mobile;%2520rv:58.0)%2520Gecko/58.0%2520Firefox/58.0
5316 Mozilla/5.0%2520(Windows%2520NT%25206.1;%2520rv:52.0)%2520Gecko/20100101%2520Firefox/52.0
5088 Mozilla/5.0%2520(Windows%2520NT%252010.0;%2520Win64;%2520x64;%2520rv:52.0)%2520Gecko/20100101%2520Firefox/52.0

shyam@aloy ~/mozilla/fhr $ gzcat EULRU121JZEWE.2018-03*| awk {'print $10'} | sort | grep -v css | uniq -c | sort -nr | head -n 30
292057 https://fhr.cdn.mozilla.net/en-US/v4/
174896 https://fhr.cdn.mozilla.net/de/v4/
114500 -
113420 https://fhr.cdn.mozilla.net/fr/v4/
41701 https://fhr.cdn.mozilla.net/ru/v4/
39133 https://fhr.cdn.mozilla.net/pl/v4/
32652 https://fhr.cdn.mozilla.net/es-ES/v4/
30028 https://fhr.cdn.mozilla.net/it/v4/
22601 https://fhr.cdn.mozilla.net/zh-CN/v4/
22600 https://fhr.cdn.mozilla.net/en-GB/v4/
20404 https://fhr.cdn.mozilla.net/ja/v4/
14500 https://fhr.cdn.mozilla.net/en-US/mobile/?v=1
13495 https://fhr.cdn.mozilla.net/hu/v4/
11354 https://fhr.cdn.mozilla.net/en-US/
11230 https://fhr.cdn.mozilla.net/pt-BR/v4/
9339 https://fhr.cdn.mozilla.net/de/mobile/?v=1
8086 https://fhr.cdn.mozilla.net/zh-TW/v4/
7458 https://fhr.cdn.mozilla.net/cs/v4/
7295 https://fhr.cdn.mozilla.net/nl/v4/
7132 https://fhr.cdn.mozilla.net/id/v4/
7129 https://fhr.cdn.mozilla.net/ar/v4/
5173 https://fhr.cdn.mozilla.net/el/v4/
5073 https://fhr.cdn.mozilla.net/de/
5004 https://fhr.cdn.mozilla.net/es-AR/v4/
4831 https://fhr.cdn.mozilla.net/fi/v4/
4760 https://fhr.cdn.mozilla.net/fr/mobile/?v=1
4373 https://fhr.cdn.mozilla.net/es-MX/v4/
2886 https://fhr.cdn.mozilla.net/en-GB/mobile/?v=1
2772 https://fhr.cdn.mozilla.net/pt-PT/v4/
2630 https://fhr.cdn.mozilla.net/tr/v4/

Comment 4

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

[triage] P1: Susheel wants in 61 (comment 1).

fwiw, it's possible these end-points are being hit by forked versions of our code and we have actually removed all references.

Comment 5

[:sdaswani]

Good point Mike - then the bug would be more about investigating that we don't call FHR, but still worthwhile.

Comment 6

[Petru-Mugurel Lingurar [:petru]]

The fhr report URL is nowhere to be seen in Fennec's latest available code.
There is some old documentation left for posterity I guess, a few comments and a few references in javascript files from telemetry but nothing that would produce those calls.

Comment 7

[:sdaswani]

Thanks for confirming Petru!