144397 - Display Send Button with key icon when encryption is enabled

Status: VERIFIED WONTFIX

(MailNews Core :: Security: S/MIME, defect)

Description

[Kai Engert [:KaiE:]]

The crypto originally requested, the icons shown in the compose window should
behave very smart. They ask to display whether it is *possible* to send signed
or not, encrypted or not.

However, we realized that it is difficult to do so, because we have to change
the mail code to always have an updated list of all recipients, and to
communicate that list to the crypto code whenever it changes. We still want it,
but we'll do at a later time.


At the time of writing this, we are using a different approach. The icons in the
UI show what is currently configured. I.e., if encryption is turned on, there
will be an encryption icon shown in the status bar.


Because of the original UI spec, we already have an icon available (both modern
and classic), that is a variation of the send button in the compose window. It
shows an encryption key in addition.


I think it would be nice to show that alternate encryption send button, when
security is enabled for sending the current message. I.e., whenever we display
the security icon in the status bar, we should also show the encrypt send
button. If there is no encryption icon in the status bar, the send button should
look like always.

Comment 1

[Kai Engert [:KaiE:]]

Attachment: Patch to make the send button change

Comment 2

[Kai Engert [:KaiE:]]

Comment on attachment 83500 [details] [diff] [review]
Patch to make the send button change

Note to self, there is a typo in the patch, it has "I}" where it should have
"}".

Comment 3

[jglick]

> I.e., whenever we display the security icon in the status bar, we should also 
> show the encrypt send button. If there is no encryption icon in the status 
> bar, the send button should look like always.

My thought is that this adds more visual clutter to the window without providing 
any more valuable feedback that the statusbar icon already provides. In 
addition, if there is any chance we might get this working as originally spec'd  
in the future, its not good to get users used to one implementation behavior now 
and then changing that behavior later.

Comment 4

[Kai Engert [:KaiE:]]

Thanks for your comment, fine with me. Although I want to say, we are already
having another discrepancy in the compose window, the status bar icons currently
display what is configured, and in the future we want to change that to what's
possible.

Comment 5

[jglick]

Something to consider is that status bar icons generally show the current status 
of an item, not what is possible. Everywhere else in the product, we use the 
status bar icons to indicate current state. And when reading a message which was 
signed and/or encrypted, the status bar icons show state. If users assume the 
security status bar icons mean state, like in the rest of the product, and they 
really mean what is possible, it could cause problems.

Comment 6

[Kai Engert [:KaiE:]]

Ok, wontfix.

Comment 7

[Charles Rosendahl]

.