1443983 - Remove remaining add-on interpositions

Status: RESOLVED FIXED

(Firefox :: Extension Compatibility, enhancement)

Description

[Kris Maglione [:kmag]]

+++ This bug was initially created as a clone of Bug #1443964 +++

Comment 1

[Kris Maglione [:kmag]]

Attachment: Bug 1443983: Part 1 - Remove shim usage in browser_google_behavior.js.

Review commit: https://reviewboard.mozilla.org/r/225994/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/225994/

Comment 2

[Kris Maglione [:kmag]]

Attachment: Bug 1443983: Part 2 - Remove remaining interpositions.

Review commit: https://reviewboard.mozilla.org/r/225996/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/225996/

Comment 3

[Kris Maglione [:kmag]]

Attachment: Bug 1443983: Part 3 - Remove platform support for interpositions.

This is all dead code now that the interposition service has been removed.

Review commit: https://reviewboard.mozilla.org/r/225998/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/225998/

Comment 4

[Andrew McCreight [:mccr8]]

Comment on attachment 8957041 [details]
Bug 1443983: Part 3 - Remove platform support for interpositions.

https://reviewboard.mozilla.org/r/225998/#review232026

Nice.

Comment 5

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 8957039 [details]
Bug 1443983: Part 1 - Remove shim usage in browser_google_behavior.js.

https://reviewboard.mozilla.org/r/225994/#review232030

Excellent, thanks.

Comment 6

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 8957040 [details]
Bug 1443983: Part 2 - Remove remaining interpositions.

https://reviewboard.mozilla.org/r/225996/#review232034

I am not at all sorry to see this stuff go. Thanks so much, kmag.

::: toolkit/content/browser-child.js
(Diff revision 1)
> -    if (RemoteAddonsChild.useSyncWebProgress) {
> -      sendRpcMessage(name, data, objects);
> -    } else {

Oh thank goodness

::: toolkit/mozapps/extensions/AddonManagerStartup.cpp:514
(Diff revision 1)
>  /*****************************************************************************
>   * XPC interfacing
>   *****************************************************************************/
>  
>  static void
> -EnableShimsAndCPOWs(const nsAString& addonId, bool enableShims)
> +EnableShimsAndCPOWs(const nsAString& addonId)

This should probably just be EnableCPOWs or something similar now.

::: toolkit/mozapps/extensions/AddonManagerStartup.cpp
(Diff revision 1)
>  
>    if (!Preferences::GetBool("extensions.defaultProviders.enabled", true)) {
>      return NS_OK;
>    }
>  
> -  bool enableInterpositions = Preferences::GetBool("extensions.interposition.enabled", false);

This pref needs to be removed from firefox.js.

Comment 7

[Kris Maglione [:kmag]]

Comment on attachment 8957040 [details]
Bug 1443983: Part 2 - Remove remaining interpositions.

https://reviewboard.mozilla.org/r/225996/#review232034

> This pref needs to be removed from firefox.js.

Oh, good catch. I meant to remove that.

Comment 8

[Kris Maglione [:kmag]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/916ad3941bf1b8f06e8806f42ab7e2a3d5e46091
Bug 1443983: Part 1 - Remove shim usage in browser_google_behavior.js. r=mconley

https://hg.mozilla.org/integration/mozilla-inbound/rev/a45d6d58a07d2f999b285e9a821822a21bd69ac4
Bug 1443983: Part 2 - Remove remaining interpositions. r=mconley

https://hg.mozilla.org/integration/mozilla-inbound/rev/f1431c234b4eb10d3c16067465bfc22e8699c1ed
Bug 1443983: Part 3 - Remove platform support for interpositions. r=mccr8

Comment 9

[Kris Maglione [:kmag]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/bce9970180dc86666599d1af464beab098976fa7
Bug 1443983: Follow-up: Force initial about:blank browser to non-remote. r=me

Comment 10

[Kris Maglione [:kmag]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/5a091ec4e060846c84d650395791b095ef4c73e4
Bug 1443983: Follow-up: Add preferredRemoteType to addTab call to fix another unexpected intermittent. r=bustage

Comment 11

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/916ad3941bf1
https://hg.mozilla.org/mozilla-central/rev/a45d6d58a07d
https://hg.mozilla.org/mozilla-central/rev/f1431c234b4e
https://hg.mozilla.org/mozilla-central/rev/bce9970180dc
https://hg.mozilla.org/mozilla-central/rev/5a091ec4e060

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/c1203e6ba317
Remove add-on interpositions from SeaMonkey Installer. rs=bustage-fix

Comment 13

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/comm-central/rev/08c61155ede7
Backed out changeset: c1203e6ba317 for landing with the wrong bug number.