Closed Bug 1444002 Opened 6 years ago Closed 6 years ago

[wpt-sync] Sync PR 9911 - [WIP] Update testing of Request's default credentials mode

Categories

(Core :: DOM: Core & HTML, defect, P3)

Product:
Core
Component:
DOM: Core & HTML
Type:
defect

Tracking

()

Status:
RESOLVED DUPLICATE of bug 1394399

People

(Reporter: wpt-sync, Unassigned)

References

Details

(Whiteboard: [wptsync downstream error]) 

Sync web-platform-tests PR 9911 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/w3c/web-platform-tests/pull/9911
Details from upstream follow.

Dominic Farolino wrote:
>  [WIP] Update testing of Request's default credentials mode
>  
>  This is for https://github.com/whatwg/fetch/pull/585.
>  
>  I'm a little surprised if only these tests have to be updated, so I'm marking this as a WIP for now. Basically what I did though, was:
>  
>   - Ran all of the `/fetch`, `/xor`, `service-workers`, and `/cors` tests on Chromium, and noted failues (none)
>   - Modified the Request constructor to use the `same-origin` credentials fallback instead of the previous `omit`
>   - Ran all of the previous tests again and noted the failures (only two)
>   - Updated the affected tests!
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Component: web-platform-tests → DOM
Product: Testing → Core
I'm going to manually land these test changes as part of bug 1394399.
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → DUPLICATE
Ran 2 tests and 22 subtests
OK     : 2
PASS   : 20
FAIL   : 2

Existing tests that now have a worse result (e.g. they used to PASS and now FAIL):
/fetch/api/request/request-init-003.sub.html
    Check request values when initialized from url string: FAIL
/fetch/api/request/request-structure.html
    Check credentials attribute: FAIL
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.