1444031 - Rename a couple of atom-related things

Status: RESOLVED FIXED

(Core :: XPCOM, enhancement)

Description

[Nicholas Nethercote [inactive]]

This is a precursor to bug 1411469.

Comment 1

[Nicholas Nethercote [inactive]]

Attachment: Bug 1444031 - Rename Is{Static,Dynamic,HTML5}Atom.

By removing the "Atom" suffix, which is redundant.

Review commit: https://reviewboard.mozilla.org/r/226028/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/226028/

Comment 2

[Nicholas Nethercote [inactive]]

Attachment: Bug 1444031 - Rename nsStaticAtom::mAtom as mAtomp.

Because (a) that name better indicates that it's a pointer to a pointer, and
(b) because nsStaticAtom::mString is going to be renamed as mAtom in bug
1411469.

Review commit: https://reviewboard.mozilla.org/r/226030/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/226030/

Comment 3

[Nathan Froyd [:froydnj]]

Comment on attachment 8957075 [details]
Bug 1444031 - Rename Is{Static,Dynamic,HTML5}Atom.

https://reviewboard.mozilla.org/r/226028/#review232146

Sure.

Comment 4

[Nathan Froyd [:froydnj]]

Comment on attachment 8957076 [details]
Bug 1444031 - Rename nsStaticAtom::mAtom as mAtomp.

https://reviewboard.mozilla.org/r/226030/#review232148

Bikeshed: Just call this `mAtomPtr`?  Or `mAtomLoc`?  `mAtomp` seems a little too terse.

Comment 5

[Nicholas Nethercote [inactive]]

Oddly enough, I find the 'p' suffix clearer for a pointer to a pointer. I think there is precedent elsewhere. (E.g. the 'atomp' local in RegisterStaticAtoms().) In contrast, a "Ptr" suffix makes me think it's a single-level pointer, like RefPtr or AutoPtr or UniquePtr. So I'll stick with mAtomp.

Comment 6

[Nicholas Nethercote [inactive]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d660ed0a7b4673769ab76298f78ed6661ef6138d
Bug 1444031 - Rename Is{Static,Dynamic,HTML5}Atom. r=froydnj

https://hg.mozilla.org/integration/mozilla-inbound/rev/02a9e772183cc47ee6e7dec944a4996ff047c8f6
Bug 1444031 - Rename nsStaticAtom::mAtom as mAtomp. r=froydnj

Comment 7

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/d660ed0a7b46
https://hg.mozilla.org/mozilla-central/rev/02a9e772183c