144404 - Submit-button don't work

Status: RESOLVED WORKSFORME

(Core :: Layout: Form Controls, defect)

Description

[Erik Linder]

From Bugzilla Helper:
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.0rc2)
Gecko/20020510
BuildID:    2002051006

Maby this is the same bug as in bugid: 143385 and/or 142877

The submit-button on this page (open bulletin board 1.0.0) stopped working when
I upgraded from Moz 0.9.8 to 1.0 rc2.

I have used Moz as my main browser for over a year now, and I've never seen this
bug before.

Here is the code (for the button):
            <input type="submit"  name="submit" value="Submit Post">


Reproducible: Always
Steps to Reproduce:
1. Go to http://straight-pipes.org/board/
2. Click on a subject, ex: "Humor"
3. Click on new thread
4. Click on "submit post"

Actual Results:  Nothing... "non at all" as Mr D. Adams say ;-)

Comment 1

[rods (gone)]

-->

Comment 2

[Mike Brittain]

I am seeing similar behavior (RC1 2002051006 win2K).

Building a testcase.

Comment 3

[Mike Brittain]

Attachment: testcase

This bug seems to be caused by a nested FORM tag which is used to handle the
text formatting buttons on the original form at the URL above.	An onsubmit
handler is supposed to be called by the submit button, but the nested FORM
seems to be getting in the way.  

If the nested FORM tag is removed, the submit works properly.

This occurs on RC2. 

WORKSFORME
The original form at http://straight-pipes.org/board/  appears to be working OK
on 2002051208 (Win2000).

Comment 4

[Alexandru Savulov]

Mike:

did you got the reduced testcase from the http://straight-pipes.org/board/?

i'm asking, be cause the tescase is not working in IE6 either, but i think that
the original page from the disscution board works with IE, otherwise the owner
wouldn't run it like that.

Comment 5

[Mike Brittain]

Yes, the testcase was originally from straigh-pipes.org and was stripped down.

I also noticed that the testcase stopped working in IE6.  I don't know at what
point of stripping out code that this happened.  The main point, in my opinion,
was that the nested form tag seemed to be causing the troubles for Mozilla. 
Like I said, the original page works for me now in Mozilla.

If you would like, I can try to go back to some of the other versions of the
testcase I was stripping down and see if I can find out where IE6 stopped
working.  Maybe there is something else in that original page to consider?

Comment 6

[Alexandru Savulov]

well nested forms are a very nasty problem since there is no defined way to
handle them (the specs don't say a shit about that :-). generally web authors
should try to not nest forms and also not to forget the </form> tags. well the
second issue is malformed HTML (and XML) but the first issue (nested forms) is
valid HTML/XML. every browser does here some own voodoo, but since there is no
spec on this issue any way chosen will result in having some pages work and some
not. if you fix one thing, you'll break another.

Comment 7

[Mike Brittain]

Well if it now works on the recent builds, do we mark it as resolved?  Perhaps
an update in the parser managed to solve this.

I'm not an expert at reading the HTML DTD, but the loose DTD for 4.0
transitional markup specifies form as:

   <!ELEMENT FORM - - (%flow;)* -(FORM)   -- interactive form -->

The -(FORM) thing there means that a form tag can't reside within another form,
right?  I don't know whether that excludes markup where the nested form is
nested within another tag set... i.e.:

<form>
  <div>
    <form>form nested inside a div is ok or not???</form>
  </div>
</form>

In any case, I have no idea what happens when the parser is not running in
strict mode.  Seems like just about anything goes.

Comment 8

[Boris Zbarsky [:bzbarsky]]

This was almost certainly fixed by the (trunk-only) removal of DemoteForm...
Erik, any chance you could try a trunk build?

Comment 9

[Erik Linder]

I have now tried the latest build (2002051408)
The submit-button works, but not as expected.

Now I get a popup:
[JavaScript Application]
! Please complete all fields.
( OK )

That's true in some sort of way, I haven't filled all fields. But I don't have 
to fill all fields...

Tnx for the very quick response anyway!
I'm currently forced to use IE, can you imagine how _that_ feels... :-)

./Erik

Comment 10

[Mike Brittain]

That popup is from a validation function that straight-pipes has included on
that form.  If the subject and message (?) are left blank, then you get the
alert.  If you weren't seeing it at all before, perhaps other bugs were
preventing it from being displayed.

Comment 11

[Erik Linder]

I have now changed back to 0.9.8 which works fine for me.
I'm looking forward to rc3, I'll test it when it arrives!
If you want me to test anything, just let me know!
./Erik

Comment 12

[Alexandru Savulov]

sure man! every help is welcome!

Comment 13

[Michael Lefevre]

reporter (Erik): can you reproduce this problem with a recent build of mozilla
(for example, 1.1alpha)? if so, please comment again. if not, please resolve
this bug as WORKSFORME. thanks.

Comment 14

[Erik Linder]

I've tested with 1.1a.
1) The submit-button in the webpage is now working, that's great!
...but...
2) Instead of posting the text I enter in the area above the button, it just
don't post anything back to the server... OpenBB answer with this message:
"No Message specified!
Go back and try again."

Comment 15

[Alexandru Savulov]

does the web page that caused this bug have nested forms?

Comment 16

[Erik Linder]

Some new info:

The webpage (straight-pipes.org) is now working with Mozilla. The webmaster have
upgraded the OpenBB-system during the summer. Obviously something is changed in
the OpenBB-code, and it's now working with Mozilla.

So, please close this case, I can not test it anymore... ;-)

I have changed work, so if you can change my old e-mail address to my new
address @rgk.se. (Maby thats not necessary if you gonna close the case anyway?)

./Erik

Comment 17

[Boris Zbarsky [:bzbarsky]]

ok... closing as worksforme, but please reopen if there is a testcase that 
shows the problem again....