1444059 - Expected color but found ‘-moz-activehyperlinktext’. Error in parsing value for ‘color’. Declaration dropped.

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect, P3)

Description

[Richard Marti (:Paenglab)]

With locally built TB 60 I see this error: Expected color but found ‘-moz-activehyperlinktext’.  Error in parsing value for ‘color’.  Declaration dropped.

I see this also when I set this color in FX.

With a official Daily, where stylo is disabled, I don't see this error. So it's probably a stylo error.

Comment 1

[Xidorn Quan [:xidorn] UTC+10]

> #[derive(Clone, Copy, Debug, Eq, Hash, MallocSizeOf, Parse, PartialEq, ToCss)]
> pub enum SpecialColorKeyword {
>     MozDefaultColor,
>     MozDefaultBackgroundColor,
>     MozHyperlinktext,
>     MozActiveHyperlinktext,
>     MozVisitedHyperlinktext,
> }

So it is actually changed to -moz-active-hyperlinktext, which is regressed by servo/servo#19903.

Comment 2

[Xidorn Quan [:xidorn] UTC+10]

Fixing this should be pretty trivial... Just change the case...

Comment 3

[Emilio Cobos Álvarez (:emilio)]

(In reply to Xidorn Quan [:xidorn] UTC+10 from comment #1)
> > #[derive(Clone, Copy, Debug, Eq, Hash, MallocSizeOf, Parse, PartialEq, ToCss)]
> > pub enum SpecialColorKeyword {
> >     MozDefaultColor,
> >     MozDefaultBackgroundColor,
> >     MozHyperlinktext,
> >     MozActiveHyperlinktext,
> >     MozVisitedHyperlinktext,
> > }
> 
> So it is actually changed to -moz-active-hyperlinktext, which is regressed
> by servo/servo#19903.

Actually, these values seem unused and untested, can't we just rip them off?

Comment 4

[Emilio Cobos Álvarez (:emilio)]

Seems like they're obsolete (they were used until when we have a pref sheet). The only test is disabled (bug 1207190), lol.

I'll fix them for now because I can't remove the DefaultBackgroundColor one (is used), and I don't want to do the intent to unship dance just for three hyperlink constants.

Comment 5

[Jet Villegas (inactive)]

[Triage 2018/03/23 - P3]

Comment 6

[Xidorn Quan [:xidorn] UTC+10]

This has been fixed by servo/servo#20240.