getUserMedia fails when full-duplex is disabled

RESOLVED FIXED in Firefox 59

Status

()

P3
normal
Rank:
25
RESOLVED FIXED
9 months ago
9 months ago

People

(Reporter: jbeich, Assigned: jbeich)

Tracking

({regression})

Trunk
mozilla60
Unspecified
FreeBSD
regression
Points:
---
Bug Flags:
qe-verify -

Firefox Tracking Flags

(relnote-firefox 59+, firefox-esr52 unaffected, firefox58 unaffected, firefox59 fixed, firefox60 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

9 months ago
media.navigator.audio.full_duplex=false (default on BSDs) uses audio_device backends which no longer works. According to bug 1394163 comment 7 and bug 1437670 comment 11 the culprit is probably bug 1397793.

NotFoundError: The object can not be found here.
https://mozilla.github.io/webrtc-landing/gum_test.html
Comment hidden (mozreview-request)

Comment 2

9 months ago
mozreview-review
Comment on attachment 8957150 [details]
Bug 1444074 - Enable full-duplex by default for all platforms.

https://reviewboard.mozilla.org/r/226084/#review232020
Attachment #8957150 - Flags: review?(padenot) → review+

Updated

9 months ago
Assignee: nobody → jbeich
Status: NEW → ASSIGNED
Rank: 25
Priority: -- → P3
(Assignee)

Updated

9 months ago
Keywords: checkin-needed
(Assignee)

Comment 3

9 months ago
On Firefox 58 with ALSA full-duplex and not work fine on FreeBSD. Ditto PulseAudio.
status-firefox58: --- → unaffected
(Assignee)

Comment 4

9 months ago
Comment on attachment 8957150 [details]
Bug 1444074 - Enable full-duplex by default for all platforms.

If too late for 59.0, please, consider for 59.0.1 as WebRTC is broken in later versions (bug 1437670).

Approval Request Comment
[Feature/Bug causing the regression]: Bug 1397793
[User impact if declined]: Broken getUserMedia (audio) on DragonFly, FreeBSD, NetBSD, OpenBSD. Video chat apps either wouldn't work or be always muted.
[Is this code covered by automated tests?]: Yes
[Has the fix been verified in Nightly?]: Yes, both Firefox 60 and Firefox 59. On Firefox 60 tested after reverting gyp->gn conversion.
[Needs manual test from QE? If yes, steps to reproduce]: No
[List of other uplifts needed for the feature/fix]: None
[Is the change risky?]: No
[Why is the change risky/not risky?]: If a typo creeps in dom/media tests would be perma-orange at least on Linux as media.navigator.audio.full_duplex=false is broken.
[String changes made/needed]: None
Attachment #8957150 - Flags: approval-mozilla-release?

Comment 5

9 months ago
Pushed by ccoroiu@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d5df49dd7e75
Enable full-duplex by default for all platforms. r=padenot
Keywords: checkin-needed

Comment 6

9 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/d5df49dd7e75
Status: ASSIGNED → RESOLVED
Last Resolved: 9 months ago
status-firefox60: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
status-firefox-esr52: --- → unaffected
Comment on attachment 8957150 [details]
Bug 1444074 - Enable full-duplex by default for all platforms.

Low-risk, big win, A+
Attachment #8957150 - Flags: approval-mozilla-release? → approval-mozilla-release+

Comment 8

9 months ago
bugherderuplift
https://hg.mozilla.org/releases/mozilla-release/rev/37e4e6f9c39e
status-firefox59: affected → fixed
Added to 59.0.2 release notes
relnote-firefox: --- → 59+
(In reply to Jan Beich from comment #4)
> [Is this code covered by automated tests?]: Yes
> [Has the fix been verified in Nightly?]: Yes, both Firefox 60 and Firefox
> 59. On Firefox 60 tested after reverting gyp->gn conversion.
> [Needs manual test from QE? If yes, steps to reproduce]: No

Setting qe-verify- based on Jan's assessment on manual testing needs and the fact that this fix has automated coverage.
Flags: qe-verify-
You need to log in before you can comment on or make changes to this bug.