1444074 - getUserMedia fails when full-duplex is disabled

Status: RESOLVED FIXED

(Core :: WebRTC: Audio/Video, defect, P3)

Description

[Jan Beich]

media.navigator.audio.full_duplex=false (default on BSDs) uses audio_device backends which no longer works. According to bug 1394163 comment 7 and bug 1437670 comment 11 the culprit is probably bug 1397793.

NotFoundError: The object can not be found here.
https://mozilla.github.io/webrtc-landing/gum_test.html

Comment 1

[Jan Beich]

Attachment: Bug 1444074 - Enable full-duplex by default for all platforms.

Review commit: https://reviewboard.mozilla.org/r/226084/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/226084/

Comment 2

[Paul Adenot (:padenot)]

Comment on attachment 8957150 [details]
Bug 1444074 - Enable full-duplex by default for all platforms.

https://reviewboard.mozilla.org/r/226084/#review232020

Comment 3

[Jan Beich]

On Firefox 58 with ALSA full-duplex and not work fine on FreeBSD. Ditto PulseAudio.

Comment 4

[Jan Beich]

Comment on attachment 8957150 [details]
Bug 1444074 - Enable full-duplex by default for all platforms.

If too late for 59.0, please, consider for 59.0.1 as WebRTC is broken in later versions (bug 1437670).

Approval Request Comment
[Feature/Bug causing the regression]: Bug 1397793
[User impact if declined]: Broken getUserMedia (audio) on DragonFly, FreeBSD, NetBSD, OpenBSD. Video chat apps either wouldn't work or be always muted.
[Is this code covered by automated tests?]: Yes
[Has the fix been verified in Nightly?]: Yes, both Firefox 60 and Firefox 59. On Firefox 60 tested after reverting gyp->gn conversion.
[Needs manual test from QE? If yes, steps to reproduce]: No
[List of other uplifts needed for the feature/fix]: None
[Is the change risky?]: No
[Why is the change risky/not risky?]: If a typo creeps in dom/media tests would be perma-orange at least on Linux as media.navigator.audio.full_duplex=false is broken.
[String changes made/needed]: None

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d5df49dd7e75
Enable full-duplex by default for all platforms. r=padenot

Comment 6

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/d5df49dd7e75

Comment 7

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 8957150 [details]
Bug 1444074 - Enable full-duplex by default for all platforms.

Low-risk, big win, A+

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-release/rev/37e4e6f9c39e

Comment 9

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Added to 59.0.2 release notes

Comment 10

[Andrei Vaida [:avaida]]

(In reply to Jan Beich from comment #4)
> [Is this code covered by automated tests?]: Yes
> [Has the fix been verified in Nightly?]: Yes, both Firefox 60 and Firefox
> 59. On Firefox 60 tested after reverting gyp->gn conversion.
> [Needs manual test from QE? If yes, steps to reproduce]: No

Setting qe-verify- based on Jan's assessment on manual testing needs and the fact that this fix has automated coverage.