Closed
Bug 1444109
Opened 7 years ago
Closed 7 years ago
[tracking protection 2.0] TP Stats parsing blocklists taking 1 sec on main
Categories
(Firefox for iOS :: General, enhancement, P2)
Tracking
()
RESOLVED
FIXED
11.0
| Tracking | Status | |
|---|---|---|
| fxios | ? | --- |
People
(Reporter: garvan, Assigned: garvan)
References
Details
Attachments
(1 file)
The function `func wildcardContentBlockerDomainToRegex(domain: String) -> NSRegularExpression?` is taking the bulk of the parsing time.
I tested adding some memoization to this function and my profile goes from 1s to 0.25s.
We should port to Focus iOS also.
In the original Focus code, this is a closure (I changed to a function because we re-use it):
https://github.com/mozilla-mobile/focus-ios/blob/master/Blockzilla/Lib/TrackingProtection/TrackingProtection.swift#L111
Attachment #8957226 -
Flags: review?(jdarcangelo)
Attachment #8957226 -
Flags: feedback?(jboek)
|
||
Updated•7 years ago
|
Attachment #8957226 -
Flags: review?(jdarcangelo) → review+
landed on master
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Whiteboard: [needsuplift]
|
||
Updated•7 years ago
|
Whiteboard: [needsuplift]
Attachment #8957226 -
Flags: feedback?(jboek)
You need to log in
before you can comment on or make changes to this bug.
Description
•