1444129 - Fix names of fields in xpt_struct.h

Status: RESOLVED FIXED

(Core :: XPCOM, enhancement)

Description

[Andrew McCreight [:mccr8]]

These patches change the field names from foo_bar to mFooBar. I left alone  XPTTypeDescriptor.u and everything in XPTConstValue.

Comment 1

[Andrew McCreight [:mccr8]]

This is hopefully the last bit of major refactoring before bug 1438688.

Comment 2

[Andrew McCreight [:mccr8]]

Attachment: Bug 1444129, part 1 - Rename fields of XPTHeader.

Review commit: https://reviewboard.mozilla.org/r/226224/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/226224/

Comment 3

[Andrew McCreight [:mccr8]]

Attachment: Bug 1444129, part 2 - Rename fields of XPTInterfaceDirectoryEntry.

Review commit: https://reviewboard.mozilla.org/r/226226/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/226226/

Comment 4

[Andrew McCreight [:mccr8]]

Attachment: Bug 1444129, part 3 - Rename XPTInterfaceDescriptor fields.

Review commit: https://reviewboard.mozilla.org/r/226228/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/226228/

Comment 5

[Andrew McCreight [:mccr8]]

Attachment: Bug 1444129, part 4 - Rename the one field of XPTTypeDescriptorPrefix.

Review commit: https://reviewboard.mozilla.org/r/226230/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/226230/

Comment 6

[Andrew McCreight [:mccr8]]

Attachment: Bug 1444129, part 5 - Rename fields of XPTTypeDescriptor and XPTConstDescriptor.

Review commit: https://reviewboard.mozilla.org/r/226232/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/226232/

Comment 7

[Andrew McCreight [:mccr8]]

Attachment: Bug 1444129, part 6 - Rename fields of XPTParamDescriptor.

Review commit: https://reviewboard.mozilla.org/r/226234/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/226234/

Comment 8

[Andrew McCreight [:mccr8]]

Attachment: Bug 1444129, part 7 - Rename fields of XPTMethodDescriptor.

Review commit: https://reviewboard.mozilla.org/r/226236/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/226236/

Comment 9

[Nicholas Nethercote [inactive]]

Comment on attachment 8957325 [details]
Bug 1444129, part 1 - Rename fields of XPTHeader.

https://reviewboard.mozilla.org/r/226224/#review232176

+1 for modifying the names in comments!

Comment 10

[Nicholas Nethercote [inactive]]

Comment on attachment 8957326 [details]
Bug 1444129, part 2 - Rename fields of XPTInterfaceDirectoryEntry.

https://reviewboard.mozilla.org/r/226226/#review232180

Comment 11

[Nicholas Nethercote [inactive]]

Comment on attachment 8957327 [details]
Bug 1444129, part 3 - Rename XPTInterfaceDescriptor fields.

https://reviewboard.mozilla.org/r/226228/#review232182

Comment 12

[Nicholas Nethercote [inactive]]

Comment on attachment 8957328 [details]
Bug 1444129, part 4 - Rename the one field of XPTTypeDescriptorPrefix.

https://reviewboard.mozilla.org/r/226230/#review232184

Comment 13

[Nicholas Nethercote [inactive]]

Comment on attachment 8957329 [details]
Bug 1444129, part 5 - Rename fields of XPTTypeDescriptor and XPTConstDescriptor.

https://reviewboard.mozilla.org/r/226232/#review232186

Comment 14

[Nicholas Nethercote [inactive]]

Comment on attachment 8957330 [details]
Bug 1444129, part 6 - Rename fields of XPTParamDescriptor.

https://reviewboard.mozilla.org/r/226234/#review232188

Comment 15

[Nicholas Nethercote [inactive]]

Comment on attachment 8957331 [details]
Bug 1444129, part 7 - Rename fields of XPTMethodDescriptor.

https://reviewboard.mozilla.org/r/226236/#review232190

::: xpcom/reflect/xptinfo/xptinfo.h:198
(Diff revision 1)
> -    bool IsNotXPCOM() const {return !!(flags & kNotXPCOMMask);}
> -    bool IsHidden() const {return !!(flags & kHiddenMask);}
> -    bool WantsOptArgc() const {return !!(flags & kOptArgcMask);}
> -    bool WantsContext() const {return !!(flags & kContextMask);}
> -    const char* GetName() const {return name;}
> -    uint8_t GetParamCount() const {return num_args;}
> +    bool IsNotXPCOM() const {return !!(mFlags & kNotXPCOMMask);}
> +    bool IsHidden() const {return !!(mFlags & kHiddenMask);}
> +    bool WantsOptArgc() const {return !!(mFlags & kOptArgcMask);}
> +    bool WantsContext() const {return !!(mFlags & kContextMask);}
> +    const char* GetName() const {return mName;}
> +    uint8_t GetParamCount() const {return mNumArgs;}

Bonus points if you add spaces around the braces of these one-liner functions.

Comment 16

[Andrew McCreight [:mccr8]]

(In reply to Nicholas Nethercote [:njn] from comment #15)
> Bonus points if you add spaces around the braces of these one-liner
> functions.

Done.

Comment 17

[Andrew McCreight [:mccr8]]

Comment on attachment 8957325 [details]
Bug 1444129, part 1 - Rename fields of XPTHeader.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/226224/diff/1-2/

Comment 18

[Andrew McCreight [:mccr8]]

Comment on attachment 8957326 [details]
Bug 1444129, part 2 - Rename fields of XPTInterfaceDirectoryEntry.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/226226/diff/1-2/

Comment 19

[Andrew McCreight [:mccr8]]

Comment on attachment 8957327 [details]
Bug 1444129, part 3 - Rename XPTInterfaceDescriptor fields.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/226228/diff/1-2/

Comment 20

[Andrew McCreight [:mccr8]]

Comment on attachment 8957328 [details]
Bug 1444129, part 4 - Rename the one field of XPTTypeDescriptorPrefix.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/226230/diff/1-2/

Comment 21

[Andrew McCreight [:mccr8]]

Comment on attachment 8957329 [details]
Bug 1444129, part 5 - Rename fields of XPTTypeDescriptor and XPTConstDescriptor.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/226232/diff/1-2/

Comment 22

[Andrew McCreight [:mccr8]]

Comment on attachment 8957330 [details]
Bug 1444129, part 6 - Rename fields of XPTParamDescriptor.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/226234/diff/1-2/

Comment 23

[Andrew McCreight [:mccr8]]

Comment on attachment 8957331 [details]
Bug 1444129, part 7 - Rename fields of XPTMethodDescriptor.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/226236/diff/1-2/

Comment 24

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e1641b8d914d
part 1 - Rename fields of XPTHeader. r=njn
https://hg.mozilla.org/integration/autoland/rev/3e099aa442a9
part 2 - Rename fields of XPTInterfaceDirectoryEntry. r=njn
https://hg.mozilla.org/integration/autoland/rev/3f0758e1d897
part 3 - Rename XPTInterfaceDescriptor fields. r=njn
https://hg.mozilla.org/integration/autoland/rev/395189e8ad34
part 4 - Rename the one field of XPTTypeDescriptorPrefix. r=njn
https://hg.mozilla.org/integration/autoland/rev/de05343e7bd3
part 5 - Rename fields of XPTTypeDescriptor and XPTConstDescriptor. r=njn
https://hg.mozilla.org/integration/autoland/rev/be82df01da64
part 6 - Rename fields of XPTParamDescriptor. r=njn
https://hg.mozilla.org/integration/autoland/rev/4fdc36aa477a
part 7 - Rename fields of XPTMethodDescriptor. r=njn

Comment 25

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/e1641b8d914d
https://hg.mozilla.org/mozilla-central/rev/3e099aa442a9
https://hg.mozilla.org/mozilla-central/rev/3f0758e1d897
https://hg.mozilla.org/mozilla-central/rev/395189e8ad34
https://hg.mozilla.org/mozilla-central/rev/de05343e7bd3
https://hg.mozilla.org/mozilla-central/rev/be82df01da64
https://hg.mozilla.org/mozilla-central/rev/4fdc36aa477a