1444131 - bouncer check fails in 60.0b2 for apparently whitespace typo in partials provisioning

Status: RESOLVED FIXED

(Release Engineering :: Release Automation: Other, enhancement)

Description

[Mihai Tabara [:mtabara]⌚️GMT]

Bouncer-check fails but looking closer in the log[1] seems there's an issue with the partials provisioning in the script definition ...

      "cd /builds/worker/checkouts/gecko && ./mach python testing/mozharness/scripts/release/bouncer_check.py --version=60.0b2 --previous-version=60.0b1 \"--previous-version= 59.0b14\" \"--previous-version= 59.0b13\" --config releases/bouncer_firefox_devedition.py"

Investigating why that happened and foremost why didn't this occur in 60.0b1.

[1]: https://taskcluster-artifacts.net/YvvPFRq7Roq6E17FQx8UNg/0/public/logs/live_backing.log

Comment 1

[Rail Aliiev [:rail]]

Doh. The list of partials is separated by ", ", not ",". Just need to partial.strip() before https://dxr.mozilla.org/mozilla-central/rev/a6a32fb286fa9e5d5f6d5b3b77423ab6b96c9502/taskcluster/taskgraph/transforms/bouncer_check.py#46

Comment 2

[Mihai Tabara [:mtabara]⌚️GMT]

Yeah, seems like this[1] is where it is originally built that way.

[1]: https://hg.mozilla.org/releases/mozilla-beta/file/default/taskcluster/taskgraph/util/scriptworker.py#l426

Comment 3

[Mihai Tabara [:mtabara]⌚️GMT]

Attachment: Strip whitespaces in bouncer check partials processing transforms.

Bouncer-check failed yesterday for the 60.0b2 Devedition. The entries are correctly configured in bouncer but the version it's querying for are wrong, they contain an extra whitespace:

      "cd /builds/worker/checkouts/gecko && ... bouncer_check.py --version=60.0b2 --previous-version=60.0b1 \"--previous-version= 59.0b14\" \"--previous-version= 59.0b13\" ..."

We're grabbing the partials from the release runner, feed them via the action input and set them as environment variables here to be processed in transforms later on. 

* sample of action input is here[1]
* bouncer check is grabbing the initial list from env var here[2]
* bouncer check transforms use it currently here[3] and results in 

(Pdb) pp extra_params
[u'--previous-version=60.0b1',
 u'--previous-version= 59.0b14',
 u'--previous-version= 59.0b13']

This patch is do merely strip whitespace. I could have split by ", " as well but it's clearer this way. Especially since at some point we might change the joining method there in [2]. 

[1]: https://tools.taskcluster.net/groups/LzqauKoIQDyTx09WkHWO6g/tasks/JFxl2VVYQpiUeQBZ3mw8dQ/details
[2]: https://hg.mozilla.org/releases/mozilla-beta/file/default/taskcluster/taskgraph/util/scriptworker.py#l426 
[3]: https://hg.mozilla.org/releases/mozilla-beta/file/default/taskcluster/taskgraph/transforms/bouncer_check.py#l46

Comment 4

[Johan Lorenzo [:jlorenzo]]

Comment on attachment 8957507 [details] [diff] [review]
Strip whitespaces in bouncer check partials processing transforms.

Review of attachment 8957507 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM!

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/9967aedb77ba
Strip whitespaces in bouncer check partials processing transforms. r=jlorenzo

Comment 6

[Mihai Tabara [:mtabara]⌚️GMT]

Comment on attachment 8957507 [details] [diff] [review]
Strip whitespaces in bouncer check partials processing transforms.

https://hg.mozilla.org/integration/mozilla-inbound/rev/9967aedb77babcddcb06a518e030c83538127eb1

Sherrifs will close bug when migrate this over to central.

Comment 7

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/9967aedb77ba