1444354 - sdp_unit_tests NewSdpTest::GetGroups() fails intermittently with rust sdp parser

Status: RESOLVED FIXED

(Core :: WebRTC: Signaling, enhancement, P3)

Description

[Dan Minor [:dminor]]

This seems to be a problem only on Linux debug. I was unable to reproduce this locally, so I'm disabling the test for now until we have time to investigate this in more detail.

Comment 1

[Johannes Willbold]

Attachment: Fixing Bug 1444354: spd group parsing fails intermittently with rust parser

Ignore this commit, this is only here to place it on 'try'

Review commit: https://reviewboard.mozilla.org/r/254566/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/254566/

Comment 2

[Johannes Willbold]

Comment on attachment 8989545 [details]
Fixing Bug 1444354: spd group parsing fails intermittently with rust parser

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/254566/diff/1-2/

Comment 3

[Johannes Willbold]

Comment on attachment 8989545 [details]
Fixing Bug 1444354: spd group parsing fails intermittently with rust parser

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/254566/diff/2-3/

Comment 4

[Johannes Willbold]

Comment on attachment 8989545 [details]
Fixing Bug 1444354: spd group parsing fails intermittently with rust parser

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/254566/diff/3-4/

Comment 5

[Johannes Willbold]

Attachment: Bug 1444354: Fixed intermittent in RsdparsaSdpAttributeList::GetGroup,

Fixed the signature of the sdp_get_groups function in the C++/Rust glue code.

Review commit: https://reviewboard.mozilla.org/r/254780/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/254780/

Comment 6

[Dan Minor [:dminor]]

Comment on attachment 8989819 [details]
Bug 1444354: Fixed intermittent in RsdparsaSdpAttributeList::GetGroup,

https://reviewboard.mozilla.org/r/254780/#review262524

lgtm

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1444c96da345
Fixed intermittent in RsdparsaSdpAttributeList::GetGroup, r=dminor

Comment 8

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/1444c96da345