1444387 - Images briefly use fallback when they should not

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, enhancement, P1)

Description

[Andrew Osmond [:aosmond] (he/him)]

Images appear to be resorting to fallback when the image container is empty. This can happen easily when we are in the process of decoding an image, but we haven't produced a surface yet. Rather than just wait like it should, it ends up creating an image client and external image ID for no reason. Since we are racing against the decoder thread, it is also possible that it *does* get the complete image in the meantime, so it uploads a copy of the image using said image client.

Comment 1

[Andrew Osmond [:aosmond] (he/him)]

Attachment: 0001-Bug-1444387-Part-1.-Avoid-using-fallback-if-an-image.patch, v1

Comment 2

[Andrew Osmond [:aosmond] (he/him)]

Attachment: 0002-Bug-1444387-Part-2.-Ensure-we-use-NOT_READY-for-empt.patch, v1

try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=89212b258c91fa6bfed2bc27c6a2820a12dadbd0

Comment 3

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 8957543 [details] [diff] [review]
0001-Bug-1444387-Part-1.-Avoid-using-fallback-if-an-image.patch, v1

Review of attachment 8957543 [details] [diff] [review]:
-----------------------------------------------------------------

Maybe add a comment about why we're ignoring the return value?

Comment 4

[Andrew Osmond [:aosmond] (he/him)]

(In reply to Jeff Muizelaar [:jrmuizel] from comment #3)
> Comment on attachment 8957543 [details] [diff] [review]
> 0001-Bug-1444387-Part-1.-Avoid-using-fallback-if-an-image.patch, v1
> 
> Review of attachment 8957543 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Maybe add a comment about why we're ignoring the return value?

Will do before landing.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/68ab33989e63
Part 1. Avoid using fallback if an image is not ready. r=jrmuizel
https://hg.mozilla.org/integration/mozilla-inbound/rev/16155f54ef56
Part 2. Ensure we use NOT_READY for empty image containers with WebRender. r=jrmuizel

Comment 6

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/68ab33989e63
https://hg.mozilla.org/mozilla-central/rev/16155f54ef56