Closed Bug 1444429 Opened 2 years ago Closed 2 years ago

Add a mozconfig.lld-link similar to mozconfig.clang-cl

Categories

(Firefox Build System :: General, enhancement)

3 Branch
enhancement
Not set

Tracking

(firefox60 fixed)

RESOLVED FIXED
mozilla60
Tracking Status
firefox60 --- fixed

People

(Reporter: dmajor, Assigned: dmajor)

References

Details

Attachments

(1 file, 1 obsolete file)

This will make it easier for automation mozconfigs to request lld-link (with or without clang-cl), and it also provides a convenient one-liner to source in mozconfig.common.override for try pushes.
Attached patch mozconfiglld (obsolete) — Splinter Review
AR is only needed for ThinLTO builds, but it's fine to use regardless.
Assignee: nobody → dmajor
Attachment #8957589 - Flags: review?(nfroyd)
Comment on attachment 8957589 [details] [diff] [review]
mozconfiglld

My bin directory says there's no such thing as lld-lib. Did I mean llvm-lib? I pulled this out of an old try push... I wonder what's going wrong.
Attachment #8957589 - Flags: review?(nfroyd)
Attached patch mozconfiglldSplinter Review
How about we just set up the basic case and worry about lto later. Besides, we'll probably need to do something more complicated than my current approach of just stomping over ARFLAGS in configure.in anyway...
Attachment #8957589 - Attachment is obsolete: true
Attachment #8957593 - Flags: review?(nfroyd)
Comment on attachment 8957593 [details] [diff] [review]
mozconfiglld

Review of attachment 8957593 [details] [diff] [review]:
-----------------------------------------------------------------

Sure.  It'd be nice if we weren't adding $topsrcdir/clang/bin to the path multiple times, but I guess that is life.
Attachment #8957593 - Flags: review?(nfroyd) → review+
Pushed by dmajor@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d373ae68a011
Add a build/mozconfig.lld-link for automation. r=froydnj DONTBUILD
https://hg.mozilla.org/mozilla-central/rev/d373ae68a011
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
Version: Version 3 → 3 Branch
You need to log in before you can comment on or make changes to this bug.