1444432 - Capture profiler screenshots in CompositorOGL

Status: RESOLVED FIXED

(Core :: Graphics: Layers, enhancement)

Comment 1

[Markus Stange [:mstange]]

Attachment: Bug 1444432 - Create a currently-unimplemented abstraction called AsyncReadbackBuffer for the Compositor abstraction, and add a few more Compositor methods to aid in screenshotting.

Review commit: https://reviewboard.mozilla.org/r/231412/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/231412/

Comment 2

[Markus Stange [:mstange]]

Attachment: Bug 1444432 - Implement screenshot grabbing in LayerManagerComposite.

Review commit: https://reviewboard.mozilla.org/r/231414/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/231414/

Comment 3

[Markus Stange [:mstange]]

Attachment: Bug 1444432 - Create a Compositor abstraction called AsyncReadbackBuffer and implement it for CompositorOGL.

Review commit: https://reviewboard.mozilla.org/r/231416/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/231416/

Comment 4

[Markus Stange [:mstange]]

Comment on attachment 8962591 [details]
Bug 1444432 - Create a currently-unimplemented abstraction called AsyncReadbackBuffer for the Compositor abstraction, and add a few more Compositor methods to aid in screenshotting.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/231412/diff/1-2/

Comment 5

[Markus Stange [:mstange]]

Comment on attachment 8962592 [details]
Bug 1444432 - Implement screenshot grabbing in LayerManagerComposite.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/231414/diff/1-2/

Comment 6

[Markus Stange [:mstange]]

Comment on attachment 8962593 [details]
Bug 1444432 - Create a Compositor abstraction called AsyncReadbackBuffer and implement it for CompositorOGL.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/231416/diff/1-2/

Comment 7

[Markus Stange [:mstange]]

Attachment: Bug 1444432 - Create Compositor::BlitRenderTarget and implement it for CompositorOGL.

Review commit: https://reviewboard.mozilla.org/r/232264/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/232264/

Comment 8

[Markus Stange [:mstange]]

Attachment: Bug 1444432 - Add Compositor::GetWindowRenderTarget() and implement it for CompositorOGL.

Review commit: https://reviewboard.mozilla.org/r/232266/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/232266/

Comment 9

[Markus Stange [:mstange]]

Comment on attachment 8962593 [details]
Bug 1444432 - Create a Compositor abstraction called AsyncReadbackBuffer and implement it for CompositorOGL.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/231416/diff/2-3/

Comment 10

[Markus Stange [:mstange]]

Comment on attachment 8962592 [details]
Bug 1444432 - Implement screenshot grabbing in LayerManagerComposite.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/231414/diff/2-3/

Comment 11

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 8962593 [details]
Bug 1444432 - Create a Compositor abstraction called AsyncReadbackBuffer and implement it for CompositorOGL.

https://reviewboard.mozilla.org/r/231416/#review239786

Comment 12

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 8963358 [details]
Bug 1444432 - Create Compositor::BlitRenderTarget and implement it for CompositorOGL.

https://reviewboard.mozilla.org/r/232264/#review238096

::: gfx/layers/Compositor.h:289
(Diff revision 1)
> +   * Draw a part of aSource into the current render target.
> +   * Scaling is done with linear filtering.
> +   * Returns whether the operation was successful.
> +   */
> +  virtual bool
> +  BlitFromRenderTarget(CompositingRenderTarget* aSource,

I found the "From" in BlitFromRenderTarget a bit confusing for some reason. Perhaps BlitRenderTarget() would be better. I'm undecided.

Comment 13

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 8963359 [details]
Bug 1444432 - Add Compositor::GetWindowRenderTarget() and implement it for CompositorOGL.

https://reviewboard.mozilla.org/r/232266/#review239790

Comment 14

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 8962592 [details]
Bug 1444432 - Implement screenshot grabbing in LayerManagerComposite.

https://reviewboard.mozilla.org/r/231414/#review239854

Comment 15

[Markus Stange [:mstange]]

Comment on attachment 8962593 [details]
Bug 1444432 - Create a Compositor abstraction called AsyncReadbackBuffer and implement it for CompositorOGL.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/231416/diff/3-4/

Comment 16

[Markus Stange [:mstange]]

Comment on attachment 8963358 [details]
Bug 1444432 - Create Compositor::BlitRenderTarget and implement it for CompositorOGL.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/232264/diff/1-2/

Comment 17

[Markus Stange [:mstange]]

Comment on attachment 8963359 [details]
Bug 1444432 - Add Compositor::GetWindowRenderTarget() and implement it for CompositorOGL.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/232266/diff/1-2/

Comment 18

[Markus Stange [:mstange]]

Comment on attachment 8962592 [details]
Bug 1444432 - Implement screenshot grabbing in LayerManagerComposite.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/231414/diff/3-4/

Comment 19

[Markus Stange [:mstange]]

Attachment: Bug 1444432 - Add an #include "X11UndefineNone.h" to GLXLibrary.h after the X11 header include, so that TiledContentClient.h doesn't suffer from a redefined None.

Review commit: https://reviewboard.mozilla.org/r/236352/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/236352/

Comment 20

[Markus Stange [:mstange]]

Attachment: Bug 1444432 - Add missing gfx:: qualifiers in TextureClientOGL.cpp.

Review commit: https://reviewboard.mozilla.org/r/236354/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/236354/

Comment 21

[Markus Stange [:mstange]]

Comment on attachment 8962593 [details]
Bug 1444432 - Create a Compositor abstraction called AsyncReadbackBuffer and implement it for CompositorOGL.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/231416/diff/4-5/

Comment 22

[Markus Stange [:mstange]]

Comment on attachment 8963358 [details]
Bug 1444432 - Create Compositor::BlitRenderTarget and implement it for CompositorOGL.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/232264/diff/2-3/

Comment 23

[Markus Stange [:mstange]]

Comment on attachment 8963359 [details]
Bug 1444432 - Add Compositor::GetWindowRenderTarget() and implement it for CompositorOGL.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/232266/diff/2-3/

Comment 24

[Markus Stange [:mstange]]

Comment on attachment 8962592 [details]
Bug 1444432 - Implement screenshot grabbing in LayerManagerComposite.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/231414/diff/4-5/

Comment 25

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 8967635 [details]
Bug 1444432 - Add missing gfx:: qualifiers in TextureClientOGL.cpp.

https://reviewboard.mozilla.org/r/236354/#review242272

Comment 26

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 8967634 [details]
Bug 1444432 - Add an #include "X11UndefineNone.h" to GLXLibrary.h after the X11 header include, so that TiledContentClient.h doesn't suffer from a redefined None.

https://reviewboard.mozilla.org/r/236352/#review242274

Comment 27

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d45fcfb86c5d
Add an #include "X11UndefineNone.h" to GLXLibrary.h after the X11 header include, so that TiledContentClient.h doesn't suffer from a redefined None. r=jrmuizel
https://hg.mozilla.org/integration/autoland/rev/042910952b08
Add missing gfx:: qualifiers in TextureClientOGL.cpp. r=jrmuizel
https://hg.mozilla.org/integration/autoland/rev/e62656df7668
Create a Compositor abstraction called AsyncReadbackBuffer and implement it for CompositorOGL. r=jrmuizel
https://hg.mozilla.org/integration/autoland/rev/f43ff5e32642
Create Compositor::BlitRenderTarget and implement it for CompositorOGL. r=jrmuizel
https://hg.mozilla.org/integration/autoland/rev/a09b56d7916f
Add Compositor::GetWindowRenderTarget() and implement it for CompositorOGL. r=jrmuizel
https://hg.mozilla.org/integration/autoland/rev/0abeb9b30645
Implement screenshot grabbing in LayerManagerComposite. r=jrmuizel

Comment 28

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/d45fcfb86c5d
https://hg.mozilla.org/mozilla-central/rev/042910952b08
https://hg.mozilla.org/mozilla-central/rev/e62656df7668
https://hg.mozilla.org/mozilla-central/rev/f43ff5e32642
https://hg.mozilla.org/mozilla-central/rev/a09b56d7916f
https://hg.mozilla.org/mozilla-central/rev/0abeb9b30645