Closed
Bug 1444432
Opened 6 years ago
Closed 6 years ago
Capture profiler screenshots in CompositorOGL
Categories
(Core :: Graphics: Layers, enhancement)
Core
Graphics: Layers
Tracking
()
RESOLVED
FIXED
mozilla61
People
(Reporter: mstange, Assigned: mstange)
References
Details
Attachments
(6 files, 1 obsolete file)
|
59 bytes,
text/x-review-board-request
|
jrmuizel
:
review+
|
Details |
|
59 bytes,
text/x-review-board-request
|
jrmuizel
:
review+
|
Details |
|
59 bytes,
text/x-review-board-request
|
jrmuizel
:
review+
|
Details |
|
59 bytes,
text/x-review-board-request
|
jrmuizel
:
review+
|
Details |
|
59 bytes,
text/x-review-board-request
|
jrmuizel
:
review+
|
Details |
|
59 bytes,
text/x-review-board-request
|
jrmuizel
:
review+
|
Details |
No description provided.| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
|
Assignee | |
Updated•6 years ago
|
Attachment #8962591 -
Attachment is obsolete: true
Attachment #8962591 -
Flags: review?(jmuizelaar)
|
||
Comment 11•6 years ago
|
||
| mozreview-review | ||
Comment on attachment 8962593 [details] Bug 1444432 - Create a Compositor abstraction called AsyncReadbackBuffer and implement it for CompositorOGL. https://reviewboard.mozilla.org/r/231416/#review239786
Attachment #8962593 -
Flags: review?(jmuizelaar) → review+
|
|
||
Comment 12•6 years ago
|
||
| mozreview-review | ||
Comment on attachment 8963358 [details] Bug 1444432 - Create Compositor::BlitRenderTarget and implement it for CompositorOGL. https://reviewboard.mozilla.org/r/232264/#review238096 ::: gfx/layers/Compositor.h:289 (Diff revision 1) > + * Draw a part of aSource into the current render target. > + * Scaling is done with linear filtering. > + * Returns whether the operation was successful. > + */ > + virtual bool > + BlitFromRenderTarget(CompositingRenderTarget* aSource, I found the "From" in BlitFromRenderTarget a bit confusing for some reason. Perhaps BlitRenderTarget() would be better. I'm undecided.
Attachment #8963358 -
Flags: review?(jmuizelaar) → review+
|
|
||
Comment 13•6 years ago
|
||
| mozreview-review | ||
Comment on attachment 8963359 [details] Bug 1444432 - Add Compositor::GetWindowRenderTarget() and implement it for CompositorOGL. https://reviewboard.mozilla.org/r/232266/#review239790
Attachment #8963359 -
Flags: review?(jmuizelaar) → review+
|
|
||
Comment 14•6 years ago
|
||
| mozreview-review | ||
Comment on attachment 8962592 [details] Bug 1444432 - Implement screenshot grabbing in LayerManagerComposite. https://reviewboard.mozilla.org/r/231414/#review239854
Attachment #8962592 -
Flags: review?(jmuizelaar) → review+
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
|
|
||
Comment 25•6 years ago
|
||
| mozreview-review | ||
Comment on attachment 8967635 [details] Bug 1444432 - Add missing gfx:: qualifiers in TextureClientOGL.cpp. https://reviewboard.mozilla.org/r/236354/#review242272
Attachment #8967635 -
Flags: review?(jmuizelaar) → review+
|
|
||
Comment 26•6 years ago
|
||
| mozreview-review | ||
Comment on attachment 8967634 [details] Bug 1444432 - Add an #include "X11UndefineNone.h" to GLXLibrary.h after the X11 header include, so that TiledContentClient.h doesn't suffer from a redefined None. https://reviewboard.mozilla.org/r/236352/#review242274
Attachment #8967634 -
Flags: review?(jmuizelaar) → review+
|
||
Comment 27•6 years ago
|
||
Pushed by mstange@themasta.com: https://hg.mozilla.org/integration/autoland/rev/d45fcfb86c5d Add an #include "X11UndefineNone.h" to GLXLibrary.h after the X11 header include, so that TiledContentClient.h doesn't suffer from a redefined None. r=jrmuizel https://hg.mozilla.org/integration/autoland/rev/042910952b08 Add missing gfx:: qualifiers in TextureClientOGL.cpp. r=jrmuizel https://hg.mozilla.org/integration/autoland/rev/e62656df7668 Create a Compositor abstraction called AsyncReadbackBuffer and implement it for CompositorOGL. r=jrmuizel https://hg.mozilla.org/integration/autoland/rev/f43ff5e32642 Create Compositor::BlitRenderTarget and implement it for CompositorOGL. r=jrmuizel https://hg.mozilla.org/integration/autoland/rev/a09b56d7916f Add Compositor::GetWindowRenderTarget() and implement it for CompositorOGL. r=jrmuizel https://hg.mozilla.org/integration/autoland/rev/0abeb9b30645 Implement screenshot grabbing in LayerManagerComposite. r=jrmuizel
|
||
Comment 28•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/d45fcfb86c5d https://hg.mozilla.org/mozilla-central/rev/042910952b08 https://hg.mozilla.org/mozilla-central/rev/e62656df7668 https://hg.mozilla.org/mozilla-central/rev/f43ff5e32642 https://hg.mozilla.org/mozilla-central/rev/a09b56d7916f https://hg.mozilla.org/mozilla-central/rev/0abeb9b30645
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox61:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
|
||
Updated•6 years ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•