Closed Bug 1444436 Opened 7 years ago Closed 7 years ago

Remove unsafeSetInnerHTML in extensions.js

Categories

(Toolkit :: Add-ons Manager, enhancement)

Product:
Toolkit
Component:
Add-ons Manager
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla61
Tracking Flags:
Tracking Status
firefox61 --- fixed

People

(Reporter: johannh, Assigned: kmag)

References

Details

Attachments

(1 file)

Bug 1444436: Use DOM APIs rather than HTML string generation for GMP plugin descriptions.
59 bytes, text/x-review-board-request
aswan
: review+
Details
We're using unsafeSetInnerHTML to inject HTML for plugin descriptions in extensions.js: https://searchfox.org/mozilla-central/rev/588d8120aa11738657da93e09a03378bcd1ba8ec/toolkit/mozapps/extensions/content/extensions.js#2788 We should find a way to get rid of this.
Assignee: nobody → kmaglione+bmo
Comment on attachment 8959283 [details] Bug 1444436: Use DOM APIs rather than HTML string generation for GMP plugin descriptions. https://reviewboard.mozilla.org/r/228144/#review234056
Attachment #8959283 - Flags: review?(aswan) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/298eb1c03d635e70e77481def34cb2bb46cb7331 Bug 1444436: Use DOM APIs rather than HTML string generation for GMP plugin descriptions. r=aswan
https://hg.mozilla.org/mozilla-central/rev/298eb1c03d63
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox61: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
Flags: qe-verify-
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: