1444436 - Remove unsafeSetInnerHTML in extensions.js

Status: RESOLVED FIXED

(Toolkit :: Add-ons Manager, enhancement)

Description

[Johann Hofmann [:johannh]]

We're using unsafeSetInnerHTML to inject HTML for plugin descriptions in extensions.js:

https://searchfox.org/mozilla-central/rev/588d8120aa11738657da93e09a03378bcd1ba8ec/toolkit/mozapps/extensions/content/extensions.js#2788

We should find a way to get rid of this.

Comment 1

[Kris Maglione [:kmag]]

Attachment: Bug 1444436: Use DOM APIs rather than HTML string generation for GMP plugin descriptions.

Review commit: https://reviewboard.mozilla.org/r/228144/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/228144/

Comment 2

[Andrew Swan [:aswan]]

Comment on attachment 8959283 [details]
Bug 1444436: Use DOM APIs rather than HTML string generation for GMP plugin descriptions.

https://reviewboard.mozilla.org/r/228144/#review234056

Comment 3

[Kris Maglione [:kmag]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/298eb1c03d635e70e77481def34cb2bb46cb7331
Bug 1444436: Use DOM APIs rather than HTML string generation for GMP plugin descriptions. r=aswan

Comment 4

[Tiberius Oros[:tiberius_oros]]

https://hg.mozilla.org/mozilla-central/rev/298eb1c03d63