1444487 - Create new preference for whether langpacks must be signed

Status: VERIFIED FIXED

(Toolkit :: Add-ons Manager, defect, P1)

Description

[Andrew Swan [:aswan]]

For now this preference can be manually toggled and will default to false.  After other dependencies of the parent bug are addressed and QA has had a chance to test, we can lock this down further.

Comment 1

[Andrew Swan [:aswan]]

Attachment: Bug 1444487 Add preference for langpack signing

Review commit: https://reviewboard.mozilla.org/r/226544/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/226544/

Comment 2

[Kris Maglione [:kmag]]

Comment on attachment 8957643 [details]
Bug 1444487 Add preference for langpack signing

https://reviewboard.mozilla.org/r/226544/#review232428

Should really have a test for this...

Comment 3

[Andrew Swan [:aswan]]

Comment on attachment 8957643 [details]
Bug 1444487 Add preference for langpack signing

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/226544/diff/1-2/

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9ed7f3c8ad84
Add preference for langpack signing r=kmag

Comment 5

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/9ed7f3c8ad84

Comment 6

[Andrew Swan [:aswan]]

Comment on attachment 8957643 [details]
Bug 1444487 Add preference for langpack signing

Approval Request Comment
[Feature/Bug causing the regression]:
n/a, not a regression

[User impact if declined]:
no direct user impact, this is part of bug 1197876, it will allow QA to test signed language packs on beta.

[Is this code covered by automated tests?]:
yes

[Has the fix been verified in Nightly?]:
yes

[Needs manual test from QE? If yes, steps to reproduce]: 
this patch doesn't need additional manual testing but as mentioned above, it will be used to manually test browser behavior when language pack signing is required.

[List of other uplifts needed for the feature/fix]:
none

[Is the change risky?]:
not particularly

[Why is the change risky/not risky?]:
the change is small and between existing automated tests plus the new test added in the patch, the affected areas are well tested.

[String changes made/needed]:
none

Comment 7

[:shell escalante]

set to 60 fixed - since we are targeting 60 Beta.  This is to ride with ESR (which is why we want 60)

Comment 8

[Julien Cristau [:jcristau]]

Assuming you wanted affected rather than fixed since this isn't in 60 yet.

Comment 9

[Julien Cristau [:jcristau]]

Comment on attachment 8957643 [details]
Bug 1444487 Add preference for langpack signing

langpack signing support, for 60.0b4

Comment 10

[Dorel Luca [:dluca]]

https://hg.mozilla.org/releases/mozilla-beta/rev/aa5a03376bd2

Comment 11

[Andrei Vaida [:avaida]]

Setting qe-verify- on this bug since it has automated coverage and it does not need manual testing (per Comment 6).

Comment 12

[CosminB]

Attachment: Bug1444487.gif

This issue is verified as fixed on Firefox 61.0a1(20180316100132) and Firefox 60.0b4(20180315232954) under Windows 7 64-bit and Mac OS X 10.13.2.

The preference “extensions.langpacks.signatures.required” is set to false by default.

With the preference set to true or false only the signed langpacks can be installed in Fx61 or Fx60.

Unsigned langpacks can be installed only if the preference is set to false.

Please see the attached video.