1444491 - Consider updating to autofocus spec changes

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, enhancement, P3)

Description

[Boris Zbarsky [:bzbarsky]]

See https://github.com/whatwg/html/pull/3488 -- the updates spec queues a task on insertion and does all the other checks when the task runs.

That said, we might want to wait on https://github.com/whatwg/html/issues/3551 getting resolved one way or another.

Comment 1

[Sean Feng [:sefeng211]]

I am looking into this right now.

Comment 3

[Sean Feng [:sefeng211]]

Attachment: Bug 1444491 - Update the autofocus steps to align with the spec r=emilio,smaug

Spec: https://html.spec.whatwg.org/#the-autofocus-attribute

Comment 4

[Sean Feng [:sefeng211]]

Attachment: Bug 1444491 - Update the ini files for autofocus related WPTs r=emilio

Comment 5

[Sean Feng [:sefeng211]]

Attachment: Bug 1444491 - Update existing internal tests based on the autofocus algorithm updates r=emilio

These test behavior changes after the autofocus algorithm updates.

Comment 6

[Sean Feng [:sefeng211]]

Attachment: Bug 1444491 - Update existing autofocus related WPTs to make them more robust r=emilio

Comment 7

[Sean Feng [:sefeng211]]

Attachment: Bug 1444491 - Check the number of script blocking style sheets in autofocus algorithm r=smaug

Comment 8

[Sean Feng [:sefeng211]]

Attachment: Bug 1444491 - Init nsImageMap more eagerly r=emilio

Since we are initializing nsImageMap lazily, it's possible for area elements
stays non-focusable when autofocus code tries to focus it. So to fix
this, we need to ensure nsImageMap is initialized early enough.

Comment 9

[Sean Feng [:sefeng211]]

Attachment: Bug 1444491 - Factor out the get-the-focusable-area step from FlushAndCheckIfFocusable r=emilio,smaug

FlushAndCheckIfFocusable does a few things in the same function, however
I'd like to reuse the area and shadow dom checks from it for the
autofocus algorithm work. Generally they are useful for checking if a
non-focusable element can be focused.

Comment 10

[Phabricator Automation]

Comment on attachment 9314648 [details]
Bug 1444491 - Init nsImageMap more eagerly r=emilio

Revision D168166 was moved to bug 1815913. Setting attachment 9314648 [details] to obsolete.

Comment 11

[Phabricator Automation]

Comment on attachment 9315124 [details]
Bug 1444491 - Factor out the get-the-focusable-area step from FlushAndCheckIfFocusable r=emilio,smaug

Revision D168399 was moved to bug 1816002. Setting attachment 9315124 [details] to obsolete.

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7d8da1f44177
Update the autofocus steps to align with the spec r=emilio,smaug
https://hg.mozilla.org/integration/autoland/rev/80010eabc0c1
Update the ini files for autofocus related WPTs r=emilio
https://hg.mozilla.org/integration/autoland/rev/94aa0ce630f2
Update existing internal tests based on the autofocus algorithm updates r=emilio
https://hg.mozilla.org/integration/autoland/rev/64c8bb293e5c
Update existing autofocus related WPTs to make them more robust r=emilio
https://hg.mozilla.org/integration/autoland/rev/30f786b79191
Check the number of script blocking style sheets in autofocus algorithm r=hsivonen
https://hg.mozilla.org/integration/autoland/rev/1cee414009cb
1801761: apply code formatting via Lando

Comment 13

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/38517 for changes under testing/web-platform/tests

Comment 14

[Natalia Csoregi [:nataliaCs]]

Backed out along with Bug 1801761 for causing failures on autofocus-attribute.svg

• backout: https://hg.mozilla.org/integration/autoland/rev/7c9d11c84ac7a77507e4f8b7d136da56227e7ca3
• push (did not have any jobs due to bustages): https://treeherder.mozilla.org/jobs?repo=autoland&collapsedPushes=1189919&group_state=expanded&selectedTaskRun=YL3hLDr-T-SKEumJLgV_og.0&revision=1cee414009cb12b0850d7ae0ce2aa1b7dc51c24d
• push with fail occurrences: https://treeherder.mozilla.org/jobs?repo=autoland&collapsedPushes=1189919&group_state=expanded&selectedTaskRun=YL3hLDr-T-SKEumJLgV_og.0&revision=1d5957cb0ce57ae244af9c4ef74fcefc094dd0ff&searchStr=wpt
• failure log: https://treeherder.mozilla.org/logviewer?job_id=405749283&repo=autoland&lineNumber=4241

[task 2023-02-15T16:22:52.544Z] 16:22:52     INFO - TEST-PASS | /svg/coordinate-systems/outer-svg-intrinsic-size-002.html | modifiying specified viewBox, in presence of specified height 
[task 2023-02-15T16:22:52.544Z] 16:22:52     INFO - TEST-FAIL | /svg/coordinate-systems/svgtransformlist-replaceitem.html | Dynamic update of transform; replaceItem() - assert_equals: expected 185.08372497558594 but got 185
[task 2023-02-15T16:22:52.544Z] 16:22:52     INFO - @http://web-platform.test:8000/svg/coordinate-systems/svgtransformlist-replaceitem.html:26:16
[task 2023-02-15T16:22:52.544Z] 16:22:52     INFO - Test.prototype.step@http://web-platform.test:8000/resources/testharness.js:2591:25
[task 2023-02-15T16:22:52.544Z] 16:22:52     INFO - test@http://web-platform.test:8000/resources/testharness.js:628:30
[task 2023-02-15T16:22:52.544Z] 16:22:52     INFO - @http://web-platform.test:8000/svg/coordinate-systems/svgtransformlist-replaceitem.html:15:5
[task 2023-02-15T16:22:52.544Z] 16:22:52     INFO - TEST-UNEXPECTED-PASS | /svg/struct/scripted/autofocus-attribute.svg | <a> should support autofocus - expected FAIL
[task 2023-02-15T16:22:52.544Z] 16:22:52     INFO - TEST-INFO | expected FAIL
[task 2023-02-15T16:22:52.545Z] 16:22:52     INFO - 
[task 2023-02-15T16:22:52.545Z] 16:22:52     INFO - TEST-UNEXPECTED-PASS | /svg/struct/scripted/autofocus-attribute.svg | Renderable element with tabindex should support autofocus - expected FAIL
[task 2023-02-15T16:22:52.545Z] 16:22:52     INFO - TEST-INFO | expected FAIL
[task 2023-02-15T16:22:52.615Z] 16:22:52     INFO - TEST-OK | /svg/struct/scripted/autofocus-attribute.svg | took 1387ms

Comment 15

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR was closed without merging

Comment 16

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/16afbf1210b3
Update the autofocus steps to align with the spec r=emilio,smaug
https://hg.mozilla.org/integration/autoland/rev/9deb296222f0
Update the ini files for autofocus related WPTs r=emilio
https://hg.mozilla.org/integration/autoland/rev/6fc833b7bf5c
Update existing internal tests based on the autofocus algorithm updates r=emilio
https://hg.mozilla.org/integration/autoland/rev/e7cfa964b690
Update existing autofocus related WPTs to make them more robust r=emilio
https://hg.mozilla.org/integration/autoland/rev/d4ebe6d8a638
Check the number of script blocking style sheets in autofocus algorithm r=hsivonen
https://hg.mozilla.org/integration/autoland/rev/aad1e7be0182
1801761: apply code formatting via Lando

Comment 17

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/16afbf1210b3
https://hg.mozilla.org/mozilla-central/rev/9deb296222f0
https://hg.mozilla.org/mozilla-central/rev/6fc833b7bf5c
https://hg.mozilla.org/mozilla-central/rev/e7cfa964b690
https://hg.mozilla.org/mozilla-central/rev/d4ebe6d8a638
https://hg.mozilla.org/mozilla-central/rev/aad1e7be0182

Comment 18

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot

Comment 19

[Andra Esanu (needinfo me)]

(In reply to Pulsebot from comment #16)

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/16afbf1210b3
Update the autofocus steps to align with the spec r=emilio,smaug
https://hg.mozilla.org/integration/autoland/rev/9deb296222f0
Update the ini files for autofocus related WPTs r=emilio
https://hg.mozilla.org/integration/autoland/rev/6fc833b7bf5c
Update existing internal tests based on the autofocus algorithm updates
r=emilio
https://hg.mozilla.org/integration/autoland/rev/e7cfa964b690
Update existing autofocus related WPTs to make them more robust r=emilio
https://hg.mozilla.org/integration/autoland/rev/d4ebe6d8a638
Check the number of script blocking style sheets in autofocus algorithm
r=hsivonen
https://hg.mozilla.org/integration/autoland/rev/aad1e7be0182
1801761: apply code formatting via Lando

== Change summary for alert #37249 (as of Tue, 21 Feb 2023 05:52:44 GMT) ==

Improvements:

Ratio	Test	Platform	Options	Absolute values (old vs new)	Performance Profiles
3%	speedometer3	windows10-64-shippable-qr	fission webrender	130.10 -> 133.63	Before/After
3%	speedometer3	windows10-64-shippable-qr	fission webrender	130.30 -> 133.70	Before/After

For up to date results, see: https://treeherder.mozilla.org/perfherder/alerts?id=37249

Comment 20

[Andra Esanu (needinfo me)]

(In reply to Natalia Csoregi [:nataliaCs] from comment #14)

Backed out along with Bug 1801761 for causing failures on autofocus-attribute.svg

• backout: https://hg.mozilla.org/integration/autoland/rev/7c9d11c84ac7a77507e4f8b7d136da56227e7ca3
• push (did not have any jobs due to bustages): https://treeherder.mozilla.org/jobs?repo=autoland&collapsedPushes=1189919&group_state=expanded&selectedTaskRun=YL3hLDr-T-SKEumJLgV_og.0&revision=1cee414009cb12b0850d7ae0ce2aa1b7dc51c24d
• push with fail occurrences: https://treeherder.mozilla.org/jobs?repo=autoland&collapsedPushes=1189919&group_state=expanded&selectedTaskRun=YL3hLDr-T-SKEumJLgV_og.0&revision=1d5957cb0ce57ae244af9c4ef74fcefc094dd0ff&searchStr=wpt
• failure log: https://treeherder.mozilla.org/logviewer?job_id=405749283&repo=autoland&lineNumber=4241

[task 2023-02-15T16:22:52.544Z] 16:22:52     INFO - TEST-PASS | /svg/coordinate-systems/outer-svg-intrinsic-size-002.html | modifiying specified viewBox, in presence of specified height 
[task 2023-02-15T16:22:52.544Z] 16:22:52     INFO - TEST-FAIL | /svg/coordinate-systems/svgtransformlist-replaceitem.html | Dynamic update of transform; replaceItem() - assert_equals: expected 185.08372497558594 but got 185
[task 2023-02-15T16:22:52.544Z] 16:22:52     INFO - @http://web-platform.test:8000/svg/coordinate-systems/svgtransformlist-replaceitem.html:26:16
[task 2023-02-15T16:22:52.544Z] 16:22:52     INFO - Test.prototype.step@http://web-platform.test:8000/resources/testharness.js:2591:25
[task 2023-02-15T16:22:52.544Z] 16:22:52     INFO - test@http://web-platform.test:8000/resources/testharness.js:628:30
[task 2023-02-15T16:22:52.544Z] 16:22:52     INFO - @http://web-platform.test:8000/svg/coordinate-systems/svgtransformlist-replaceitem.html:15:5
[task 2023-02-15T16:22:52.544Z] 16:22:52     INFO - TEST-UNEXPECTED-PASS | /svg/struct/scripted/autofocus-attribute.svg | <a> should support autofocus - expected FAIL
[task 2023-02-15T16:22:52.544Z] 16:22:52     INFO - TEST-INFO | expected FAIL
[task 2023-02-15T16:22:52.545Z] 16:22:52     INFO - 
[task 2023-02-15T16:22:52.545Z] 16:22:52     INFO - TEST-UNEXPECTED-PASS | /svg/struct/scripted/autofocus-attribute.svg | Renderable element with tabindex should support autofocus - expected FAIL
[task 2023-02-15T16:22:52.545Z] 16:22:52     INFO - TEST-INFO | expected FAIL
[task 2023-02-15T16:22:52.615Z] 16:22:52     INFO - TEST-OK | /svg/struct/scripted/autofocus-attribute.svg | took 1387ms

== Change summary for alert #37268 (as of Wed, 22 Feb 2023 05:49:52 GMT) ==

Regressions:

Ratio	Test	Platform	Options	Absolute values (old vs new)
3%	speedometer	windows10-64-shippable-qr	fission webrender	130.10 -> 126.22

Improvements:

Ratio	Test	Platform	Options	Absolute values (old vs new)
3%	speedometer	windows10-64-shippable-qr	fission webrender	126.49 -> 129.66

For up to date results, see: https://treeherder.mozilla.org/perfherder/alerts?id=37268