1444519 - media/libcubeb/src/cubeb_pulse.c ignores many PulseAudio errors

Status: RESOLVED WORKSFORME

(Core :: Audio/Video: cubeb, defect, P3)

Description

[oxij]

Attachment: A small fix for one such return code

In media/libcubeb/src/cubeb_pulse.c many calls to PA API never check return codes. I discovered this while I was debugging why Firefox crashes with my "superior reimplementation" of libpulse API (https://github.com/oxij/libcardiacarrest).

Newer code tied to Rust does check those error codes.

The fix I needed for my use case is attached. I made a workaround for this anyway, so you may completely ignore this. But if you look at PA API documentation, you'll notice that not only cubeb_pulse.c ignores some PA errors, it is not entirely clear whenever all of the uses of PA API in cubeb_pulse.c are even correct. For instance, is it ok to `drain` the `pa_context` before it successfully connected to the PA daemon? I'm not sure. cubeb_pulse.c `drain`s it anyway.

Comment 1

[Nils Ohlmeier [:drno]]

Alex, can I ask you to take a look if want to merge this contribution?

Comment 2

[Alex Chronopoulos [:achronop]]

Thank you for the patch. It's true we could be better in error checking. In order to patch libcubeb you should create a PR request against the upstream github repository (https://github.com/kinetiknz/cubeb). Every so often we import all latest changes of that repository into gecko. Can you transfer your patch into a PR against that repo? If not, let me know and I will do it for you.

Comment 3

[oxij]

Done. https://github.com/kinetiknz/cubeb/pull/425

Comment 4

[oxij]

This was fixed since.