Set --tab-min-width in the tabs binding rather than gBrowser.init

RESOLVED FIXED in Firefox 60

Status

()

enhancement
RESOLVED FIXED
Last year
Last year

People

(Reporter: dao, Assigned: dao)

Tracking

Trunk
Firefox 60
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox60 fixed)

Details

Attachments

(1 attachment)

No description provided.
Comment on attachment 8957695 [details]
Bug 1444530 - Set --tab-min-width in the tabs binding rather than gBrowser.init.

https://reviewboard.mozilla.org/r/226622/#review232482

r=me with the 'readonly' bit removed.

::: browser/base/content/tabbrowser.xml:184
(Diff revision 1)
>          <getter>
>            return window.gBrowser;
>          </getter>
>        </property>
>  
> +      <property name="_tabMinWidth" readonly="true">

You're defining a readonly property that then only has a setter? That's, uh, interesting. I assume not intended?
Attachment #8957695 - Flags: review?(gijskruitbosch+bugs) → review+
(In reply to :Gijs (under the weather; responses will be slow) from comment #2)
> > +      <property name="_tabMinWidth" readonly="true">
> 
> You're defining a readonly property that then only has a setter? That's, uh,
> interesting. I assume not intended?

Weird, I swear I built this and it worked...
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c97c9a7a66da
Set --tab-min-width in the tabs binding rather than gBrowser.init. r=Gijs
(In reply to Dão Gottwald [::dao] from comment #3)
> (In reply to :Gijs (under the weather; responses will be slow) from comment
> #2)
> > > +      <property name="_tabMinWidth" readonly="true">
> > 
> > You're defining a readonly property that then only has a setter? That's, uh,
> > interesting. I assume not intended?
> 
> Weird, I swear I built this and it worked...

Oh, I wouldn't be surprised if it did - it just looks odd and like it ought not to work.
https://hg.mozilla.org/mozilla-central/rev/c97c9a7a66da
Status: ASSIGNED → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → Firefox 60
You need to log in before you can comment on or make changes to this bug.