Closed Bug 1444539 Opened 2 years ago Closed 2 years ago

Response filters should not persist across redirects

Categories

(WebExtensions :: Request Handling, enhancement)

enhancement
Not set

Tracking

(firefox60 fixed)

RESOLVED FIXED
mozilla60
Tracking Status
firefox60 --- fixed

People

(Reporter: kmag, Assigned: kmag)

Details

Attachments

(1 file)

Currently, response filters registered for a request during one phase of the request persist across redirects, making it possible for several filters to unexpectedly stack. We should disconnect filters whenever a channel redirects, and notify extensions via their error listeners.
Comment on attachment 8957729 [details]
Bug 1444539: Disconnect StreamFilters on redirect.

https://reviewboard.mozilla.org/r/226682/#review232504
Attachment #8957729 - Flags: review?(mixedpuppy) → review+
https://hg.mozilla.org/mozilla-central/rev/a97bab3e3c90
https://hg.mozilla.org/mozilla-central/rev/1976ff94b12a
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
Is manual testing required on this bug? If Yes, please provide some STR and the proper webextension(if required), if No set the “qe-verify-“ flag.
Flags: needinfo?(kmaglione+bmo)
Probably not. Tests should be enough.
Flags: needinfo?(kmaglione+bmo) → qe-verify-
Product: Toolkit → WebExtensions
You need to log in before you can comment on or make changes to this bug.