Closed
Bug 1444539
Opened 6 years ago
Closed 6 years ago
Response filters should not persist across redirects
Categories
(WebExtensions :: Request Handling, enhancement)
WebExtensions
Request Handling
Tracking
(firefox60 fixed)
RESOLVED
FIXED
mozilla60
Tracking | Status | |
---|---|---|
firefox60 | --- | fixed |
People
(Reporter: kmag, Assigned: kmag)
Details
Attachments
(1 file)
Currently, response filters registered for a request during one phase of the request persist across redirects, making it possible for several filters to unexpectedly stack. We should disconnect filters whenever a channel redirects, and notify extensions via their error listeners.
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment 3•6 years ago
|
||
mozreview-review |
Comment on attachment 8957729 [details] Bug 1444539: Disconnect StreamFilters on redirect. https://reviewboard.mozilla.org/r/226682/#review232504
Attachment #8957729 -
Flags: review?(mixedpuppy) → review+
Assignee | ||
Comment 4•6 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/a97bab3e3c901e13d2b1cd0c0a4fa12f1b941d8c Bug 1444539: Disconnect StreamFilters on redirect. r=mixedpuppy
Assignee | ||
Comment 5•6 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/1976ff94b12a14e32cac357c1ef2cf7caca8ff7e Bug 1444539: Follow-up: Remove errant debugging code. DONTBUILD
Comment 6•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/a97bab3e3c90 https://hg.mozilla.org/mozilla-central/rev/1976ff94b12a
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox60:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
Comment 7•6 years ago
|
||
Is manual testing required on this bug? If Yes, please provide some STR and the proper webextension(if required), if No set the “qe-verify-“ flag.
Flags: needinfo?(kmaglione+bmo)
Assignee | ||
Comment 8•6 years ago
|
||
Probably not. Tests should be enough.
Flags: needinfo?(kmaglione+bmo) → qe-verify-
Updated•6 years ago
|
Product: Toolkit → WebExtensions
You need to log in
before you can comment on or make changes to this bug.
Description
•