Closed Bug 1444539 Opened 2 years ago Closed 2 years ago
Response filters should not persist across redirects
59 bytes, text/x-review-board-request
Currently, response filters registered for a request during one phase of the request persist across redirects, making it possible for several filters to unexpectedly stack. We should disconnect filters whenever a channel redirects, and notify extensions via their error listeners.
Comment on attachment 8957729 [details] Bug 1444539: Disconnect StreamFilters on redirect. https://reviewboard.mozilla.org/r/226682/#review232504
Attachment #8957729 - Flags: review?(mixedpuppy) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/a97bab3e3c901e13d2b1cd0c0a4fa12f1b941d8c Bug 1444539: Disconnect StreamFilters on redirect. r=mixedpuppy
https://hg.mozilla.org/integration/mozilla-inbound/rev/1976ff94b12a14e32cac357c1ef2cf7caca8ff7e Bug 1444539: Follow-up: Remove errant debugging code. DONTBUILD
Is manual testing required on this bug? If Yes, please provide some STR and the proper webextension(if required), if No set the “qe-verify-“ flag.
Probably not. Tests should be enough.
Flags: needinfo?(kmaglione+bmo) → qe-verify-
You need to log in before you can comment on or make changes to this bug.