1444580 - More nsIDocument devirtualization.

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, enhancement)

Comment 1

[Phabricator Automation]

Attachment: Bug 1444580: Devirtualize more nsIDocument bits. r=smaug

Comment 2

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1444580: Devirtualize more nsIDocument bits.

Summary:
Sorry for this ending up being a little big, I can split if needed.

Though hopefully should be straight-forward.

Reviewers: smaug

Bug #: 1444580

Differential Revision: https://phabricator.services.mozilla.com/D700

Review commit: https://reviewboard.mozilla.org/r/226754/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/226754/

Comment 3

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1444580: Devirtualize autofocus and navigation timing stuff.

Review commit: https://reviewboard.mozilla.org/r/226756/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/226756/

Comment 4

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1444580: Devirtualize PaymentRequest stuff.

This one was easy, the bit was already in the right place :)

Review commit: https://reviewboard.mozilla.org/r/226758/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/226758/

Comment 5

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1444580: Devirtualize IsScriptEnabled.

Review commit: https://reviewboard.mozilla.org/r/226760/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/226760/

Comment 6

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1444580: Devirtualize a few other things.

SetScriptHandlingObject / GetScopeObject / GetWindowInternal /
GetScriptHandlingObjectInternal / GetScriptHandlingObject

Review commit: https://reviewboard.mozilla.org/r/226762/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/226762/

Comment 7

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1444580: Devirtualize the IntersectionObserver bits.

Review commit: https://reviewboard.mozilla.org/r/226764/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/226764/

Comment 8

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1444580: Mark nsIDocument::Dispatch final.

Review commit: https://reviewboard.mozilla.org/r/226766/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/226766/

Comment 9

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1444580: Devirtualize the visibility state stuff.

Also rename GetVisibilityState to ComputeVisibilityState, since that's what it
does, the getter is VisibilityState.

Review commit: https://reviewboard.mozilla.org/r/226768/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/226768/

Comment 10

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1444580: Devirtualize the fullscreen stuff.

Review commit: https://reviewboard.mozilla.org/r/226770/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/226770/

Comment 11

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1444580: Devirtualize GetImplementation.

Review commit: https://reviewboard.mozilla.org/r/226772/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/226772/

Comment 12

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1444580: Mark JS::Value as opaque instead of hidden.

The next commit will move js::ExpandoAndGeneration (which contains a JS::Value)
into nsIDocument instead of nsDocument, so it needs to be defined.

I plan to land this after
https://github.com/rust-lang-nursery/rust-bindgen/pull/1271, so it shouldn't
break anything.

Review commit: https://reviewboard.mozilla.org/r/226774/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/226774/

Comment 13

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1444580: Devirtualize the IdentifierMap stuff.

Review commit: https://reviewboard.mozilla.org/r/226776/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/226776/

Comment 14

[Emilio Cobos Álvarez [:emilio]]

Comment on attachment 8957771 [details]
Bug 1444580: Devirtualize more nsIDocument bits. r=smaug

Submitting multiple patches with Phabricator is a pain.

Comment 15

[Xidorn Quan [:xidorn] UTC+10]

Comment on attachment 8957784 [details]
Bug 1444580: Mark JS::Value as opaque instead of hidden.

https://reviewboard.mozilla.org/r/226774/#review232534

Comment 16

[Emilio Cobos Álvarez [:emilio]]

Arg, mozreview is choking hard at trying to push all the extra patches I have... Will upload the rest manually...

Comment 17

[Emilio Cobos Álvarez [:emilio]]

Attachment: CreateElement / CreateElementNS.

Comment 18

[Emilio Cobos Álvarez [:emilio]]

Attachment: FindImageMap

Comment 19

[Emilio Cobos Álvarez [:emilio]]

Attachment: The responsive content stuff.

Comment 20

[Emilio Cobos Álvarez [:emilio]]

Attachment: GetStateObject

Comment 21

[Emilio Cobos Álvarez [:emilio]]

Attachment: NotifyLayerManagerRecreated

Comment 22

[Emilio Cobos Álvarez [:emilio]]

Attachment: Subdocument stuff.

Comment 23

[Emilio Cobos Álvarez [:emilio]]

Attachment: GetRootElementInternal (plus moving nsINode overrides to nsIDocument)

Comment 24

[Emilio Cobos Álvarez [:emilio]]

Attachment: Plugins stuff.

Comment 25

[Emilio Cobos Álvarez [:emilio]]

Attachment: Web Animations stuff.

Comment 26

[Emilio Cobos Álvarez [:emilio]]

Attachment: ScriptLoader

Comment 27

[Emilio Cobos Álvarez [:emilio]]

Attachment: Scroll to ref stuff.

Comment 28

[Emilio Cobos Álvarez [:emilio]]

Attachment: GetCurrentContentSink

Comment 29

[Emilio Cobos Álvarez [:emilio]]

Attachment: Preload / preconnect stuff.

Comment 30

[Emilio Cobos Álvarez [:emilio]]

Attachment: GetBoxObjectFor / ClearBoxObjectFor.

Comment 31

[Emilio Cobos Álvarez [:emilio]]

Attachment: GetAnonymousElementByAttribute

Comment 32

[Emilio Cobos Álvarez [:emilio]]

Attachment: More animation stuff.

Comment 33

[Emilio Cobos Álvarez [:emilio]]

Attachment: Event handling suppression stuff.

Comment 34

[Emilio Cobos Álvarez [:emilio]]

Attachment: GetTemplateContentsOwner.

Comment 35

[Emilio Cobos Álvarez [:emilio]]

Attachment: External resource load stuff.

This one was the most non-trivial I'd say.

Comment 36

[Emilio Cobos Álvarez [:emilio]]

Attachment: Pointer lock / screen orientation stuff.

Comment 37

[Emilio Cobos Álvarez [:emilio]]

Attachment: GetChannel

Comment 38

[Emilio Cobos Álvarez [:emilio]]

Attachment: CreateShell / DeleteShell.

Comment 39

[Emilio Cobos Álvarez [:emilio]]

Attachment: Move OnPageShow / OnPageHide to nsIDocument, and devirtualize OnPageShow

Comment 40

[Emilio Cobos Álvarez [:emilio]]

Attachment: NodesFromRectHelper.

Comment 41

[Emilio Cobos Álvarez [:emilio]]

Attachment: FlushSkinBindings.

Comment 42

[Emilio Cobos Álvarez [:emilio]]

Attachment: Frame loader stuff.

Comment 43

[Emilio Cobos Álvarez [:emilio]]

Attachment: UnblockDOMContentLoaded.

Comment 44

[Emilio Cobos Álvarez [:emilio]]

Attachment: Remove reference to non-existing function.

Comment 45

[Emilio Cobos Álvarez [:emilio]]

Attachment: Mutation event stuff.

Comment 46

[Emilio Cobos Álvarez [:emilio]]

Attachment: GetLayoutHistoryState

Comment 47

[Emilio Cobos Álvarez [:emilio]]

Attachment: Sanitize

Comment 48

[Emilio Cobos Álvarez [:emilio]]

Attachment: Move CanHavePresentation to nsIDocument.

Can't devirtualize because of PluginDocument. oh well.

Comment 49

[Emilio Cobos Álvarez [:emilio]]

Attachment: Move mExpandoAndGeneration back to nsDocument for now.

See the comment for why, otherwise we fail the rust unit tests in x32, and I can't land https://github.com/rust-lang-nursery/rust-bindgen/pull/1271 in Gecko until we require Rust 1.25, which is the next stable version.

Comment 50

[Olli Pettay [:smaug][[e-mail]]]

Since reviewing this kind of patches requires heavy searchfox usage, it isn't quite as fast as one
might expect. But I'll try to get to these real soon.

Comment 51

[Emilio Cobos Álvarez [:emilio]]

(In reply to Olli Pettay [:smaug] from comment #50)
> Since reviewing this kind of patches requires heavy searchfox usage, it
> isn't quite as fast as one
> might expect. But I'll try to get to these real soon.

Yeah, that sounds great, thanks Olli! :)

Comment 52

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8957774 [details]
Bug 1444580: Devirtualize more nsIDocument bits.

https://reviewboard.mozilla.org/r/226754/#review232678

::: commit-message-b24d0:4
(Diff revision 1)
> +Bug 1444580: Devirtualize more nsIDocument bits. r=smaug
> +
> +Summary:
> +Sorry for this ending up being a little big, I can split if needed.

this kind of comment shouldn't be in commit message

Comment 53

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8957775 [details]
Bug 1444580: Devirtualize autofocus and navigation timing stuff.

https://reviewboard.mozilla.org/r/226756/#review232680

Comment 54

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8957776 [details]
Bug 1444580: Devirtualize PaymentRequest stuff.

https://reviewboard.mozilla.org/r/226758/#review232682

Comment 55

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8957777 [details]
Bug 1444580: Devirtualize IsScriptEnabled.

https://reviewboard.mozilla.org/r/226760/#review232686

Comment 56

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8957778 [details]
Bug 1444580: Devirtualize a few other things.

https://reviewboard.mozilla.org/r/226762/#review232688

Comment 57

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8957779 [details]
Bug 1444580: Devirtualize the IntersectionObserver bits.

https://reviewboard.mozilla.org/r/226764/#review232690

Comment 58

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8957780 [details]
Bug 1444580: Mark nsIDocument::Dispatch final.

https://reviewboard.mozilla.org/r/226766/#review232692

Comment 59

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8957781 [details]
Bug 1444580: Devirtualize the visibility state stuff.

https://reviewboard.mozilla.org/r/226768/#review232694

Comment 60

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8957782 [details]
Bug 1444580: Devirtualize the fullscreen stuff.

https://reviewboard.mozilla.org/r/226770/#review232696

Comment 61

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8957783 [details]
Bug 1444580: Devirtualize GetImplementation.

https://reviewboard.mozilla.org/r/226772/#review232698

Comment 62

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8957785 [details]
Bug 1444580: Devirtualize the IdentifierMap stuff.

https://reviewboard.mozilla.org/r/226776/#review232700

::: dom/base/nsIDocument.h:9
(Diff revision 1)
>   * License, v. 2.0. If a copy of the MPL was not distributed with this
>   * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
>  #ifndef nsIDocument_h___
>  #define nsIDocument_h___
>  
> +#include "jsfriendapi.h"

This is quite unfortunate.

Comment 63

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8957914 [details] [diff] [review]
The responsive content stuff.

aha, this has plenty of unrelated changes too. But fine.

Comment 64

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8957915 [details] [diff] [review]
GetStateObject

Includes a mysterious newline deletion, but fine.

Comment 65

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8957944 [details] [diff] [review]
Move CanHavePresentation to nsIDocument.

ok, CanSavePresentation stays still virtual.

This does move also Contains*Content, apparently because nsIDocument::CanSavePresentation uses them.

Comment 66

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8957961 [details] [diff] [review]
Move mExpandoAndGeneration back to nsDocument for now.

>+static void
>+IncrementExpandoGeneration(nsIDocument& doc)
aDoc

Comment 67

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8957961 [details] [diff] [review]
Move mExpandoAndGeneration back to nsDocument for now.

With this patch, could we not have #include "jsfriendapi.h" in nsIDocument.h ?

Comment 68

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8957935 [details] [diff] [review]
Move OnPageShow / OnPageHide to nsIDocument, and devirtualize OnPageShow

ok, OnPageShow is still virtual because ImageDocument overrides it.
So the commit message is a tad wrong.

Comment 69

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8957931 [details] [diff] [review]
External resource load stuff.

So nsSubDocEnumFunc is defined now twice, in different classes. I guess that is fine.

Comment 70

[Emilio Cobos Álvarez [:emilio]]

(In reply to Olli Pettay [:smaug] from comment #67)
> Comment on attachment 8957961 [details] [diff] [review]
> Move mExpandoAndGeneration back to nsDocument for now.
> 
> With this patch, could we not have #include "jsfriendapi.h" in nsIDocument.h
> ?

Yes, move that include back to nsDocument.h

Comment 71

[Emilio Cobos Álvarez [:emilio]]

*I'll move that

Comment 72

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d9a86837189b
Devirtualize more nsIDocument bits. r=smaug
https://hg.mozilla.org/integration/mozilla-inbound/rev/b6e079d22001
Devirtualize autofocus and navigation timing stuff. r=smaug
https://hg.mozilla.org/integration/mozilla-inbound/rev/9f04d67a53d8
Devirtualize PaymentRequest stuff. r=smaug
https://hg.mozilla.org/integration/mozilla-inbound/rev/a9fbfa2fc6ef
Devirtualize IsScriptEnabled. r=smaug
https://hg.mozilla.org/integration/mozilla-inbound/rev/63372eeecb17
Devirtualize a few other things. r=smaug
https://hg.mozilla.org/integration/mozilla-inbound/rev/0d36b03f0bc4
Devirtualize the IntersectionObserver bits. r=smaug
https://hg.mozilla.org/integration/mozilla-inbound/rev/d616bcc96e36
Mark nsIDocument::Dispatch final. r=smaug
https://hg.mozilla.org/integration/mozilla-inbound/rev/8edab3c72a62
Devirtualize the visibility state stuff. r=smaug
https://hg.mozilla.org/integration/mozilla-inbound/rev/5abd81195c99
Devirtualize the fullscreen stuff. r=smaug
https://hg.mozilla.org/integration/mozilla-inbound/rev/e654cbd9fd4b
Devirtualize GetImplementation. r=smaug
https://hg.mozilla.org/integration/mozilla-inbound/rev/7f532b7d5997
Devirtualize the IdentifierMap stuff. r=smaug
https://hg.mozilla.org/integration/mozilla-inbound/rev/0ec71c2eb977
Devirtualize nsIDocument::CreateElement / CreateElementNS. r=smaug
https://hg.mozilla.org/integration/mozilla-inbound/rev/f22a28905f0e
Devirtualize FindImageMap. r=smaug
https://hg.mozilla.org/integration/mozilla-inbound/rev/66f34961b2a0
Devirtualize the responsive content stuff. r=smaug
https://hg.mozilla.org/integration/mozilla-inbound/rev/0c316647cefa
Devirtualize GetStateObject. r=smaug
https://hg.mozilla.org/integration/mozilla-inbound/rev/13fc90a09d42
Devirtualize NotifyLayerManagerRecreated. r=smaug
https://hg.mozilla.org/integration/mozilla-inbound/rev/cc1dd3bd0f3d
Devirtualize subdocument stuff. r=smaug
https://hg.mozilla.org/integration/mozilla-inbound/rev/d32d9861f9f5
Devirtualize GetRootElementInternal, and move nsINode overrides to nsIDocument. r=smaug
https://hg.mozilla.org/integration/mozilla-inbound/rev/3f414e52792a
Devirtualize plugins stuff. r=smaug
https://hg.mozilla.org/integration/mozilla-inbound/rev/3651b4affcae
Devirtualize Web Animations stuff. r=smaug
https://hg.mozilla.org/integration/mozilla-inbound/rev/d88013d4c8ec
Devirtualize ScriptLoader. r=smaug
https://hg.mozilla.org/integration/mozilla-inbound/rev/c60390623fa5
Devirtualize the scroll to ref stuff. r=smaug
https://hg.mozilla.org/integration/mozilla-inbound/rev/4b7ec8478e33
Devirtualize GetCurrentContentSink. r=smaug
https://hg.mozilla.org/integration/mozilla-inbound/rev/d974c5995002
Devirtualize the preload / preconnect stuff. r=smaug
https://hg.mozilla.org/integration/mozilla-inbound/rev/2de728da0e23
Devirtualize GetBoxObjectFor / ClearBoxObjectFor. r=smaug
https://hg.mozilla.org/integration/mozilla-inbound/rev/67e8b8e07b83
Devirtualize GetAnonymousElementByAttribute. r=smaug
https://hg.mozilla.org/integration/mozilla-inbound/rev/ada1aea7e99d
Devirtualize more animation stuff. r=smaug
https://hg.mozilla.org/integration/mozilla-inbound/rev/8b49b1134947
Devirtualize event handling suppression stuff. r=smaug
https://hg.mozilla.org/integration/mozilla-inbound/rev/f3055b17e7b5
Devirtualize GetTemplateContentsOwner. r=smaug
https://hg.mozilla.org/integration/mozilla-inbound/rev/3058e5b00ff6
Devirtualize the external resource stuff. r=smaug
https://hg.mozilla.org/integration/mozilla-inbound/rev/0238e1f73640
Devirtualize pointer lock and screen orientation stuff. r=smaug
https://hg.mozilla.org/integration/mozilla-inbound/rev/7dad8de751d8
Devirtualize GetChannel. r=smaug
https://hg.mozilla.org/integration/mozilla-inbound/rev/ca5e80b66c8a
Devirtualize CreateShell / DeleteShell. r=smaug
https://hg.mozilla.org/integration/mozilla-inbound/rev/eaba06c286c2
Move OnPageShow / OnPageHide to nsIDocument, devirtualize OnPageHide. r=smaug
https://hg.mozilla.org/integration/mozilla-inbound/rev/0a1ca0f7d2d2
Devirtualize NodesFromRectHelper. r=smaug
https://hg.mozilla.org/integration/mozilla-inbound/rev/24176f48062e
Devirtualize FlushSkinBindings. r=smaug
https://hg.mozilla.org/integration/mozilla-inbound/rev/e0f058e80094
Devirtualize frame loader stuff. r=smaug
https://hg.mozilla.org/integration/mozilla-inbound/rev/325839c5d0a2
Devirtualize UnblockDOMContentLoaded. r=smaug
https://hg.mozilla.org/integration/mozilla-inbound/rev/471a0e9c8f74
Remove reference to non-existing nsDocument::UpdateScreenOrientation. r=smaug
https://hg.mozilla.org/integration/mozilla-inbound/rev/983c290db1d6
Devirtualize WillDispatchMutationEvent / MutationEventDispatched. r=smaug
https://hg.mozilla.org/integration/mozilla-inbound/rev/c1256481c7c9
Devirtualize GetLayoutHistoryState. r=smaug
https://hg.mozilla.org/integration/mozilla-inbound/rev/2bf3fbd4d8e9
Devirtualize Sanitize. r=smaug
https://hg.mozilla.org/integration/mozilla-inbound/rev/c641a8b309e1
Devirtualize CanSavePresentation. r=smaug
https://hg.mozilla.org/integration/mozilla-inbound/rev/55dc61b6ab44
Move mExpandoAndGeneration back to nsDocument for now. r=smaug

Comment 73

[Eliza Balazs [:ebalazs_]]

https://hg.mozilla.org/mozilla-central/rev/d9a86837189b
https://hg.mozilla.org/mozilla-central/rev/b6e079d22001
https://hg.mozilla.org/mozilla-central/rev/9f04d67a53d8
https://hg.mozilla.org/mozilla-central/rev/a9fbfa2fc6ef
https://hg.mozilla.org/mozilla-central/rev/63372eeecb17
https://hg.mozilla.org/mozilla-central/rev/0d36b03f0bc4
https://hg.mozilla.org/mozilla-central/rev/d616bcc96e36
https://hg.mozilla.org/mozilla-central/rev/8edab3c72a62
https://hg.mozilla.org/mozilla-central/rev/5abd81195c99
https://hg.mozilla.org/mozilla-central/rev/e654cbd9fd4b
https://hg.mozilla.org/mozilla-central/rev/7f532b7d5997
https://hg.mozilla.org/mozilla-central/rev/0ec71c2eb977
https://hg.mozilla.org/mozilla-central/rev/f22a28905f0e
https://hg.mozilla.org/mozilla-central/rev/66f34961b2a0
https://hg.mozilla.org/mozilla-central/rev/0c316647cefa
https://hg.mozilla.org/mozilla-central/rev/13fc90a09d42
https://hg.mozilla.org/mozilla-central/rev/cc1dd3bd0f3d
https://hg.mozilla.org/mozilla-central/rev/d32d9861f9f5
https://hg.mozilla.org/mozilla-central/rev/3f414e52792a
https://hg.mozilla.org/mozilla-central/rev/3651b4affcae
https://hg.mozilla.org/mozilla-central/rev/d88013d4c8ec
https://hg.mozilla.org/mozilla-central/rev/c60390623fa5
https://hg.mozilla.org/mozilla-central/rev/4b7ec8478e33
https://hg.mozilla.org/mozilla-central/rev/d974c5995002
https://hg.mozilla.org/mozilla-central/rev/2de728da0e23
https://hg.mozilla.org/mozilla-central/rev/67e8b8e07b83
https://hg.mozilla.org/mozilla-central/rev/ada1aea7e99d
https://hg.mozilla.org/mozilla-central/rev/8b49b1134947
https://hg.mozilla.org/mozilla-central/rev/f3055b17e7b5
https://hg.mozilla.org/mozilla-central/rev/3058e5b00ff6
https://hg.mozilla.org/mozilla-central/rev/0238e1f73640
https://hg.mozilla.org/mozilla-central/rev/7dad8de751d8
https://hg.mozilla.org/mozilla-central/rev/ca5e80b66c8a
https://hg.mozilla.org/mozilla-central/rev/eaba06c286c2
https://hg.mozilla.org/mozilla-central/rev/0a1ca0f7d2d2
https://hg.mozilla.org/mozilla-central/rev/24176f48062e
https://hg.mozilla.org/mozilla-central/rev/e0f058e80094
https://hg.mozilla.org/mozilla-central/rev/325839c5d0a2
https://hg.mozilla.org/mozilla-central/rev/471a0e9c8f74
https://hg.mozilla.org/mozilla-central/rev/983c290db1d6
https://hg.mozilla.org/mozilla-central/rev/c1256481c7c9
https://hg.mozilla.org/mozilla-central/rev/2bf3fbd4d8e9
https://hg.mozilla.org/mozilla-central/rev/c641a8b309e1
https://hg.mozilla.org/mozilla-central/rev/55dc61b6ab44

Comment 74

[Masatoshi Kimura [:emk]]

(In reply to Emilio Cobos Álvarez [:emilio] from comment #14)
> Comment on attachment 8957771 [details]
> Bug 1444580: Devirtualize more nsIDocument bits. r=smaug
> 
> Submitting multiple patches with Phabricator is a pain.

Is a bug filed to improve it before we are forced to use Phabricator?