1444651 - Port Bug 1395508 to SeaMonkey

Status: RESOLVED FIXED

(SeaMonkey :: Location Bar, defect)

Description

[Frank-Rainer Grahl (:frg)]

We are missing the patch for Bug 1395508 in SeaMonkey.

https://hg.mozilla.org/mozilla-central/rev/a14cc3bd9643

I don't have access to the bug but from the changeset it seems that whitespaces may be displayed as spaces and push additional content out of the visible area:

You can verify this when using the url from the tests:

> +    loadURL: "http://example.com/%E3%80%80%E3%80%80",
> +    expectedURL: "example.com/%E3%80%80%E3%80%80",
> +    copyExpected: "http://example.com/%E3%80%80%E3%80%80"

SeaMonkey will display it as "http:/example.com/   "

Should be fixed for 2.49.3

Comment 1

[:Gijs (he/him)]

(In reply to Frank-Rainer Grahl (:frg) from comment #0)
> I don't have access to the bug

I've CC'd you. Sorry for not pro-actively flagging this up with you.

Comment 2

[Frank-Rainer Grahl (:frg)]

Thanks. The example applies 1:1 to SeaMonkey so as this isn't just copy paste setting sec-moderate as in bug 1395508.

Comment 3

[Frank-Rainer Grahl (:frg)]

Attachment: poc.html

address bar spoof using hebrew.

poc.html

<meta http-equiv="content-type" content="text/html;charset=utf-8">
<script>
    
    function aa(){
        var link = document.createElement('a');
        link.href = "https://xn--ggbla1c4e.xn--ngbc5azd/#"+Array(0x200).join("%20")+"סוֹ.סח";
        link.target="aaaa";
        document.body.appendChild(link);
        link.click();
    }
    
</script>
    
<a onclick="aa();" href="javascript:void(0);">CLICK ME</a>
Expected Result:
https://اسماء.شبكة

Rendered Results:
https://no.io

Comment 4

[Frank-Rainer Grahl (:frg)]

Attachment: 1444651-PortBug1395508.patch

Regex expression is not 1:1 because we filter out some more control chars later.

[Approval Request Comment]
Regression caused by (bug #): ---
User impact if declined: security risk. 
Testing completed (on m-c, etc.): c-r 2.53
Risk to taking this patch (and alternatives if risky): trivial patch
String changes made by this patch: --

Comment 5

[Ian Neal]

Comment on attachment 8957881 [details] [diff] [review]
1444651-PortBug1395508.patch

LGTM r/a=me

Comment 6

[Frank-Rainer Grahl (:frg)]

https://hg.mozilla.org/comm-central/rev/7c8d66add87f514b65d981ea6bbd4fa581596f80
https://hg.mozilla.org/releases/comm-beta/rev/5213294dca3881e02bf54fdc7d123479676adc18
https://hg.mozilla.org/releases/comm-release/rev/7cf3bc4b2bbc9fe7b59b84bd5c3523ee8e64a5ae
https://hg.mozilla.org/releases/comm-esr52/rev/1216b956d1b014874d2d82b9ef3f91e753f74c67

Comment 7

[Frank-Rainer Grahl (:frg)]

Target 2.53.1
https://gitlab.com/seamonkey-project/seamonkey-2.53-comm/-/commit/68087074c9b2e62e8e4cd5460c6e855e0d6b5b25