1444791 - update mdn pages to reference Phabricator

Status: RESOLVED FIXED

(Conduit :: Documentation, enhancement)

Description

[:glob ✱]

there's a couple of mdn pages that reference mozreview that would need to be updated before we mothball mozreview.  there's likely to be more that need updating, but these two are very often provided as a reference for new contributors and should be updated as part of the decommissioning plan.

step 4 of https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Introduction probably just needs editing

https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/How_to_Submit_a_Patch is a much more extensive document that we should probably take ownership of and fix up for phabricator and lando.


i'm not sure how this would mesh with the plans to remove these docs from mdn; perhaps it would be the right time to move those docs out?  :sheppy should be able to shed some light on that.


http://mozilla-version-control-tools.readthedocs.io/en/latest/mozreview-user.html should redirect to the moz-conduit docs.

Comment 1

[Mark Côté [:mcote]]

Hi sheppy, just to confirm, we are slowly moving all Firefox-development docs out of MDN, yes?  If so, are there guidelines for such movement (e.g. appropriate new locations)?

Comment 2

[:glob ✱]

> we are slowly moving all Firefox-development docs out of MDN, yes?

sheppy said "no" to me a while ago.

Comment 3

[Mark Côté [:mcote]]

I also found https://developer.mozilla.org/en-US/docs/Mercurial/Using_Mercurial.  It's marked as obsolete... but I wonder why it even exists then.  Worse, there's a link directly to an anchor lower down in that page from the How_to_Submit_a_Patch page, so it would be super easy to miss the warning at the top.  I'll follow up with someone about getting it deleted.

https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Requesting_feedback_and_ui-review_for_desktop_Firefox_front-end_changes needs some tweaking to reflect that the feedback and ui-review flags won't exist anymore, and that patches won't be uploaded to Bugzilla.

Also there is a lot of documentation around super-review.  It seems that there's a consensus that super-review isn't used anymore and documentation about it should be removed.  I think this is even more useful now that we're moving to a system that doesn't differentiate between different types of feedback/review, aside from blocking vs nonblocking.  https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Code_Review_FAQ is the main page I found on MDN, and https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Committing_Rules_and_Responsibilities mentions super-review briefly.  There is also https://www.mozilla.org/en-US/about/governance/policies/reviewers/.

Comment 4

[Mark Côté [:mcote]]

https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/How_to_Submit_a_Patch has been updated.  It still links to https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Requesting_feedback_and_ui-review_for_desktop_Firefox_front-end_changes, which mentions feedback and ui-review.  Those flags aren't available in Differential, but for ui-review in particular we don't have another process, which is for another bug.

Comment 5

[Mark Côté [:mcote]]

Looks like mhoye updated https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Introduction already, but I added a few more things, including that Phabricator is preferred, and I removed references to r+ in favour of "accepted", since "r+" doesn't make any sense in the world of Phabricator (I hope that an r+ is understood as meaning accepted for anyone new who is using Bugzilla).

Comment 6

[Mark Côté [:mcote]]

Doesn't look like I can delete a page, so I stripped out almost all the content from https://developer.mozilla.org/en-US/docs/Mercurial/Using_Mercurial except a warning and a link to readthedocs.

Comment 7

[Mark Côté [:mcote]]

https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Requesting_feedback_and_ui-review_for_desktop_Firefox_front-end_changes has been updated to reflect the new process involving the firefox-ux-team project.

Comment 8

[Mark Côté [:mcote]]

Updated https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Code_Review_FAQ, which mostly involved chopping out lots of obsolete super-reviewer content.

I haven't noticed any other relevant pages, so I'll close this out.